From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752243AbdHHOU1 (ORCPT ); Tue, 8 Aug 2017 10:20:27 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:63888 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030AbdHHOU0 (ORCPT ); Tue, 8 Aug 2017 10:20:26 -0400 Subject: Re: [PATCH] usb: gadget: f_uac2: calculate wMaxPacketSize before endpoint match To: Sekhar Nori , Felipe Balbi , Greg Kroah-Hartman CC: Bin Liu , , References: <09d1259f224a2427a326d3589765dc149e577c75.1495008408.git.nsekhar@ti.com> From: Roger Quadros Message-ID: Date: Tue, 8 Aug 2017 17:20:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <09d1259f224a2427a326d3589765dc149e577c75.1495008408.git.nsekhar@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/05/17 11:15, Sekhar Nori wrote: > Calculate wMaxPacketSize before endpoint matching the > descriptor is found. > > This allows audio gadget to be used with controllers > which have a shortage or unavailability of endpoints > that can handle max packet size of 1023 (FS) or 1024 > (HS). > > With this audio gadget can be used on TI's OMAP-L138 SoC > which has a MUSB HS controller with endpoints having max > packet size much less than 1023 or 1024. See mode_2_cfg in > drivers/usb/musb/musb_core.c > > Signed-off-by: Sekhar Nori Acked-by: Roger Quadros > --- > drivers/usb/gadget/function/f_uac2.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c > index f6a0d3a1311b..5a7ba058d947 100644 > --- a/drivers/usb/gadget/function/f_uac2.c > +++ b/drivers/usb/gadget/function/f_uac2.c > @@ -1065,6 +1065,12 @@ afunc_bind(struct usb_configuration *cfg, struct usb_function *fn) > agdev->as_in_intf = ret; > agdev->as_in_alt = 0; > > + /* Calculate wMaxPacketSize according to audio bandwidth */ > + set_ep_max_packet_size(uac2_opts, &fs_epin_desc, 1000, true); > + set_ep_max_packet_size(uac2_opts, &fs_epout_desc, 1000, false); > + set_ep_max_packet_size(uac2_opts, &hs_epin_desc, 8000, true); > + set_ep_max_packet_size(uac2_opts, &hs_epout_desc, 8000, false); > + > agdev->out_ep = usb_ep_autoconfig(gadget, &fs_epout_desc); > if (!agdev->out_ep) { > dev_err(dev, "%s:%d Error!\n", __func__, __LINE__); > @@ -1080,12 +1086,6 @@ afunc_bind(struct usb_configuration *cfg, struct usb_function *fn) > uac2->p_prm.uac2 = uac2; > uac2->c_prm.uac2 = uac2; > > - /* Calculate wMaxPacketSize according to audio bandwidth */ > - set_ep_max_packet_size(uac2_opts, &fs_epin_desc, 1000, true); > - set_ep_max_packet_size(uac2_opts, &fs_epout_desc, 1000, false); > - set_ep_max_packet_size(uac2_opts, &hs_epin_desc, 8000, true); > - set_ep_max_packet_size(uac2_opts, &hs_epout_desc, 8000, false); > - > hs_epout_desc.bEndpointAddress = fs_epout_desc.bEndpointAddress; > hs_epin_desc.bEndpointAddress = fs_epin_desc.bEndpointAddress; > > -- cheers, -roger