From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 709D61DEFE9 for ; Thu, 4 Dec 2025 01:31:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764811916; cv=none; b=S9h5qz5fV18D5ME3th+mSmH9EjxkifxNESauD8TirUcrjkPjQcViENn8gmsZafJjw8PLUP9e++ikrC/JDiO4OcFhuJH8YbMukli4N7sdZEMqX+FzfpLfEVlFLTtqpyTYh/zPvMu4wr73h6ehim3CYIBspABKkE/gfn+02UBmQ14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764811916; c=relaxed/simple; bh=yqRq0TAR6wsZWEznBHeDJMwCJbb1TMmKfjuiskaHz6I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dyc8qMAP9CsVNn19f4TM/3yc/yfevkQb9KFCyOOd10rmwav52BA7Wk+MGROgEkUIlU2b63p/GNGdWIRpxcbP7XAEr9ZkIzaSU5hzlazl6nLt2AEQ3YFrPaO1MpPLMS4BK3MbgRcam7nYUzfQEgLSCPONtRR+st2NLnwy5xFymxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LriL6Syo; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LriL6Syo" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-597c418b79eso38040e87.2 for ; Wed, 03 Dec 2025 17:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764811912; x=1765416712; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=KO6gdye/RhzRaWkQiwbtb2L+tSAStzv+9WJjZmM1LrY=; b=LriL6SyovnSF4euNsHzkv044RwDujCsilF1ynoxmvuVReyGZKwjmvcWq3LL8TmkKu5 McNBJ1QgKht6E19z0RdnGhLsSzFXzkxtOzgPOjrrj7suWQWeP9lxLbsAMz3Ke2bOiuee 0C0sNPZ3IJvtXXfQgeov3vfkiH5zdqmgPGVBDaH6sXL2eX+m0VYYZNtzKmd+S0YP12PQ 1f1JT0H0LYys7oGiiESWbj+KCbfAjS/s/f8g42lsYbE8SICr6GjVBbHWsASsY9CG7fek iJBvi8BLMCaRTKimvkGDZlbSvLZGz2aX7/9cjJGHHPZp4Sct4l678jKyssTYCsxt1rLv zi8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764811912; x=1765416712; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KO6gdye/RhzRaWkQiwbtb2L+tSAStzv+9WJjZmM1LrY=; b=vsz4UmV4G3FlprT9rSvkipUgyRvLq5LQf1kvm6XPeIdB18x7X8ap4UlkxMksQsNSwK lVcDCaEBIqZAuSoBTU75VWPN9d4WITI9cioDeqKUTsH5v306q5OhBWnKZfMkPJqwSzgZ 988C7o/ooHhykAp8JjkL170NoxPQkoAZKG9Av5wBRrqa/GFqmTpQ3Ophgm4i2OkN6R6q dDwJqueoRqHxBNiAt0yIiBh+0APA89y/W+OngFhH/uNj7jgUpLPVyDN1YoiWxflbSj4W knojNoS3miQOv8m9G2Kpz9y7RtfQX99km6+qWJmkkp3mlLEop5LoO/FXX44YuTXRsmzF wn2w== X-Forwarded-Encrypted: i=1; AJvYcCWcEyWIYUdXuPBzmbsm5/8j7ewN/tVHhP9CmAwepYA2bchsWEueZNE8LJ6nm4XFndcGCxcpv67JLcq0DaI=@vger.kernel.org X-Gm-Message-State: AOJu0YzHwEEay2v95AMavtvIHqeMU+uxjTc9vqdqh5b9UKxK8k+DvSgt /PdK8svebBVpx60dm8pi6BgNAaJ2yXfT1qJRKUaSaJ0SSakJoR3K7vzNvPp6fTHlIp0= X-Gm-Gg: ASbGncv9UulJDlXZUZghJ0TaiJZeWzO0K8wqfdGJGTvKu1GVDYC4hJxp17QEldxnv1U vkrfUElE8Hm+sN8MIqXwdZGmU8svAVNGJmkBkC+yfunDwiOX+cuFpjBxONLmDhMfX+IMKBdV1PT m48IEBASZJlkpKJqnEf+TQajl0wo2UlCri8Y0gZcWNjv6pOmghUqI8mMw1x4Qe2Wr9+V73swzMG 2RL23SMK5nYEjU2M0UE1F5FUkVmIK0E8S31EZGHXwA3PaPFXgwkoOLX4XhNwuDoKmIAgDfZFwVR TQlbMp0NZRvHXgUMx4I5giXfiuzcF/8oYX7GrDWEzR2GitdcLOSk1n1FGcFpKjwEL3Kx5zAd2fq 0gFNKVGRWki6P2m7NkQ8JEfrSBUb7J3x+JWX68N8vTR86/Egf5vYoRAuvRy/Zd7ciNiOd+31yHw uUzbR1wJ9gezA5W5f08Y51hhd2EZk2Wz/Flw1okv8g709iM+dahNk+VjHYKKkBOaTT+w== X-Google-Smtp-Source: AGHT+IHo7YgZeNSkYmmPqS3Gf1PHEGCQcMyGJaPj2KfZGUd/FbgacScdkjipGnwCUE2nldbH/0enXQ== X-Received: by 2002:a05:6512:b8e:b0:594:253c:20a5 with SMTP id 2adb3069b0e04-597d4b2e1b7mr722453e87.5.1764811911546; Wed, 03 Dec 2025 17:31:51 -0800 (PST) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-596bf8b0668sm6344758e87.39.2025.12.03.17.31.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 17:31:51 -0800 (PST) Message-ID: Date: Thu, 4 Dec 2025 03:31:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] media: dt-bindings: Add CAMSS device for SM8750 To: Krzysztof Kozlowski , Hangxiang Ma Cc: Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Mauro Carvalho Chehab , Bryan O'Donoghue , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, jeyaprakash.soundrapandian@oss.qualcomm.com, Vijay Kumar Tumati References: <20251126-add-support-for-camss-on-sm8750-v1-0-646fee2eb720@oss.qualcomm.com> <20251126-add-support-for-camss-on-sm8750-v1-2-646fee2eb720@oss.qualcomm.com> <20251127-smart-tuatara-of-downpour-88c16d@kuoka> From: Vladimir Zapolskiy In-Reply-To: <20251127-smart-tuatara-of-downpour-88c16d@kuoka> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/27/25 10:10, Krzysztof Kozlowski wrote: > On Wed, Nov 26, 2025 at 01:38:35AM -0800, Hangxiang Ma wrote: >> Add the compatible string "qcom,sm8750-camss" to support the Camera > > s/to support the/for the/ > > Bindings do not support hardware. > >> Subsystem (CAMSS) on the Qualcomm SM8750 platform. >> >> The SM8750 platform provides: >> - 3 x VFE, 5 RDI per VFE >> - 2 x VFE Lite, 4 RDI per VFE Lite >> - 3 x CSID >> - 2 x CSID Lite >> - 6 x CSIPHY >> - 2 x ICP >> - 1 x IPE >> - 2 x JPEG DMA & Downscaler >> - 2 x JPEG Encoder >> - 1 x OFE >> - 5 x RT CDM >> - 3 x TPG >> >> Signed-off-by: Hangxiang Ma >> --- >> .../bindings/media/qcom,sm8750-camss.yaml | 664 +++++++++++++++++++++ >> 1 file changed, 664 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8750-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8750-camss.yaml >> + >> + vdd-csiphy0-0p88-supply: > > 88->8, so: vdd-csiphy0-0p8-supply: I would make a minor correction here, it'd be rather 0p9. > Same in other places. This is how it is called for every binding. > >> + description: >> + Phandle to a 0.88V regulator supply to CSIPHY0 core block. >> + >> + vdd-csiphy0-1p2-supply: >> + description: >> + Phandle to a 1.2V regulator supply to CSIPHY0 pll block. >> + >> + vdd-csiphy1-0p88-supply: >> + description: >> + Phandle to a 0.88V regulator supply to CSIPHY1 core block. -- Best wishes, Vladimir