From: Alexandre Mergnat <amergnat@baylibre.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
chunkuang.hu@kernel.org
Cc: p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch,
matthias.bgg@gmail.com, dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@collabora.com,
wenst@chromium.org, nfraprado@collabora.com
Subject: Re: [PATCH v6 03/11] drm/mediatek: dp: Change logging to dev for mtk_dp_aux_transfer()
Date: Thu, 20 Jul 2023 17:57:58 +0200 [thread overview]
Message-ID: <d2817cd7-0d44-5572-8e38-da5478da5fe7@baylibre.com> (raw)
In-Reply-To: <20230717141438.274419-4-angelogioacchino.delregno@collabora.com>
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote:
> Change logging from drm_{err,info}() to dev_{err,info}() in functions
> mtk_dp_aux_transfer() and mtk_dp_aux_do_transfer(): this will be
> essential to avoid getting NULL pointer kernel panics if any kind
> of error happens during AUX transfers happening before the bridge
> is attached.
>
> This may potentially start happening in a later commit implementing
> aux-bus support, as AUX transfers will be triggered from the panel
> driver (for EDID) before the mtk-dp bridge gets attached, and it's
> done in preparation for the same.
--
Regards,
Alexandre
next prev parent reply other threads:[~2023-07-20 15:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 14:14 [PATCH v6 00/11] MediaTek DisplayPort: support eDP and aux-bus AngeloGioacchino Del Regno
2023-07-17 14:14 ` [PATCH v6 01/11] drm/mediatek: dp: Add missing error checks in mtk_dp_parse_capabilities AngeloGioacchino Del Regno
2023-07-18 8:02 ` CK Hu (胡俊光)
2023-07-20 15:56 ` Alexandre Mergnat
2023-07-17 14:14 ` [PATCH v6 02/11] drm/mediatek: dp: Move AUX and panel poweron/off sequence to function AngeloGioacchino Del Regno
2023-07-18 7:49 ` CK Hu (胡俊光)
2023-07-20 15:56 ` Alexandre Mergnat
2023-07-17 14:14 ` [PATCH v6 03/11] drm/mediatek: dp: Change logging to dev for mtk_dp_aux_transfer() AngeloGioacchino Del Regno
2023-07-18 9:19 ` CK Hu (胡俊光)
2023-07-20 15:57 ` Alexandre Mergnat [this message]
2023-07-17 14:14 ` [PATCH v6 04/11] drm/mediatek: dp: Use devm variant of drm_bridge_add() AngeloGioacchino Del Regno
2023-07-18 9:33 ` CK Hu (胡俊光)
2023-07-20 15:58 ` Alexandre Mergnat
2023-07-17 14:14 ` [PATCH v6 05/11] drm/mediatek: dp: Move AUX_P0 setting to mtk_dp_initialize_aux_settings() AngeloGioacchino Del Regno
2023-07-20 2:01 ` CK Hu (胡俊光)
2023-07-20 15:59 ` Alexandre Mergnat
2023-07-17 14:14 ` [PATCH v6 06/11] drm/mediatek: dp: Enable event interrupt only when bridge attached AngeloGioacchino Del Regno
2023-07-20 13:03 ` Alexandre Mergnat
2023-07-17 14:14 ` [PATCH v6 07/11] drm/mediatek: dp: Avoid mutex locks if audio is not supported/enabled AngeloGioacchino Del Regno
2023-07-20 13:05 ` Alexandre Mergnat
2023-07-24 2:33 ` CK Hu (胡俊光)
2023-07-17 14:14 ` [PATCH v6 08/11] drm/mediatek: dp: Move PHY registration to new function AngeloGioacchino Del Regno
2023-07-20 13:58 ` Alexandre Mergnat
2023-07-17 14:14 ` [PATCH v6 09/11] drm/mediatek: dp: Add support for embedded DisplayPort aux-bus AngeloGioacchino Del Regno
2023-07-20 14:30 ` Alexandre Mergnat
2023-07-24 6:24 ` CK Hu (胡俊光)
2023-07-17 14:14 ` [PATCH v6 10/11] drm/mediatek: dp: Add .wait_hpd_asserted() for AUX bus AngeloGioacchino Del Regno
2023-07-20 15:03 ` Alexandre Mergnat
2023-07-24 8:43 ` CK Hu (胡俊光)
2023-07-17 14:14 ` [PATCH v6 11/11] drm/mediatek: dp: Don't register HPD interrupt handler for eDP case AngeloGioacchino Del Regno
2023-07-20 15:55 ` Alexandre Mergnat
2023-07-25 6:37 ` CK Hu (胡俊光)
2023-07-25 7:19 ` AngeloGioacchino Del Regno
2023-07-19 4:00 ` [PATCH v6 00/11] MediaTek DisplayPort: support eDP and aux-bus Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2817cd7-0d44-5572-8e38-da5478da5fe7@baylibre.com \
--to=amergnat@baylibre.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®