From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4579F42B75A for ; Tue, 20 Jan 2026 12:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768913014; cv=none; b=owV+jpRgNf2pomyOGONFOg3wI3x1PT9akJlIsOuJVHExKz207iZ/8asF0sTAKLVjdX/HKVuKmnliiBmcazNW8rKfQHkvnuFhFH5dj7ltpn8KUMreM/FWY4YbW2B3PAJVNcDFy2HwzdlbaDlZ6FJjPpDoWPNByiy3+O9XhgE6jfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768913014; c=relaxed/simple; bh=Bqt66FG37gQPzxXo8GEua4Yy1cjRKNOcuhnhCZqtlb8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tWissUPxvgUA8ssRQnieVCAaiRfExnJs2JY5Ko8cicZ39gFr2QVbuqjJ3WQW/Pumc0FBYS+cazKhkmCsJLBDCmlcoBElWRRgl0Wh39jsKrefGXEDZH4E3fYqxDLqCSKLlMIncYqWCjuuPvKJ9nJEAYoMAmBwKlG9StWaTVHOvjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z7D643z6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KpsIU6Mj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z7D643z6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KpsIU6Mj" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60KACxvu1347293 for ; Tue, 20 Jan 2026 12:43:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vaWIDj6o3+/nwUwiV/H8Dqvr4BjKk1GgvJw43iLVUDU=; b=Z7D643z6cqtblgZ/ xBLNFx79HvoR14QSrGHjemMePUy1Aec7iZJQmsyEjFOxZOtUUrVivAlWr6JpPSlO 6Tn4jx6VUNR2YDmWMUj5N6K9f8crxqpucoXa5gdzHJPugKJr/PSbslQWP2rfFjbP h4MCi/sXv+D4nItzhsR6cYphjcC/ZRhOmC0ZYRcZZW+1Wb0QRQcyIRETdgIzlYqS OrtLhfp8E2GQrDv0Jx4jwF6nSgE7oE2ciiCCuItv0BzjhMZFlutp7JRK1JdHnbwF AfLUQvRBJhdNevCaw0PDBhhMGojTkEKEKZtDL2W8jRfJ/nNJbp7fhqgY42nYijUf hiEmHA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bsnpdk8g8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 20 Jan 2026 12:43:31 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-501506ff58fso16945171cf.1 for ; Tue, 20 Jan 2026 04:43:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768913011; x=1769517811; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vaWIDj6o3+/nwUwiV/H8Dqvr4BjKk1GgvJw43iLVUDU=; b=KpsIU6MjVMuGX9K4FQsJyi00pfZgHEIzA5XebSscnBUYAEgAcuiSDS/2ooXRJ2HJLD vO6a328wO4j5YAfQgtBFZJKOM0i2fBt6EvXqn03tZCSmV5r1kw3fbX188U2pJtSIHTiD C3QDIf540N7SzadnRhSOhAHbGs1Za6wtnHN+P08UfhYju0AhpR1xr5nln6z/2GtBUR1P JtMafvqdsW117oOv2pwYlvAIr7uXp+XaPsXvoqupLbt5OAkzlzuwcJkxL6TLlD282iUH ddJ1Df0XrMmDtA97jBu2fNWWWjoICPyVhOtiM2APAGfw2Aw8N1ph4YIv/YEkIKY8ybTD gwnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768913011; x=1769517811; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vaWIDj6o3+/nwUwiV/H8Dqvr4BjKk1GgvJw43iLVUDU=; b=V8xWnzLBQ1UVW/mEsaFccHC/mZNBIKjP6385clvilGi7hvYXydK2ZShkq7qrYGGA3U fRWVZCX+PfB8g3poVrNd8B5YqYdWWIRT9T7XVlEnruWyTBJVBsBLMrS+H16GdHGY4tJf D0jqZ7e1Gwu4FG7PtxQGvSkjvgQWpFqkEpTmbMsJ4fyPaSm3+gkD/UBK+G/TgTxonirx JOHOetrTOjOPw1CyoGFK2XnNKqhJthKW+wko9Y+gnZNg2i9nNtxbkWJz6fcQyjY6RHom MBhVpjncikXrrWY2WYycfjc/eECb3C5OJPu7XyDOP4grI7D8FNgry5J/CcSTsLWPJ5+Z EDkQ== X-Forwarded-Encrypted: i=1; AJvYcCUn2vH3PpP68BdouVXbf3SuUxNBe8LsLydLRnLV88eURSicirQLR5RJDntkVQ0NF28tWWW2yaHunCWeUvs=@vger.kernel.org X-Gm-Message-State: AOJu0YzkaPLuMSKLzxRYVthpDgiwcOytSnwJRyNU95A5uHqTwd/sCPGV Yyww+qWQPu81mWkukZaNbnBbzmOMmJhLGZ7ruG8vV+fPgyar8PTr/sGrcibl7xIBX0O3FYF7Q/F dmhLahPqCu3I/cFbJ+wN0oMced6G6WV3bzdEd94zvGznNF6cPMGkkveR0Uu6RLRn5XkQ= X-Gm-Gg: AY/fxX45+MsBQXT3OYgWUFgB8VZFqapHG2FwR0+c0h1MVbTigEkmbJn8sfNrhiZf1F5 Mv7KgBlTnjjIYsuJuEwU1nrKTDiND1qu6PODOdvKHahg6DftYz3p9qcWcJlTWZXcQYxlOXLp62K PkYCmaIxC8mPEpecwKZoY8p7kXUrN7Lt7sg4W0mA/7U1puGM6KM7zSfZiU+/hKsYOOldPIv9Jq1 VhDCmvUpDe4BjEc2SZV0XOPZm+bpYXOplupETxX/3rlDRS73APAjuq/w0wE7OCzBk0Q9p5CKppC 0fGuTZXv0OC6cu4AidZjHuN0+2euiCM2YVHTsZwVQ028NIoVlJ/jD+9sVvMR4OXj2lIc8uZKo0+ EXad8Eh1uMNPHZHEUtve3iM/cC4h4ACQrDpz60ZFTwumD2BCTAxsqGR9Dt+3FrN1/02g= X-Received: by 2002:ac8:7f56:0:b0:501:4767:a64 with SMTP id d75a77b69052e-502a16b7389mr165053751cf.5.1768913010474; Tue, 20 Jan 2026 04:43:30 -0800 (PST) X-Received: by 2002:ac8:7f56:0:b0:501:4767:a64 with SMTP id d75a77b69052e-502a16b7389mr165053381cf.5.1768913009853; Tue, 20 Jan 2026 04:43:29 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-654535c49dbsm13597080a12.32.2026.01.20.04.43.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jan 2026 04:43:29 -0800 (PST) Message-ID: Date: Tue, 20 Jan 2026 13:43:27 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Add Focaltech FT3518 touchscreen To: yedaya.ka@gmail.com, =?UTF-8?Q?Kamil_Go=C5=82da?= , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260118-touchscreen-patches-v3-0-1c6a729c5eb4@gmail.com> <20260118-touchscreen-patches-v3-3-1c6a729c5eb4@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260118-touchscreen-patches-v3-3-1c6a729c5eb4@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=NtncssdJ c=1 sm=1 tr=0 ts=696f7873 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Uyhorv2uAAAA:20 a=pGLkceISAAAA:8 a=sfOm8-O8AAAA:8 a=8Y00a8MOIoAAH37gNwoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=TvTJqdcANYtsRzA46cdi:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-GUID: Sap0U4wSJogv1hQIRQvXv0j2bWfjcbWu X-Proofpoint-ORIG-GUID: Sap0U4wSJogv1hQIRQvXv0j2bWfjcbWu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIwMDEwNSBTYWx0ZWRfXwsS02uqTTdxQ +d05gt0jsk4kkhTnqxs7/o2UB3HqJ/WGEpt88apAVht/U4KwK82ug7RMOHSEkbeq7QgssRCyGz7 Dg2uDv6Wl3NWF4M6I2bSV+wBr61vHnTZ+diLsz12LTBlQdyTGYLY92o+tV5PSIF0nN2KrhJwdpY gh4Q+Ca+9KrlgnG/orTQ5GO7cFp7ccYxJeJijfyvxgUwQ8pgHlv95IYvkQCapMfqyvm1VTEDBdJ gsAL4kLwwrp4dBQ3TJ2GsvlV2OirxQWXzZHcY4hg+SBxYAdqofSszoZDc5X8S0thzdxuu0wkX2m UdW3Zv1HDGLgGLhsg4DfoYynRlYhNs/IkcEhhJknrTo5lwZMxHMKQeLiDeisosD62N3Ek7k/A/2 5aFdpjH/75bqlETGv/eiIEwksgmFAC0c5cgTOs8BoI1lEShA5M9JuJ1KvSNXqAJq2+RpBqQiy1w td2JnPuVd1aqF/YvqXA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-20_03,2026-01-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601200105 On 1/18/26 9:29 PM, Yedaya Katsman via B4 Relay wrote: > From: Yedaya Katsman > > Add device tree node for the Focaltech FT3518 touchscreen on > Xiaomi Mi A3 (laurel-sprout). > > Add pmx_ts_* gpio configurations and reference them in the touchscreen > node. > Note that gpio pin 83 for the regulator isn't documented downstream > except in the touchscreen node so it's not defined in the tlmm. > > Enable qupv3_id_0 and i2c2 bus that the touchscreen is on. > > Downstream references: > Link: https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/laurel-r-oss/arch/arm64/boot/dts/qcom/trinket-pinctrl.dtsi > Link: https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/laurel-r-oss/arch/arm64/boot/dts/qcom/laurel_sprout-qrd.dtsi > > Co-developed-by: Kamil Gołda > Signed-off-by: Kamil Gołda > Signed-off-by: Yedaya Katsman > --- [...] > &tlmm { > gpio-reserved-ranges = <22 2>, <28 6>; > + > + pmx_ts_reset_active { Node names must end in -state and you should use dashes instead of underscores in node names ('make dtbs_check' would tell you at least one of these things) > + ts_reset_active: ts_reset_active { > + mux { Please drop the intermediate nodes and put the properties directly under the foo-state {} node. The indirection is useful when we're defining multiple pins with the exact same settings (e.g. 4 lanes of SDIO) Konrad