Re: [PATCH 2/4] hwmon: (adt7475) Convert to hwmon_device_register_with_info()

[Guenter Roeck <linux@roeck-us.net>]

On 11/13/26 16:41, Davíð Steinn Geirsson wrote:
> Convert the driver from hwmon_device_register_with_groups() to
> hwmon_device_register_with_info(). The standard voltage, temperature,
> fan and PWM attributes move to hwmon_ops. The chip-specific attributes
> stay driver-defined and are passed as extra groups: the automatic fan
> control points, temperature smoothing, PWM stall disable,
> pwm_use_point2_pwm_at_crit and the VID attributes.
> 
> The driver keeps data->lock, although the hwmon core serialises the
> hwmon_ops callbacks. The attributes in the extra groups run outside that
> serialisation, and they share the register cache and its periodic update
> with the hwmon_ops callbacks. They do not take hwmon_lock() instead, to
> keep this conversion free of locking changes.
> 

I disagree here. If you don't want to change the locks to use the hwmon
subsystem lock in this patch, add another patch to change the code to
use it. The subsystem lock was not introduced to be ignored.

Thanks,
Guenter