From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48B7D3AE1A0 for ; Tue, 17 Mar 2026 12:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773750062; cv=none; b=GjHiwhgdq6b9jLPt4dw9cewYndZsJEaorFFM4TI9LzpVMwL21LKZfiEwBwCmt0hwjlLigl7GjLdWYTTNeRS5YKzSMfEAGgPjpje2iJDXVOEy9SIhTZku3wmT+91TpfEQjewxqtiSt0IvV3Hb87kFyx0ttY8QTo1lXz2pdtQ1bHQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773750062; c=relaxed/simple; bh=ikYXskdjqT1oBUvXC9EURGXDDr3yzkun5zhv0pI6MFI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eN/Wo5FQR2ab7j+KlSVrpSX2oDIWlBPl2ID7lybBKKBVTNGgmojpDNABVsMw4qyBToxoFrX392MFwtMlCbXsqTLDh1B97dewjtUkk7k0WXWPGS8zlzDc7VTZiJi/LBdShCE45qPK2J9w9x6tWzq1dvlcHXd7aFT75Gk/rPEE9Vw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UYsBRUTY; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=OZQqjBqF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UYsBRUTY"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="OZQqjBqF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773750060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gMR0WXF/fPUdEPH+ksc6APmIhPxNqgYRRVse5Z+N3hE=; b=UYsBRUTYcxy7AC6lpe3qziWahyKLARULZGyUPOyFpdd23KS/H9v10juwYv7NCLeSB3Nvu1 b6NI+ZTQGuYcViegniw0IojXw5DDkhTqJi+3XHVDke8WqFk73jH/Wd/P2Pifx8Mmz+liP2 BXnIZEVrP4ypZ1NsX6z5RDauYxZSu98= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-596-SHINd6WUMz67JrJynBmMtA-1; Tue, 17 Mar 2026 08:20:58 -0400 X-MC-Unique: SHINd6WUMz67JrJynBmMtA-1 X-Mimecast-MFC-AGG-ID: SHINd6WUMz67JrJynBmMtA_1773750057 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-485fb873e57so5078745e9.0 for ; Tue, 17 Mar 2026 05:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773750057; x=1774354857; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gMR0WXF/fPUdEPH+ksc6APmIhPxNqgYRRVse5Z+N3hE=; b=OZQqjBqFji5Vx6OHxzeo0yhAqlL+ayGB6s6MF8G2T3bE2NfRKRGp93FREqnx4LA/uF kaDAbt/wo3kBVEz3PO5luO1u21CQC5yCs+KX5rKG8zoWlh7fd5HRq6Bd1GH/KVOiMDQp EmuKVa52BO16vi+7iH8CNB028krhZ0+VupUM2ewAqThgOLZnt/q2gCGIJEpbOLmldSjD UdoPuxmlQP4Pz3tnigWwaE3EiAJZKhSVeTO6G1di6rwn6jUCpV4pPSChmuYxns3adozH EqSprnl733oWvrPjKW8yLItfqyLMmu7PzUsb74MxxuBbnvVcZm+MeLhPweD9IANqYLeN 12DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773750057; x=1774354857; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gMR0WXF/fPUdEPH+ksc6APmIhPxNqgYRRVse5Z+N3hE=; b=U3c3D1tyuw7GaZxFYGw0rOS8AlmR9pg7RoexiBMWid/uSFkRKvAn7K7RMBOL3Xt6ox TvUBff3GHCymi905AGiJUPtGC+q0+MJWAy1U7T6nigXdPTfdk420QGCDDKaHDEi9Onxw lh7b3zin3p0M5iuP3NgZBvBsUoj6lRMwIym5JC9kmrYlgMV/TPRJmwg3EmUEHHWxW/xY 5v8VMsNB/jNd5vd9fo00gNY3y5WWqJd/+WvGnJORIeqQhPXRqHLh/rOse0XDtM2h65Yt zYukoMDCGHYr5bF1I1ZDipBgbK4DNeLuVw/j1HCe5QGFZpsVzDmH5SW/cxbJDGsqbYhF N7xw== X-Gm-Message-State: AOJu0YxQDnf6psPZgWczkn5F2JIPK8RHKHZUR3fPyxMPCvhTUZxh8FdX aQuao4x472q2do/ZasUQLGFO6Jltz0Uaz4tFkZTW4Zn5PJp2mF6Sdd2HLMtVvMPB/2zzK4KTdXe Mr9p5DpWS3OhJCbHTIVdoRbgoD3WLcDLiHmiMN83g3BqZJJ76WIVH9M6YQd6GYkV6Og== X-Gm-Gg: ATEYQzyBRdVqJiLuliUFSmYMUOUB9S/jbQr5a28Xf0R3+seVT1NNqwAeEdvlEERHAEr PkzDz/iurb07J+MzgYCmA+3r1NjAsSRguTy30Ve6VUm5t9ImxD+FiQ1hXBqmyT/MvQPxhBKEVIZ fU895DC7qAEyopFk5KtqtTMYNEkG9nZphtyS0+eMuQvOzfX4f5eIr1YEJhzYqoUswEdx+46kf7V lvY4Vl5+h6TvmmfPVD+Xk7gGeQF1ON05KnFTRQ54HIVgKldm/XdVyZcSQt9GiQyoRjb6k6lXic5 7TNAeQjR/zwGynrwev0FXCygPsxJbBjnPUTCzPwxX4OX4ASJbuIX+hHn5lNxc5eTBClqNtur2xj yWIcty0G/4Jbh61tLP/0FyOD+xCiVdoz+nwAraBwndJ6/EUCxI9GYPT4= X-Received: by 2002:a05:600c:45d5:b0:485:4535:73d with SMTP id 5b1f17b1804b1-485566cfb8amr268349945e9.2.1773750057257; Tue, 17 Mar 2026 05:20:57 -0700 (PDT) X-Received: by 2002:a05:600c:45d5:b0:485:4535:73d with SMTP id 5b1f17b1804b1-485566cfb8amr268349235e9.2.1773750056767; Tue, 17 Mar 2026 05:20:56 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4856eab15f4sm66629305e9.14.2026.03.17.05.20.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 05:20:56 -0700 (PDT) Message-ID: Date: Tue, 17 Mar 2026 13:20:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] amd-xgbe: add robust link-down TX queue handling To: Raju Rangoju , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, andrew+netdev@lunn.ch References: <20260313134628.3827338-1-Raju.Rangoju@amd.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260313134628.3827338-1-Raju.Rangoju@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/13/26 2:46 PM, Raju Rangoju wrote: > Add comprehensive link-down handling to improve driver robustness and > enable fast recovery from link failures. Currently, the driver lacks > proper cleanup mechanisms when the physical link goes down with > packets in-flight, which can impact network stability and failover > performance. > > This enhancement adds intelligent TX queue management during link state > transitions: > > Link-down detection improvements: > - Adaptive polling: 100ms intervals when carrier is up for fast > link-down detection, vs 1000ms when down to conserve CPU > - Enables ~100-200ms link-down response time (10x improvement) > > Smart TX queue handling: > - Immediate TX queue stop on link-down to halt new submissions > - Skip futile hardware drain attempts when link is already down > - Force-cleanup abandoned TX descriptors that hardware won't complete > - Proper descriptor and skb resource reclamation It looks like this one should be split in multiple patches, to better isolate each specific improvements. /P