From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 759E6155C96 for ; Wed, 15 Jan 2025 17:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736960477; cv=fail; b=rZuVhrHHkNESePMYtX/r5vObpLtKAOEu2FIkR1kf1iIn/p75nU5g2+xrdoHis5I/ZuZ4yTNjUFRO6JU3UQ0RObnjykE/JwksnEMsH+DvgYo/JUI+nch8HhbI+R/kK86rR4QJkfTcqN8qTQS8auIzuKGRKssV/Q9fC2C2mKwVXgY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736960477; c=relaxed/simple; bh=tgVmul3EI1QdV1Ruh0rD3mD6aFBFDswGqucSeFpKk/k=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=EiKehw6iulqkt3blsPD2JENuT8Wzk0sxorDOvvsAKAdg3JFKoe910+iK1Z1RXugt/OYi/dAgt62N0ymGYY0qCXOGC8UPigVd9oIHCweTNqklaWT7cmNOF1BnWvvWdqM9tSLqO7fVUIR0qANRgwTF1Z6XwPiy6jPlTW+yksXkdFo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=iQ5J5JTx; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=FHSv8y0R; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="iQ5J5JTx"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="FHSv8y0R" Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50FGtsq4009329; Wed, 15 Jan 2025 17:01:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=+i7IxiCS6DfQsq3jRcWMgZxD+RCqFMiCSj6KDvyLoPU=; b= iQ5J5JTxMYu8pK1gEIvikedm5aSyRS696ZnCy0ew3/93rWcYpD+4+6N6YHCuKdv0 h/pZcsfi24KuPUA7aWxF8iS0LFhtLhQRp20++OzUR9b5WqXBZacBpnBcc2V0/aF2 0cvT/H0vKoa+VB/YU6s/cm3g9OGUurslPvDLj134hxqjg/6Lh2bEXWCiq2XPmywq UmnjtJQa12WlT4sQ3pWUHgAfaStH+my8mBAbUiHDPL7pUg5JXo1BXgvePtvtJicp S+kS+nH3qgMrK6/gehZoUIxpEVOuPTvZmwDXHdsOZFWuzytIDU69AztAM8fhBBXV unMWPdLkPosuFiAqBtgNMg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 443h6t0e73-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Jan 2025 17:01:03 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50FFsAXW038748; Wed, 15 Jan 2025 17:01:03 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2046.outbound.protection.outlook.com [104.47.74.46]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 443f39pyu1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Jan 2025 17:01:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=My1o5Ci74a4xd5b4flxKz5pwjFd5b0pneNcgyLtidbnPy3/is3L61+gWOvPkt91Il5BLj9+6yo/LlApSu01tC4pnkirhCuv/60HJ9FtPh2epSMjw+oirzO/8esbR7YWYZn1ISQ6QAxabzEREN0V0Q53gmXRrPQECVuo2yebxMFyca/RpqKBYtuxfMU71FR7qGD9jo1mm6omULT13fLyxAlVLDPg8/eVRBAs+Wrv3i8jV1BsjkeYXtyzre4t/RF27LRGp14FfGQC3Ie3aej0cohIhK+T8+ffA1mQbXZDs/PaeK55d1YPq9HA2/ZO9REvSrnzpRrsUjoo59BcRF2GbTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+i7IxiCS6DfQsq3jRcWMgZxD+RCqFMiCSj6KDvyLoPU=; b=KZpMOTqzcQ8dgQcY+nlebM/xNtj29k5iBUdlmh7beveAQg1gXBAcBuAEpDRR+n7bAGSGrJMKij/sX3EPZm9jPb6Fi423Jp7SNL7MuO1xfRBp2tjIN8JpIDto0N6Q1gjJCAa6eMN0vFTTLIXIry5kxXtqw3EoACqiLTxe37dGde8NBEDLkALw4Hbsruvh8bWoy/2hjPDNUwqlJtEhQa+FMDfpu6qNVvUf49PrS6Wgh6bkJ17aMaXxy02c3F4Ely3U7qtuT1nzFKcDLioFiEfomyCvAvc4JtYRK2JKhsi+h+lvOVb5wXto2Vmm/0+1Jr+nthiFdAa59yq8hZ539sMiPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+i7IxiCS6DfQsq3jRcWMgZxD+RCqFMiCSj6KDvyLoPU=; b=FHSv8y0R2w2s/s8HR1ukYk38pFSp7Xa9NSMLjHyS2/d0zgu/HlQ05s4If6ed0OPqeShAx7CX1YqXB99tw+DFpus46/w+nDlSbnbEropIJZkA7kf42xyhMzhSTBj8xspJinVz0M52eto5aNZeCJrYEfqSbPBivyxLILEsdOI0dxE= Received: from CO1PR10MB4468.namprd10.prod.outlook.com (2603:10b6:303:6c::24) by SJ0PR10MB5549.namprd10.prod.outlook.com (2603:10b6:a03:3d8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.18; Wed, 15 Jan 2025 17:01:00 +0000 Received: from CO1PR10MB4468.namprd10.prod.outlook.com ([fe80::485e:729e:c0a4:e562]) by CO1PR10MB4468.namprd10.prod.outlook.com ([fe80::485e:729e:c0a4:e562%5]) with mapi id 15.20.8356.010; Wed, 15 Jan 2025 17:01:00 +0000 Message-ID: Date: Thu, 16 Jan 2025 04:00:55 +1100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] timers: introduce timer_try_add_on_cpu. To: Thomas Gleixner , anna-maria@linutronix.de, frederic@kernel.org Cc: linux-kernel@vger.kernel.org References: <20250115134111.2703089-1-imran.f.khan@oracle.com> <20250115134111.2703089-3-imran.f.khan@oracle.com> <87v7ugaws4.ffs@tglx> Content-Language: en-US From: imran.f.khan@oracle.com In-Reply-To: <87v7ugaws4.ffs@tglx> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR08CA0007.namprd08.prod.outlook.com (2603:10b6:a03:100::20) To CO1PR10MB4468.namprd10.prod.outlook.com (2603:10b6:303:6c::24) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR10MB4468:EE_|SJ0PR10MB5549:EE_ X-MS-Office365-Filtering-Correlation-Id: c5c3c437-4a0a-4fe0-bb81-08dd3586300d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Mmg5ZFJ3N0luWEFGaFcvZ0UrMXYwVGtqekgzdTg0dG83OWEzcnAzOG4wSERY?= =?utf-8?B?Q1JvTUQ2THRWV3FZMnFlemQzVFVVN2ZiSld0Um01SmdhWWJsNW9YYVNzQitt?= =?utf-8?B?NHQvdC93NC85em5iemVGaGdhMzF2Mm80QmtlOW1RZEdESklUT2FrMG5GdldZ?= =?utf-8?B?d1RzZEJLUy9XaXgyWXNCQWtuRGN3Qnd0MkN4bDZIVGd6YmxVTnk3R2RLK0M5?= =?utf-8?B?eVcydnBkeU9FSDEvVnRSVHFFTXZmTzlOck4weGJSaCtUZkpuTkNFNHNkeVBh?= =?utf-8?B?MjVwK0I1S1Uyb1BTYVpvbWQ5MG9CdW1oKzlkck5PQjh1amRQVTU0YmFiSnNO?= =?utf-8?B?dUtwUStXbHUzcXUzZTN3V2t1M3lRa05MRTFqU2dzOTh3ZHpvWCszQ255b3RX?= =?utf-8?B?VEdXRWJRRXQvT0RIYTBWeWcrOTdmZGJRUytDcWh2MUE1bStNK2VhN250KzJJ?= =?utf-8?B?eis3bDFDZ21nV3BYZ3pRd2ZnS3gzOXQ4UjFjRlZ0dEJwUmJRVVVUdW42b05F?= =?utf-8?B?QUZHckpSV3lFSHNpQlF6RmJIdFUzSUZSaExrUGcwNDF5NzZQb1dteHc2U3pH?= =?utf-8?B?NjNUdWdSbHMyYzBtQ1MvSkNlNWdzVkoraEZDUmQwcHYvL0RlM3RvWXZ6bFNp?= =?utf-8?B?cVlxNzRpNWYrb2x5U2p2OUhtcmdmcVBzYkg5cUNMdEJnOHhQVm0zZytpYVRQ?= =?utf-8?B?eE5SbDNXM1FWVmxVVFJzeDZ6UGltY01Td016aTgrVksrUVAxUk9SZXF5d0tD?= =?utf-8?B?OXNSOEE4dm5xeUtnRDlHL0hRV0dUQWhBSDkzZFdMR1NLTVI3R3RYeWFIbnJB?= =?utf-8?B?bFUwL1ExQWN0TEROYndQNlhPN00zbW1SMThJZ0EybTYzczc5ckNzaUlIUHVj?= =?utf-8?B?QUdxbE5IVzNCQXVEZDgyZHlRVVhNamIxYUJMdTc2L1h6TG83Q09ESlh6SFE0?= =?utf-8?B?M2p3OXdkQ2k0TXZnaE9aK24rN3Q1OWp6VWRPbFd2L1hRemtxeE5oWFhZbXQ5?= =?utf-8?B?TVRvV1NGUXBkVzRnbWZIM0NUb3hCS0p1OUt4UHRlK0h0b0hhbmhUWW1KMlJS?= =?utf-8?B?aWlZSG1HbHFONzR1eUNoTDNaQndtRHFldWFqZDRtTEkwcnVxMS9yN3Z2UWNX?= =?utf-8?B?ZFhmdWRtWXgyT0kzZGk4VE9rSlBvRW5pL0EvQUhHMFl5bnNpbmt0ZHM5U0FY?= =?utf-8?B?VTBTbVJnYjIxZDFoOGg5K1ozMVhJa2U0Q1ZidHVpU0VFS1J5Y2pxS1R1R3ZE?= =?utf-8?B?RkMraFVCYk0zQWtaWmZYMzY5bFhaQm1mM3JJWTFqYlJoeHJ3ckpWdysrSEV4?= =?utf-8?B?OEdaZWM0ZlNuU1pndWgrK3I1cXJmOVpNcXYvWUkxUXBZWlNoaGw3MlVSUXYr?= =?utf-8?B?aThVa3B3anBpd1orQ05iS2hDbE1lMWlMSGVGQU1aNnlvRnJZU3hNdjNxQXVy?= =?utf-8?B?ZWJPbXY5MkQ3RDR2cnlVRkE0WjFrRDRHTktQL1NJWVA1L1RMLytkSi9lU05T?= =?utf-8?B?V05VbzA0N0NUdG5tYUZIaGZIU3g0Z1JDSHpWSyticm1hSDg1NzV4OFNXTUhp?= =?utf-8?B?SVZsd2lKcmp6ZmFwQW1uMWNmZ1ZCOGdNRElxUzd3MXBRZXZCZWdHd0hrSUlq?= =?utf-8?B?M1BwMVRnZ1lDWGczS2dlWURGdFlRQld5S3JJTkEraUFMdGFUN2c0d01tZThm?= =?utf-8?B?THMxRFlvTXpSZFN5VnZyaFF1OHdaaFloRzJhazRPNDdvYitQM0ZIbjFIczFh?= =?utf-8?B?RWcxWmRZZStZcjVzR0U5cEsrYXY1ZCs5NDRKVm1BWDZUTzBLWkp4cVE4bG0z?= =?utf-8?B?Q3p2ZGM5U3NqeGVXQUczQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4468.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TklNT1hNSmxwSEtESk9pVGVWbDNHY2p4TmlqWGJrMTUveTBGNHN5SE1zbmMr?= =?utf-8?B?TDZ5M25FN0lZZVFxaFptN1JwTE9hUVZEOEpCaFhFYUpYOUxlNWlLc1JZMDFv?= =?utf-8?B?QXgwMjR1Vkswck5INjhvd1FrODVmWk9QeWoycnBnYnRYclEyNmdpci96TnlN?= =?utf-8?B?WGR2YVZVSXpmUnJEUzRYcVpUQ1FCRGptMmNxUFA3NFY1aUdJRkQzaXJ5Y0Ir?= =?utf-8?B?TjhLaTdkUVZobWlBQWViMWdwSC9EcjhsZzlpWUJiWjhLZjcwYW5lR0NyMXV6?= =?utf-8?B?YithT1dlY3dIcEgxRmtKYkk0Mis2emVMY0lnSE1nUEVvUzRYR1VTa0ZzQjFY?= =?utf-8?B?Ulg5cFcybGpQWG9NSk5zMHBPUmRXZkxYaVVrMWdmQnZpdEFNSUNHcE1WSVZw?= =?utf-8?B?RUJFbGtMRWRsMG11NVlIOVBzRUpuRlp5VDBEVGZDZzFuUDJ6U1hDU0xXN25C?= =?utf-8?B?RkhDY3Y4SXd1a2VvNTY4M1IySllPREJvMWx1RzNZSm90NE5ZbWpZcmtDNGVQ?= =?utf-8?B?RXo0bHJhVUtuWW1IcHkxOGhKV3pUeDRTOVdJMXVFV2VHWnM1UHVhOXJQS29C?= =?utf-8?B?czNzbkNSaEFwRDdTV2xTdFo2VUdmQ0ZQVExDcVZPMHRRT0pLMVlhRStMWXFt?= =?utf-8?B?ZUU5ZE1vUmxmTmVrMEJtbGZnSk5haWJLV1liVnVnSFdtcllHY2thaU8vSy9j?= =?utf-8?B?SG9wMnBZVjNIa29FRVdDMmlYWmlBbWgzR3lZUGYxZ253MzE3ZUVpUFA5QzQy?= =?utf-8?B?djJWT0wybkU1Z2ljc0lSV3ppZXdxYmhsb2ZoL25CaUlLeDJaVk1WRGlBdk1E?= =?utf-8?B?aFBmb09iMmw3ZWRwcGdUL0pDbjY1eEw1WTJ0aktHWFdIZ21wdkx1UHloem1x?= =?utf-8?B?Ymp4Skxqd09HKy9pamxScGtyWmM3Njh0NWdaUDdnSUJVYVJVSVp1bGx0b1BP?= =?utf-8?B?RERyaU9XWmNod1ZGME9tSWwvaXlUOUxrOUJmVHBJQlRscmtNREdtekZ3RVlQ?= =?utf-8?B?bk44aUhCTUx5MHFQUk03SWVjd2drUnBSSmhpdXVMOVlyek5USml4SGFkdXZz?= =?utf-8?B?WHFDT3BtZ1ppRyszaFlOK0c0cjRKSHBLTzgzQzZUVloyd2l0MTdGWVZMbU5r?= =?utf-8?B?Y0dmN2VGUnQvbVZ5NllsMVY4WlF2cENIcHRBVm1OVDZxMFVtNmthZGJKR2FJ?= =?utf-8?B?ZlF3eXZ2MTNwaEFUaWdBb2pmNlJ4aWROZUVkRjBHcVdEaTIvRWh2U2FKRUFV?= =?utf-8?B?bWMwVDEvNlBjeXpuY1FURlI0SnJkcWhYMzNGWWIwdzRGS3ovZEVhNmQwK1g2?= =?utf-8?B?SGJzMDI3L1JPVEZ5b1l0Uk14STVUUjgwRFh0cDBKbnNrSWFxNU1PYm1uaVpD?= =?utf-8?B?cTdONTQ3K3FNNnBoU0VjMjA1Y0ZCT21nQlBlSmZTbHo5R3A0R0I4VXNKY1pZ?= =?utf-8?B?cnIyZVl3bitZT0szVW9rWUhWaS9iOHBaZXY1RGJ1bmFOY0JOclZEYnhiVE8r?= =?utf-8?B?cmZuR21ja3psMUNXVk1vQ1A3ZFBHZTNWSFNrMDJSQ2h6YmFDaXlnRHQyeDEz?= =?utf-8?B?YWNmRUJlazdZdFB2VEoybTEvRitsMFVYUmNDcWJpRHlsT3RtVHYwekRzNEgr?= =?utf-8?B?V3BCaTNJaGI5c1dKbHkzY2J0YTJWa2JOSFNMRThmeVh3QkExRHpPNmVpbk5k?= =?utf-8?B?TFdjcklkU01FYVZJYzJGc1dLSWhUUmhkc0VBdVdkL29aS1Q0aVk2c1hkVXBk?= =?utf-8?B?amVGbEl2bEJpYnBlM0dqTXJwSk1JVDFTSHljYmlIdXFkMVRNNkExNW5Iakxx?= =?utf-8?B?SGJhZWZFVVRwVkZ1L0hnWFQrTElEZzVzYnNYK0dUbjJFUVlNTE1LVUVHaGtp?= =?utf-8?B?dWJnM0xnVFd6VkZpeHVBMlg5MmZCYmtBWGVFNmdGOGVhK3orbmFVSzF4Tkl2?= =?utf-8?B?WEhEaEFNVVVhSmQ5N1YwWW5uK21NY1o0UmFpdXdaY0UzQ1BjSFgzOElHTnM1?= =?utf-8?B?Z1hQZUlQNC9OZUpsbytlRUJiamZkQy83Q2JnR084blhUZDNCeFRiQjJrVGlH?= =?utf-8?B?VDhGTWxuV3hyMUhqeFZpK1hVSkVHVkVRRWhrbk9HRk5adHNraWVGd3M4S2FT?= =?utf-8?B?OUsyL1B4UWEwK25iaW5YLzIzZ0hLa0J0dUgwWkU3Z2h5ZkxKODZoTkpicWRT?= =?utf-8?B?cFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IuF6M1p5U6ukYmHedzrHfqq1Zor6NzNS7rASPf84K7LK6a5VbO9APiG8B9JZQUreI6q0NFUI3NbiAVYISvEW6/N/Yl+2q/TTsXhfau2huBBgqRPoIWMnHe7UIsM1qwwxpiLd/I8HYpNs12i8XsEGVGjuhKPsAVPqF5nihpBp3KTHcj93y0Xova/8kFH24YGWkPXY7iFVTw8VNWdTmtQv6hw4Osgd7GMSBrGoxK747FwuTXaPda86BfX0oBdVws1Fc0ZMRCCuXQnEgVabrVpNL7vJT+euNomMTU0qUo5r28upftzIj85COX80RlvXvQPUKjxV7/MCMqyjyI59Y96XqAFIkMklMv8EwVrdDbLGi7pZ2iLZdyzqsGdU3wAGPZGfpBC49PIf1MxIjiyIUX7nPl3c5c4QTs35EYnw4bgfe1UhIjmzo9dpkJ4wh7iaU/M4xZqXMkZYrqSzNabmrNVK3ala0fNjUiPmKA4RdswvhyVcIcLuFDEVXHgOT8Rt8YgYZbhto/7UisvjgtIWXsnDNIeDK/ohXqGLbEwna6gnTqLo/xoBBPNwOdmJd6aDUr8S0PIaIvXojkY0rzlsU7rZ0Ys8+79Kq8oIaiqhfYSnRAs= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5c3c437-4a0a-4fe0-bb81-08dd3586300d X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2025 17:01:00.5965 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: slvmGg0sBeVDLU7YbxI4tF1wlLrHXB900UpsAHQm+zyPf+orh9GBvwkSgq/fmv3nRRxjk5a5m3GtFlIQHkuzDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5549 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-15_08,2025-01-15_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501150125 X-Proofpoint-GUID: f_BwBdodYxtA2zA0LyPRpfSpONzpZGPj X-Proofpoint-ORIG-GUID: f_BwBdodYxtA2zA0LyPRpfSpONzpZGPj Hello Thomas, Thanks for taking a look and your feedback. On 16/1/2025 3:04 am, Thomas Gleixner wrote: > On Thu, Jan 16 2025 at 00:41, Imran Khan wrote: >> + * Return: >> + * * %true - If timer was started on an online cpu >> + * * %false - If the specified cpu was offline or if its online status >> + * could not be ensured due to unavailability of hotplug lock. >> + */ >> +bool timer_try_add_on_cpu(struct timer_list *timer, int cpu) >> +{ >> + bool ret = true; >> + >> + if (unlikely(!cpu_online(cpu))) >> + ret = false; >> + else if (cpus_read_trylock()) { >> + if (likely(cpu_online(cpu))) >> + add_timer_on(timer, cpu); >> + else >> + ret = false; >> + cpus_read_unlock(); >> + } else >> + ret = false; >> + >> + return ret; > > Aside of the horrible coding style, that cpus_read_trylock() part does > not make any sense. > > It's perfectly valid to queue a timer on a online CPU when the CPU > hotplug lock is held write, which can have tons of reasons even > unrelated to an actual CPU hotplug operation. > > Even during a hotplug operation adding a timer on a particular CPU is > valid, whether that's the CPU which is actually plugged or not is > irrelevant. > > So if we add such a function, then it needs to have very precisely > defined semantics, which have to be independent of the CPU hotplug lock. > The hotplug lock is being used to avoid the scenario where cpu_online tells that @cpu is online but @cpu gets offline before add_timer_on could actually add the timer to that @cpu's timer base. Are you saying that this can't happen or by "defined semantics" you mean that @cpu indicated as online by cpu_online should not get offline in the middle of this function. > The only way I can imagine is that the state is part of the per CPU > timer base, but then I have to ask the question what is actually tried > to solve here. > > As far as I understood that there is an issue in the RDS code, queueing > a delayed work on a offline CPU, but that should have triggered at least > the warning in __queue_delayed_work(), right? > I guess you are referring to warning of [1]. This was just added few days back but the timer of delayed_work can still end up on offlined cpu. > So the question is whether this try() interface is solving any of this > and not papering over the CPU hotplug related issues in the RDS code in > some way. > The RDS code that I referred to in my query, is an in-house change and there may be some scope of updating the cached-cpu information there with cpu hotplug callbacks. But we also wanted to see if something could be done on timer side to address the possibilty of timer ending up on an offlined cpu. That's why I asked earlier if you see any merit in having a try() interface. As of now I don't have any more cases, running into this problem (putting timer-wheel timers on offlined cpu). May be with warning in __queue_delayed_work and (if gets added) in add_timer_on we may see more such cases. But if you agree, try() interface could still be added albeit without hotplug lock. Thanks, Imran [1]: https://github.com/torvalds/linux/blob/master/kernel/workqueue.c#L2511 > Thanks, > > tglx > >