From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82EA43EBF3E for ; Thu, 19 Feb 2026 00:18:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771460318; cv=none; b=QCmPWfyEwud9O/HbaloiUgZ8bV3EHjkoUYRwHNyDUN6U7cO9iMHvemKSrY4ZvV7AwOJQ6WvsMBqyOqsvNz9cazv3hFapWcmZEkqD4Z3l3ph9AAhCyrjtbd0ZTEHM7MRZLAxsJQU6lb9/BPFm8Suy7WFYtoq929SfMD7UseTsGDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771460318; c=relaxed/simple; bh=yX58FE41c/ilP+wBoKhqYAK/S3q8rJQbjLJSPC8DJQ4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pD+vwaXmOvHared2CMMo62kz34ysdztXS67Tt20Iz5NH2zaG7NAqceNV2VzFnT68m+CGvdc8cWV582kze5hMfu1rBNUb/kUGtNWPuAvNWoxmNV/ND0EV2orrbHG/jG9WdeW/Ans5eijFRoBRu5xYehXEWEjUy0vptY8vqCxMCuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FvXG60bx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EoVv67TD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FvXG60bx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EoVv67TD" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61IIAKSr3380115 for ; Thu, 19 Feb 2026 00:18:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VXIKfQNG9TrKEgU99HqIDj1sC/EgfQBOZENx2xktZTU=; b=FvXG60bxmkD/dPLI vGJrGFpo8R4nuvHrvE8g15jwPilGDG3QnWKy4sbJ+w22k3nKhZg/B4qNK7HP0epa i28tuXGgnyN4fr1zrRB+NyFFtLeRLXULXCfbDhFhutPDRvlnWUlKuQmER6TZnNMO YKLyKLzXWCJh68z04TBddVXDz1eAX7bwq8GCw/GLINTGTnDF4ORK1tVYZe6K9yXc mm24VjqA3Wcc9zv3RAb3IGXpybAqIWAw2ZI8WCSfriL+h5cbVrfQvVbht3yqowHG whkYx265eMmy72HvXnhn9BN3n4SpNIjVWP0KOOc4BK3JW6dhIZTHvqb5QGn0Ptfh TTX0Kw== Received: from mail-dl1-f72.google.com (mail-dl1-f72.google.com [74.125.82.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ccxnym6cq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Feb 2026 00:18:36 +0000 (GMT) Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-1275c2ae713so12090010c88.0 for ; Wed, 18 Feb 2026 16:18:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771460316; x=1772065116; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VXIKfQNG9TrKEgU99HqIDj1sC/EgfQBOZENx2xktZTU=; b=EoVv67TDmEs3jh+boQ/WV9/BwoU4oOmmg2zI6HXk3sSEXGmQz22CxxEOzp1h+bWq+o 7Ez1Zbl0CrRdemyOerGTpQdBULdGja2jcADwsVF7cOil5BuS0tFfZalY7tKzh9z82gju pKTNtpaKx6wtdUgP8crag5r9he39zND2lM4hOBxjlXH8kVxWr01aWCjI6HIKGjIDSHih xmZKJzXeLhJEoWfJzTHc3IvU5kGTcef2mNL+1VZ/mhKqnFXRz5YRdZYQfdywGyHmTeYO Bg58zCrQhT7ByAa81FtopFj20CesjDj5ZrX/C3bdvtrMlhXLk1Cq2K8G87pEE/RxPc3q Uw8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771460316; x=1772065116; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VXIKfQNG9TrKEgU99HqIDj1sC/EgfQBOZENx2xktZTU=; b=ZZzqOQFWw1EPyO+lZTOXCatJjgUKB8/aNDmTeUUPyV9+yXmdHCO3RgJlqdUjGb2eJQ g80CeXtdhTY1h2i35HlbX0ZSqQYznCTG3ODS9Ad2lfB1cLy27+ztWtv+dWUi6dHZ13Ci pNSf+QX1zPuSlu8xP97f0ar6diPckHiBXRmbBwJCj8iKwCxV+yTaBZWO4AGHeZp937AJ YkKd74vJLosDwd9gZjOqzKUA+PSSCEAz3NGU384QIXoL+T9O0p/5Ir3Q6E7nfFOwrrOg 9nxdyVX9hd8LFFQcTi0cbza6vPANqYOLSuz5S8B2RdPyTAdK8b+YrNqMA+GgJHUxAjxp YwNw== X-Forwarded-Encrypted: i=1; AJvYcCVa/+UDvlT23mqsCfG39iSbazFbCr4Rr9Qdu2IV8mpXd8zyeAI1Aw4LAvS0Bq4NGmRNj3y/GAQZvnL0oRk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9b9WwgLN6zJYJVL3xsmyxTC8DqNE8l+MyDz6U8ILD/SqzCLmN xjyodlEO9pYFmOPk9Nd+l01agoG7veSICmjDCPNUEkxrfP30oHwy0wtgL9OhIyWdx8Q+4RkpVzt PlGNzBfRw5b4u0+YDTiTsH6z/VaBmb3G1pGqUSX1jiildVns3kQ/FOrUpneJ7Fx3WC4I= X-Gm-Gg: AZuq6aIlHLYEKhlSnNpL7tJo8OiTZ8mZldBPtwxRdqKhyKpDojmz++y0E2iT6XaOueT ODp3MOdy8Ur5qfgb+W4y8MiObth+SMqGFKxRhaTJZXeAwz7tqUJiYUvmt7DAqlLa4e6+kClwtpM 0cUrU3m5N4A+gxTAMGeBWf+SRor7FTqNVkYLtgwnBfIPRaoscZTK34cwLAFR+o+lBZdiMgFVWcg uChp5+0X7V4B2/TUZscsUHvc1wIMxEmKmh8l2pN3EMZG8PiuwseX/z1i5TxzOXq5rSWI6YshwYs /KKRn6tFyQb8CPkScmYoKUtDGCA7sMJzxI89BQ3xih+KX7vgaYLsM7GLrc2MszSjzLAHDewcCg1 O3LBwufGOpjtxsSyq9uqgteDumce+QE141a3LjrCdejXtRXftHdoROwdBj8H8wJWDM46uQqaCf3 S/fAXxHpUhN2qvVA== X-Received: by 2002:a05:7022:4a3:b0:121:9f05:7e4c with SMTP id a92af1059eb24-1273addcd33mr9051074c88.16.1771460315843; Wed, 18 Feb 2026 16:18:35 -0800 (PST) X-Received: by 2002:a05:7022:4a3:b0:121:9f05:7e4c with SMTP id a92af1059eb24-1273addcd33mr9051060c88.16.1771460315217; Wed, 18 Feb 2026 16:18:35 -0800 (PST) Received: from [192.168.1.41] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742cadb25sm25643780c88.10.2026.02.18.16.18.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Feb 2026 16:18:34 -0800 (PST) Message-ID: Date: Wed, 18 Feb 2026 16:18:33 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2][next] wifi: ath6kl: wmi: Avoid -Wflex-array-member-not-at-end warning To: "Gustavo A. R. Silva" , Kalle Valo Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: From: Jeff Johnson Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: hPeRFW1xb5V0Xr5Ur1sS1BzTJq6F-grd X-Authority-Analysis: v=2.4 cv=Do5bOW/+ c=1 sm=1 tr=0 ts=699656dc cx=c_pps a=bS7HVuBVfinNPG3f6cIo3Q==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=za3tAlzF_62g-CIsXx4A:9 a=QEXdDO2ut3YA:10 a=vBUdepa8ALXHeOFLBtFW:22 X-Proofpoint-GUID: hPeRFW1xb5V0Xr5Ur1sS1BzTJq6F-grd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE5MDAwMSBTYWx0ZWRfX8EVP3zcnrInQ Vg4fL91TRFNKKPtKdHuyMy4TGyuYHveM8PR3KnxvC74bgL2Wj9zXiemPM+8tJcNH2IPEMy4Rdbz HUSTBIv9ZicxbMw3MhbSOxkh6Z2MHTNMAZtB/IZzHNj+PUZTLKuYy2IL+MG19xwb3kNTHcrCf1p 5h93m7WnFk/dxYq5+toKfZVZJCazIYQrVNRqi2hlnPntBO+ulQK4OUBhm5Hm7lWaUjMlxdkAWPW 9i+bqljQYMzuXBHsPueUuqDXny8Bd8IhN9Ul/FK7KgJMnzaYlDLJJimuXKqre3gW+M39r1KxJDI rSpeVeqX5sOplLzF0AATJCCjJzo8GwZEI3+8fXv2AapFMUYhNqZoUJ9F2YHocjHsVpUpgkF0Z8/ Fl8j1aJ2yHEj6Pwy04oLI6z6c34/P7Hu9nBQln1C1hfqLKXY5xaVy9KTIWrIFBrhjWL/LaR8Cra feZdi8NlTM/tSw2nEXg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-18_05,2026-02-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 phishscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 adultscore=0 malwarescore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602190001 On 2/16/2026 9:10 PM, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > struct bss_bias_info is a flexible structure, this is a structure > that contains a flexible-array member (struct bss_bias bss_bias[]). > > Since struct roam_ctrl_cmd is defined by hardware, we create the new > struct bss_bias_info_hdr type, and use it to replace the object type > causing trouble in struct roam_ctrl_cmd, namely struct bss_bias_info. > > Also, once -fms-extensions is enabled, we can use transparent struct > members in struct bss_bias_info. > > Notice that the newly created type does not contain the flex-array > member `bss_bias`, which is the object causing the -Wfamnae warning. > > After these changes, the size of struct roam_ctrl_cmd, along > with its member's offsets remain the same, hence the memory layout > doesn't change: > > Before changes: > struct roam_ctrl_cmd { > union { > u8 bssid[6]; /* 0 6 */ > u8 roam_mode; /* 0 1 */ > struct bss_bias_info bss; /* 0 1 */ > struct low_rssi_scan_params params; /* 0 8 */ > } info; /* 0 8 */ > u8 roam_ctrl; /* 8 1 */ > > /* size: 9, cachelines: 1, members: 2 */ > /* last cacheline: 9 bytes */ > } __attribute__((__packed__)); > > After changes: > struct roam_ctrl_cmd { > union { > u8 bssid[6]; /* 0 6 */ > u8 roam_mode; /* 0 1 */ > struct bss_bias_info_hdr bss; /* 0 1 */ > struct low_rssi_scan_params params; /* 0 8 */ > } info; /* 0 8 */ > u8 roam_ctrl; /* 8 1 */ > > /* size: 9, cachelines: 1, members: 2 */ > /* last cacheline: 9 bytes */ > } __attribute__((__packed__)); > > With these changes fix the following warning: > > drivers/net/wireless/ath/ath6kl/wmi.h:1658:20: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] > > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > - Create new separate struct bss_bias_info_hdr, and use > transparent struct members (in struct bss_bias_info) > instead of rearranging members in struct roam_ctrl_cmd. > - Update subject line - Add 'wifi:' prefix. > > v1: > - Link: https://lore.kernel.org/linux-hardening/aR153k4ExCD-QTMq@kspp/ > > drivers/net/wireless/ath/ath6kl/wmi.h | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath6kl/wmi.h b/drivers/net/wireless/ath/ath6kl/wmi.h > index 3080d82e25cc..d2a5c96fc878 100644 > --- a/drivers/net/wireless/ath/ath6kl/wmi.h > +++ b/drivers/net/wireless/ath/ath6kl/wmi.h > @@ -1635,8 +1635,12 @@ struct bss_bias { > s8 bias; > } __packed; > > -struct bss_bias_info { > +struct bss_bias_info_hdr { > u8 num_bss; > +} __packed; > + > +struct bss_bias_info { > + struct bss_bias_info_hdr; > struct bss_bias bss_bias[]; > } __packed; > > @@ -1652,7 +1656,7 @@ struct roam_ctrl_cmd { > union { > u8 bssid[ETH_ALEN]; /* WMI_FORCE_ROAM */ > u8 roam_mode; /* WMI_SET_ROAM_MODE */ > - struct bss_bias_info bss; /* WMI_SET_HOST_BIAS */ > + struct bss_bias_info_hdr bss; /* WMI_SET_HOST_BIAS */ > struct low_rssi_scan_params params; /* WMI_SET_LRSSI_SCAN_PARAMS > */ > } __packed info; That bss member appears to be completely unused (bssid, roam_mode, and params are used) So IMO the better solution is to remove bss from the union. And I think struct bss_bias and struct bss_bias_info can also be removed. /jeff