From: "Herrenschmidt, Benjamin" <benh@amazon.com>
To: "tglx@linutronix.de" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Singh, Balbir" <sblbir@amazon.com>
Cc: "keescook@chromium.org" <keescook@chromium.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [RFC PATCH] arch/x86: Optionally flush L1D on context switch
Date: Sun, 22 Mar 2020 05:10:43 +0000 [thread overview]
Message-ID: <d2a091cde8f26ab9c994c1ebc8059873d3524e11.camel@amazon.com> (raw)
In-Reply-To: <87d096rpjn.fsf@nanos.tec.linutronix.de>
On Sat, 2020-03-21 at 11:05 +0100, Thomas Gleixner wrote:
> victim1
> store secrit
> victim2
> attacker read secrit
>
> Now if L1D is flushed on CPU0 before attacker reaches user space,
> i.e. reaches the attack code, then there is nothing to see. From the
> link:
>
> Similar to the L1TF VMM mitigations, snoop-assisted L1D sampling can be
> mitigated by flushing the L1D cache between when secrets are accessed
> and when possibly malicious software runs on the same core.
>
> So the important point is to flush _before_ the attack code runs which
> involves going back to user space or guest mode.
So you mean switching from victim to attacker in the kernel, and going
back to victim before the attacker has a chance to actually execute any
userspace code ?
I can see why this doesn't require a flush, but is it a case worth
optimizing for either ?
IE. The flush in switch_mm is rather trivial, is lower overhead than
adding code to the userspace return code, and avoids kernel threads
likely, I prefer it for its simplicity TBH...
Cheers,
Ben.
next prev parent reply other threads:[~2020-03-22 5:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 22:04 Balbir Singh
2020-03-18 23:14 ` Kees Cook
2020-03-20 1:35 ` Singh, Balbir
2020-03-19 0:38 ` Thomas Gleixner
2020-03-20 1:37 ` Singh, Balbir
2020-03-20 11:49 ` Thomas Gleixner
2020-03-21 1:42 ` Singh, Balbir
2020-03-21 10:05 ` Thomas Gleixner
2020-03-22 5:10 ` Herrenschmidt, Benjamin [this message]
2020-03-23 0:37 ` Singh, Balbir
2020-03-22 5:08 ` Herrenschmidt, Benjamin
2020-03-22 15:10 ` Andy Lutomirski
2020-03-22 23:17 ` Herrenschmidt, Benjamin
2020-03-23 0:12 ` Singh, Balbir
2020-03-22 5:01 ` Herrenschmidt, Benjamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2a091cde8f26ab9c994c1ebc8059873d3524e11.camel@amazon.com \
--to=benh@amazon.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sblbir@amazon.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®