From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEF84223C49 for ; Thu, 19 Dec 2024 15:28:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734622138; cv=none; b=DFY39zw/ycyHa4l4mi7STNO5GeFKhq+N9lk9v9Y301V/GU60ws0niZW/+eSN/byuxtCvGe57Z2faF66JIewaQwbH3Anr1bdgHG0QCl/+B+sfWOYnx8QPUnNzS4TeqMp7XvSvIoRZ1qS66AwMCmuTIyH5Euz0SKj37fmwKJExxVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734622138; c=relaxed/simple; bh=hcNTFyqKUMwCVdpKIunAnnA4wJG20Ea02Nyh//Qeuhg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ug3Fm86NZ8im+jzCLl01+CmHSlcKgfaoBMNSmm8Om1psFlT4XJzEPvCkqi7ZR6iYqSo+kg4Ng929BsiIS50tjHKnDL/IaOPCcBjrnr11hYFWGMKLVc+kcJWT5uk0RKZDu1zK2ksI+tvLuMS4QLKvRNknGtSj5WwOMpBcnJDrI08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NRuQbTqy; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NRuQbTqy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734622135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SbGerx+1B2MPYn30VAqdVqqBm24gLGl8v6xJ0+hVNZc=; b=NRuQbTqywLp7lpNMKTD5tfTs5/kgAXlJaspbcRfE4BGYoL1Hacr8onQkCijd+jOXHQiDMV 6S0RcFOZFBwMFDvs2wUvjjg+hM0r3NdxSq4t1LmoNgrzE5PZ6MNReKmWViPRV+GJG2zaum GqSbp/fpm3Xkr1j7rGZFHjVzUbcDaiQ= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-27-yRES29O5Of2vNtAPZrluxQ-1; Thu, 19 Dec 2024 10:28:54 -0500 X-MC-Unique: yRES29O5Of2vNtAPZrluxQ-1 X-Mimecast-MFC-AGG-ID: yRES29O5Of2vNtAPZrluxQ Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-aa66ab24344so85620766b.3 for ; Thu, 19 Dec 2024 07:28:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734622133; x=1735226933; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SbGerx+1B2MPYn30VAqdVqqBm24gLGl8v6xJ0+hVNZc=; b=oRqw/FgqTtqBgowl4CZ0zD4bPNAKb+Tfjub6+0G/gfVga2g86Wl65PChC8wYb5TMcC 0fmt8CO03y3cnEii8wEDPNBkbfran2MhK+xTrTO8tt3zFs+6VuG3pE2+0LuPRRlaP7hp ghgFXzGrd3mCvWF8mjVvQBiv6x78xfqyUTuWbQK7We1/8N4Q2FS6a5Bx2zTrH2use0NS zn4YOxcAyEMu6BvePQ7iWA8LWc33cEid4FVUEumXanZ+oZxIza893LCbYWs9B7DPXYYc zxDgjX6C3G/K5FKShu8zQ6MyqTs0xFfNaTyj1L0ekLpQTZrYXyzL/usHU9Ck+REcYyXx 1gXg== X-Forwarded-Encrypted: i=1; AJvYcCVr9jkBc/JOSpbSWAYN7QMZk8aou0CV3YsNodPiD4BR8VXofIeWh0PZp75bJKmM6u/3WoyzfHq6zrUm98E=@vger.kernel.org X-Gm-Message-State: AOJu0YxjE7xBr5h3dQaTa5Z0hUC8afE1+yLPnjHO7cZynHfkanM++USz dxEtROpEW0B95jT/IsH9HTKRL4kvl4Jm0e3MLYixZOm7zrS06AKnT5rC8j3cakuM2lboJgjm4kS x7fMj8QsfgSABWJ6p/l9XCGvnSuOlb35ulmkHX7wRLHWB09mYmlYB9ZJv8GZqn/9Dh56XQGfD X-Gm-Gg: ASbGncvSGyIju0HpHFakckxU4XUMlUIILsgwb89kqzclViRSoPsMzHoMfmn4hc3qQqw PkTtDCEemUwcwj17zT5Bf9/TXTI6G1jAFHQkIAgiYXacqTyTysrCTOKSOjrp5WAW0GkrEA2FYR9 TOpqYhMBbAhtMCctpJcyQoL8moSayhFsKeyKTA+cOZScu6kaYurKLRh3Azlv7yBhJdhrszt4DCE ic9b57kI/qTHG2JAm1Ziz7bHydnOiNPB8YNiPtdD3tfXM2ADUBVMgIC/xB1f6jsfCerX8OuiMSS kxT17Oju5wEUTJjVBeXttTNPeBUpV4MuGuhTGtP9sxif6q14Y/p1KObuZHpE8nikTdBsyZz0Qm0 w2RWbkXZwJpgpeCYBGK6IqGRuVIt0yA8= X-Received: by 2002:a17:907:3e1a:b0:aa6:a87e:f2e1 with SMTP id a640c23a62f3a-aac07b0376amr291358666b.56.1734622132671; Thu, 19 Dec 2024 07:28:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8VMwMtkbtAbXw7OMyDkv07qrlWHVjiVumV9c+kDfvHsYUlcZcWuud0FzWXP9xkb6+O/Q77g== X-Received: by 2002:a17:907:3e1a:b0:aa6:a87e:f2e1 with SMTP id a640c23a62f3a-aac07b0376amr291356166b.56.1734622132254; Thu, 19 Dec 2024 07:28:52 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0f070a7bsm76122666b.201.2024.12.19.07.28.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 07:28:51 -0800 (PST) Message-ID: Date: Thu, 19 Dec 2024 16:28:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Input: atkbd: Fix so copilot key generates F23 keycode To: Mark Pearson Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241219151910.14235-1-mpearson-lenovo@squebb.ca> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20241219151910.14235-1-mpearson-lenovo@squebb.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit +Cc Peter Hutterer Hi Mark, Thank you for your patch. On 19-Dec-24 4:18 PM, Mark Pearson wrote: > The copilot key on Lenovo laptops doesn't work as scancode 0x6e, which it > generates is not mapped. > This change lets scancode 0x6e generate keycode 193 (F23 key) which is > the expected value for copilot. > > Tested on T14s G6 AMD. > I've had reports from other users that their ThinkBooks are using the same > scancode. Hmm, I'm not sure mapping this to KEY_F23 is the right thing to do, there are 2 issues with this approach: 1. /usr/share/X11/xkb/symbols/inet currently maps this to XF86TouchpadOff as F20 - F23 where repurposed to TouchPad on/off/toggle / micmute to work around X11 not allowing key-codes > 247. We are actually working on removing this X11 workaround to make F20-F23 available as normal key-codes again for keyboards which actually have such keys. 2. There are some keyboards which have an actual F23 key and mapping the co-pilot key to that and then having desktop environments grow default keybindings on top of that will basically mean clobbering the F23 key or at least making it harder to use. I think was is necessary instead is to add a new KEY_COPILOT to include/uapi/linux/input-event-codes.h and use that instead. Peter, I thought I read somewhere that you were looking into mapping the copilot key to a new KEY_COPILOT evdev key for some other keyboards? Regards, Hans > > Signed-off-by: Mark Pearson > --- > drivers/input/keyboard/atkbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c > index 5855d4fc6e6a..f7b08b359c9c 100644 > --- a/drivers/input/keyboard/atkbd.c > +++ b/drivers/input/keyboard/atkbd.c > @@ -89,7 +89,7 @@ static const unsigned short atkbd_set2_keycode[ATKBD_KEYMAP_SIZE] = { > 0, 46, 45, 32, 18, 5, 4, 95, 0, 57, 47, 33, 20, 19, 6,183, > 0, 49, 48, 35, 34, 21, 7,184, 0, 0, 50, 36, 22, 8, 9,185, > 0, 51, 37, 23, 24, 11, 10, 0, 0, 52, 53, 38, 39, 25, 12, 0, > - 0, 89, 40, 0, 26, 13, 0, 0, 58, 54, 28, 27, 0, 43, 0, 85, > + 0, 89, 40, 0, 26, 13, 0,193, 58, 54, 28, 27, 0, 43, 0, 85, > 0, 86, 91, 90, 92, 0, 14, 94, 0, 79,124, 75, 71,121, 0, 0, > 82, 83, 80, 76, 77, 72, 1, 69, 87, 78, 81, 74, 55, 73, 70, 99, >