From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Inochi Amaoto <inochiama@outlook.com>,
Chao Wei <chao.wei@sophgo.com>,
Chen Wang <unicorn_wang@outlook.com>,
Conor Dooley <conor@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Cc: Jisheng Zhang <jszhang@kernel.org>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/8] riscv: dts: sophgo: Rename cv1800b device tree file
Date: Wed, 18 Oct 2023 14:55:09 +0200 [thread overview]
Message-ID: <d2b099c7-fd62-46af-b592-525b69aa8726@linaro.org> (raw)
In-Reply-To: <IA1PR20MB49530B8580E22AE664B8D59FBBD5A@IA1PR20MB4953.namprd20.prod.outlook.com>
On 18/10/2023 14:37, Inochi Amaoto wrote:
>> On 18/10/2023 13:31, Inochi Amaoto wrote:
>>> As CV180x and CV181x have the identical layouts, it is OK to use the
>>> cv1800b basic device tree for the whole series.
>>>
>>> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
>>> ---
>>> arch/riscv/boot/dts/sophgo/{cv1800b.dtsi => cv18xx.dtsi} | 0
>>> 1 file changed, 0 insertions(+), 0 deletions(-)
>>> rename arch/riscv/boot/dts/sophgo/{cv1800b.dtsi => cv18xx.dtsi} (100%)
>>>
>>
>> If nothing breaks by this commit, means the file is not used, so how did
>> it end up in the kernel?
>>
>
> This commit breaks the including file cv1800b-milkv-duo.dts, which is
> fixed in the next patch. For cv1800b, it only needs to set compatible
> strings. The cv1800b and cv1812h have identical layout.
You must preserve bisectability.
>
> I use this commit to avoid wired output provided by git and make the
> change more clear.
Don't do this. Previous patch was ok and readable. I don't understand
how this split helps (except breaking bisectability).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-18 12:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 11:30 [PATCH v3 0/8] Add Huashan Pi board support Inochi Amaoto
2023-10-18 11:31 ` [PATCH v3 1/8] dt-bindings: interrupt-controller: Add SOPHGO CV1812H plic Inochi Amaoto
2023-10-18 11:31 ` [PATCH v3 2/8] dt-bindings: timer: Add SOPHGO CV1812H clint Inochi Amaoto
2023-10-18 11:31 ` [PATCH v3 3/8] dt-bindings: riscv: Add SOPHGO Huashan Pi board compatibles Inochi Amaoto
2023-10-18 11:31 ` [PATCH v3 4/8] riscv: dts: sophgo: Rename cv1800b device tree file Inochi Amaoto
2023-10-18 12:11 ` Krzysztof Kozlowski
2023-10-18 12:37 ` Inochi Amaoto
2023-10-18 12:55 ` Krzysztof Kozlowski [this message]
2023-10-18 11:31 ` [PATCH v3 5/8] riscv: dts: sophgo: Separate compatible specific for cv1800b soc Inochi Amaoto
2023-10-18 11:31 ` [PATCH v3 6/8] riscv: dts: sophgo: cv18xx: Add gpio devices Inochi Amaoto
2023-10-18 11:31 ` [PATCH v3 7/8] riscv: dts: sophgo: add initial CV1812H SoC device tree Inochi Amaoto
2023-10-18 11:31 ` [PATCH v3 8/8] riscv: dts: sophgo: add Huashan Pi board " Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2b099c7-fd62-46af-b592-525b69aa8726@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®