From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032257AbeBNQOm (ORCPT ); Wed, 14 Feb 2018 11:14:42 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:50282 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031982AbeBNQOi (ORCPT ); Wed, 14 Feb 2018 11:14:38 -0500 X-Google-Smtp-Source: AH8x225IUHyEOn/joOknlsjoWA91nvbP/HusI0/pNdDE4mQVzT6nlQtYpduzyZCe3kJkSoPIwdAxnA== Subject: Re: [PATCH v2] PCI: qcom: add missing supplies required for msm8996 To: Stanimir Varbanov , stanimir.varbanov@linaro.org, linux-pci@vger.kernel.org, bhelgaas@google.com Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org References: <20180214120616.23428-1-srinivas.kandagatla@linaro.org> <79820f4c-5166-852f-1bc5-8cef2ff81a00@mm-sol.com> From: Srinivas Kandagatla Message-ID: Date: Wed, 14 Feb 2018 16:14:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <79820f4c-5166-852f-1bc5-8cef2ff81a00@mm-sol.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/02/18 16:00, Stanimir Varbanov wrote: >> .../devicetree/bindings/pci/qcom,pcie.txt | 4 ++++ >> drivers/pci/dwc/pcie-qcom.c | 24 ++++++++++++++++++++-- >> 2 files changed, 26 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt b/Documentation/devicetree/bindings/pci/qcom,pcie.txt >> index 3c9d321b3d3b..1fd703bd73e0 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt >> @@ -189,6 +189,10 @@ >> Value type: >> Definition: A phandle to the analog power supply for IC which generates >> reference clock >> +- vddpe-3v3-supply: > shouldn't it be vddpe_3v3-supply to be aligned with the other supplies? > I noticed that, I had to do it intentionally As dt properties should follow - instead of _ >> + Usage: optional >> + Value type: >> + Definition: A phandle to the PCIe endpoint power supply >> >> - phys: >> Usage: required for apq8084 >> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c >> index 3e89909f8cb9..519a2ae416eb 100644 >> --- a/drivers/pci/dwc/pcie-qcom.c >> +++ b/drivers/pci/dwc/pcie-qcom.c >> @@ -101,13 +101,14 @@ struct qcom_pcie_resources_1_0_0 { >> struct reset_control *core; >> struct regulator *vdda; >> }; >> - > please keep above blank line. Will fix it. > >> +#define QCOM_PCIE_2_3_2_MAX_SUPPLY 2 >> struct qcom_pcie_resources_2_3_2 { >> struct clk *aux_clk; >> struct clk *master_clk; >> struct clk *slave_clk; >> struct clk *cfg_clk;