From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/12] PCI: qcom: account for const type of of_device_id.data
Date: Wed, 3 Jan 2018 14:38:26 +0200 [thread overview]
Message-ID: <d2b54ccb-436a-69a8-b966-d65172d01c0f@mm-sol.com> (raw)
In-Reply-To: <20180103122237.GD26554@red-moon>
Hi Lorenzo,
On 01/03/2018 02:22 PM, Lorenzo Pieralisi wrote:
> On Tue, Jan 02, 2018 at 02:28:00PM +0100, Julia Lawall wrote:
>> This driver creates various const structures that it stores in the
>> data field of an of_device_id array.
>>
>> Adding const to the declaration of the location that receives the
>> const value from the data field ensures that the compiler will
>> continue to check that the value is not modified. Furthermore, the
>> const-discarding cast on the extraction from the data field is no
>> longer needed.
>>
>> Done using Coccinelle.
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>>
>> ---
>> drivers/pci/dwc/pcie-qcom.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Hi Julia,
Probably that is addressed to me :)
>
> I am happy to take this patch through the PCI tree unless you see a
> problem with that, please let me know.
The patch looks fine.
Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>
--
regards,
Stan
next prev parent reply other threads:[~2018-01-03 12:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 13:27 [PATCH 00/12] " Julia Lawall
2018-01-02 13:27 ` [PATCH 01/12] PM / AVS: rockchip-io: " Julia Lawall
2018-01-02 13:27 ` [PATCH 02/12] pinctrl: at91-pio4: " Julia Lawall
2018-01-03 7:58 ` Linus Walleij
2018-01-02 13:27 ` [PATCH 03/12] spi: sirf: " Julia Lawall
2018-01-03 12:15 ` Applied "spi: sirf: account for const type of of_device_id.data" to the spi tree Mark Brown
2018-01-03 12:22 ` Mark Brown
2018-01-02 13:28 ` [PATCH 04/12] PCI: qcom: account for const type of of_device_id.data Julia Lawall
2018-01-03 12:22 ` Lorenzo Pieralisi
2018-01-03 12:38 ` Stanimir Varbanov [this message]
2018-01-03 12:38 ` Julia Lawall
2018-01-03 18:23 ` Lorenzo Pieralisi
2018-01-02 13:28 ` [PATCH 05/12] pinctrl: armada-37xx: " Julia Lawall
2018-01-02 15:36 ` Gregory CLEMENT
2018-01-03 8:03 ` Linus Walleij
2018-01-02 13:28 ` [PATCH 06/12] power: supply: " Julia Lawall
2018-01-09 16:22 ` Sebastian Reichel
2018-01-02 13:28 ` [PATCH 07/12] i2c: rk3x: " Julia Lawall
2018-01-15 18:24 ` Wolfram Sang
2018-01-17 11:00 ` Heiko Stuebner
2018-01-17 23:12 ` Wolfram Sang
2018-01-02 13:28 ` [PATCH 08/12] pinctrl: axp209: " Julia Lawall
2018-01-03 7:59 ` Linus Walleij
2018-01-02 13:28 ` [PATCH 09/12] mtd: fsl-quadspi: " Julia Lawall
2018-01-07 18:08 ` Cyrille Pitchen
2018-01-02 13:28 ` [PATCH 10/12] spi: spi-fsl-dspi: " Julia Lawall
2018-01-03 12:22 ` Applied "spi: spi-fsl-dspi: account for const type of of_device_id.data" to the spi tree Mark Brown
2018-01-02 13:28 ` [PATCH 11/12] iio: common: ssp_sensors: account for const type of of_device_id.data Julia Lawall
2018-01-06 12:23 ` Jonathan Cameron
2018-01-02 13:28 ` [PATCH 12/12] power: reset: " Julia Lawall
2018-01-05 13:24 ` Alexandre Belloni
2018-01-09 16:22 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2b54ccb-436a-69a8-b966-d65172d01c0f@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=Julia.Lawall@lip6.fr \
--cc=bhelgaas@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®