From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF4ECC433E0 for ; Fri, 26 Feb 2021 16:19:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB3A664EBA for ; Fri, 26 Feb 2021 16:19:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230022AbhBZQTN (ORCPT ); Fri, 26 Feb 2021 11:19:13 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2609 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229727AbhBZQTJ (ORCPT ); Fri, 26 Feb 2021 11:19:09 -0500 Received: from fraeml715-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DnF764xS7z67sCn; Sat, 27 Feb 2021 00:12:50 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml715-chm.china.huawei.com (10.206.15.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 26 Feb 2021 17:18:22 +0100 Received: from [10.47.0.216] (10.47.0.216) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 26 Feb 2021 16:18:21 +0000 Subject: Re: [PATCH] perf vendor events: Remove 'type' field from mapfiles To: Andi Kleen CC: , , , , , , , , , , , References: <1614344897-229717-1-git-send-email-john.garry@huawei.com> <20210226154737.GY472138@tassilo.jf.intel.com> From: John Garry Message-ID: Date: Fri, 26 Feb 2021 16:16:30 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20210226154737.GY472138@tassilo.jf.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.0.216] X-ClientProxiedBy: lhreml748-chm.china.huawei.com (10.201.108.198) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/02/2021 15:47, Andi Kleen wrote: > On Fri, Feb 26, 2021 at 09:08:17PM +0800, John Garry wrote: >> Included for each CPU entry in the per-arch mapfile.csv file is a 'type' >> field. > I don't like it because this will make the mapfile incompatible with > what download.01.org uses. We originally derived it from that. I assumed that it was this file: https://download.01.org/perfmon/mapfile.csv which already has a different format - extra columns - so figured that some handcrafting was already going on. Indeed 'type' is not always 'core' there. > > It would be ok if it fixed something serious, but as it seems to be > more cosmetic I don't think there's a good reason to devivate. > If you're against that, then ok; I suppose jevents handling could still be removed, but I'm not enthused. Thanks, John