From: Birger Koblitz <mail@birger-koblitz.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: sashiko-reviews@lists.linux.dev, linux-usb@vger.kernel.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jianhui Xu <neuromoments@gmail.com>
Subject: Re: [PATCH net-next v19 01/13] phylink: Add phylink_mac_interrupt
Date: Tue, 20 Oct 2026 05:50:08 +0200 [thread overview]
Message-ID: <d2b9c51d-2f82-49d9-a072-aa47959d7242@birger-koblitz.de> (raw)
In-Reply-To: <20261019171805.6aa3a7a3@kernel.org>
Thanks Jakub for the explanation!
On 20/10/2026 2:18 am, Jakub Kicinski wrote:
> On Sun, 11 Oct 2026 07:32:52 +0200 Birger Koblitz wrote:
> You are responding to the main Sashiko instance, not the netdev one.
> Due to infinite wisdom of some MM people these are not even CCed
> to netdev (I guess CCing the USB list triggers them?)
> You can ignore the feedback form that instance for networking patches.
>
> Unfortunately our instance didn't run because patch 4 breaks the build
> (patch 12 fixes it). Our instance tries to save tokens and doesn't run
> on patches where basic CI checks fail.
It would be nice to get that kind of feedback immediately from the CI
system.
>
> drivers/net/usb/ax88179_178a.c:691:8: error: use of undeclared label 'err_nodev'
> 691 | goto err_nodev;
> | ^
Interestingly, Sashiko did not even complain about that. And the extra
error handling was in respect of existing code. Should have refused to
do that, I guess...
I will fix only this issue, then, and re-send once the patch window
opens again. Thanks again for looking into this,
Birger
next prev parent reply other threads:[~2026-10-20 3:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 4:54 [PATCH net-next v19 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
2026-10-10 4:54 ` [PATCH net-next v19 01/13] phylink: Add phylink_mac_interrupt Birger Koblitz
[not found] ` <sashiko-outbox-167008@kernel.org>
2026-10-11 5:32 ` Birger Koblitz
2026-10-20 0:18 ` Jakub Kicinski
2026-10-20 3:50 ` Birger Koblitz [this message]
2026-10-10 4:54 ` [PATCH net-next v19 02/13] phylib: Add support for PHYs with broken forced mode Birger Koblitz
2026-10-10 4:54 ` [PATCH net-next v19 03/13] ax88179_178a: Split driver into library and device specific code Birger Koblitz
2026-10-10 4:54 ` [PATCH net-next v19 04/13] ax88179_178a: Add HW support for AX179A-based chips Birger Koblitz
2026-10-10 4:54 ` [PATCH net-next v19 05/13] ax88179_178a: Add EEE configuration support for AX88179A MACs Birger Koblitz
2026-10-10 4:54 ` [PATCH net-next v19 06/13] ax88179_178a: Add EEE configuration support for AX88179A PHYs Birger Koblitz
2026-10-10 4:54 ` [PATCH net-next v19 07/13] ax88179_178a: Add VLAN offload support for AX88179A Birger Koblitz
2026-10-10 4:54 ` [PATCH net-next v19 08/13] ax88179_178a: Add AX179A/AX279 multicast configuration Birger Koblitz
2026-10-10 4:54 ` [PATCH net-next v19 09/13] ax88179_178a: Add Suspend/resume support for AX88179A/772D/279 Birger Koblitz
2026-10-10 4:54 ` [PATCH net-next v19 10/13] ax88179_178a: Add ethtool get_drvinfo Birger Koblitz
2026-10-10 4:54 ` [PATCH net-next v19 11/13] ax88179_178a: Update driver name and information Birger Koblitz
2026-10-10 4:54 ` [PATCH net-next v19 12/13] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access Birger Koblitz
2026-10-10 4:54 ` [PATCH net-next v19 13/13] ax88796b: Add support for AX88772D, AX88179A and AX88279 Birger Koblitz
2026-10-10 6:20 ` [PATCH v19 0/13] ax88179_178a: Add support for AX88179A-based chips Jianhui Xu
2026-10-10 7:42 ` Birger Koblitz
2026-10-29 0:58 ` [PATCH net-next v19 00/13] " Emir Beganovic
2026-10-30 15:42 ` Birger Koblitz
2026-10-30 16:47 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2b9c51d-2f82-49d9-a072-aa47959d7242@birger-koblitz.de \
--to=mail@birger-koblitz.de \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=neuromoments@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®