From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754297AbcEDOos (ORCPT ); Wed, 4 May 2016 10:44:48 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:35882 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbcEDOkD (ORCPT ); Wed, 4 May 2016 10:40:03 -0400 Subject: Re: [PATCH 05/13] iio: health/afe440x: Fix scan_index assignment To: "Andrew F. Davis" , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald References: <1462135023-14445-1-git-send-email-afd@ti.com> <1462135023-14445-6-git-send-email-afd@ti.com> Cc: linux-iio@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: Date: Wed, 4 May 2016 11:03:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1462135023-14445-6-git-send-email-afd@ti.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/16 21:36, Andrew F. Davis wrote: > The LED channels are not scannable and so scan_index should > be negative, fix this here. > > Signed-off-by: Andrew F. Davis Good point. I've applied this to the togreg branch, but if you want me to push this one out as a fix it definitely qualifies. Jonathan > --- > drivers/iio/health/afe440x.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/health/afe440x.h b/drivers/iio/health/afe440x.h > index 544bbab..583d071 100644 > --- a/drivers/iio/health/afe440x.h > +++ b/drivers/iio/health/afe440x.h > @@ -125,7 +125,7 @@ struct afe440x_reg_info { > .type = IIO_CURRENT, \ > .channel = _index, \ > .address = _index, \ > - .scan_index = _index, \ > + .scan_index = -1, \ > .extend_name = _name, \ > .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ > BIT(IIO_CHAN_INFO_SCALE), \ >