From: Heiner Kallweit <hkallweit1@gmail.com>
To: ChunHao Lin <hau@realtek.com>,
nic_swsd@realtek.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8169: add support for RTL8126A rev.b
Date: Fri, 30 Aug 2024 07:34:05 +0200 [thread overview]
Message-ID: <d2c681d6-2213-4cad-8b01-783ee5f864b0@gmail.com> (raw)
In-Reply-To: <20240830021810.11993-1-hau@realtek.com>
On 30.08.2024 04:18, ChunHao Lin wrote:
> Add support for RTL8126A rev.b. Its XID is 0x64a. It is basically
> based on the one with XID 0x649, but with different firmware file.
>
> Signed-off-by: ChunHao Lin <hau@realtek.com>
> ---
> drivers/net/ethernet/realtek/r8169.h | 1 +
> drivers/net/ethernet/realtek/r8169_main.c | 42 ++++++++++++-------
> .../net/ethernet/realtek/r8169_phy_config.c | 1 +
> 3 files changed, 29 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169.h b/drivers/net/ethernet/realtek/r8169.h
> index 00882ffc7a02..e2db944e6fa8 100644
> --- a/drivers/net/ethernet/realtek/r8169.h
> +++ b/drivers/net/ethernet/realtek/r8169.h
> @@ -69,6 +69,7 @@ enum mac_version {
> RTL_GIGA_MAC_VER_61,
> RTL_GIGA_MAC_VER_63,
> RTL_GIGA_MAC_VER_65,
> + RTL_GIGA_MAC_VER_66,
> RTL_GIGA_MAC_NONE
> };
>
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index 3507c2e28110..3cb1c4f5c91a 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -56,6 +56,7 @@
> #define FIRMWARE_8125A_3 "rtl_nic/rtl8125a-3.fw"
> #define FIRMWARE_8125B_2 "rtl_nic/rtl8125b-2.fw"
> #define FIRMWARE_8126A_2 "rtl_nic/rtl8126a-2.fw"
> +#define FIRMWARE_8126A_3 "rtl_nic/rtl8126a-3.fw"
>
I checked linux-firmware repo, the new firmware isn't available
there yet. Are you going to submit the firmware file?
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
next prev parent reply other threads:[~2024-08-30 5:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 2:18 ChunHao Lin
2024-08-30 5:34 ` Heiner Kallweit [this message]
2024-08-30 6:03 ` Hau
2024-09-03 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2c681d6-2213-4cad-8b01-783ee5f864b0@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hau@realtek.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®