From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 754623D904E for ; Wed, 18 Mar 2026 13:50:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773841840; cv=none; b=Vokh4x0IWOPaIXsA5XZC5GFa4PzD7eql7bjEsMQJNGINfFKR9zk3UvlDdds7Fzk30hj3MjJuABBD5b+fp/3JllR8wQv3RldtRfhLpmqU3rM4g0e1RZMu1/pEwZ3QHQ10PhoGeieYGmsAcSKiIlSty53atZqur9fCHflM0wmRTgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773841840; c=relaxed/simple; bh=nkQS4w83MmdQFrdP0W/19UuG3MELkzWpAnrl4Uv2Z0k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=c/GMQxf7hqbXrICLAFxBFZcuHNppiSslSDtWAJ+ppvvZD8xzHna9Zp0VymME/3QkAg6tpb1qkKPD4+Q9fFRJ+9by4PtbxParr9oMINQiR3+faxSQLlRfFTMdf1tKptpHFe0vliSuYkgA1hAcuXMdElwO8fdwqUWHif5hvA4eV9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NuIh2cp+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HyOHCsf/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NuIh2cp+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HyOHCsf/" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62IAi3Ns008768 for ; Wed, 18 Mar 2026 13:50:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yxgPs4A2aV5nJQ+32pziXlEECTTOn7MJ+QMCGaDo1PM=; b=NuIh2cp+bqxR0rAi z15rXLlZnst4Ym5fd+fbNfyzm4tjtEJwvKj5HWFGDa8XCfWF87GKcHTULR2RI6zR RtKLV33s7C/AX4CGd9PHrKpr78/0gWDLk62KPLC730prWj7JesPDC+tdj1NqiGVf 0YTE6JVhzUHEGyk0ROit/WLx+QYDtUZQVRclIqaKi0xJcKVwJMJo3J7ZnTWITq6Q kVByqA7vEaL+lxLr8477ALq5FDRgronMal6xCglNnjCMmgycSuldKKiUTobjCHy4 7Xofb9Gr/CbUyUM2QFHBFJbqePgGJ5ulkwIT+54lLytraHAuYNw6anRCTBzLd3sw xdOfOw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cytj50n0x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 13:50:38 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35449510446so6932326a91.0 for ; Wed, 18 Mar 2026 06:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773841837; x=1774446637; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yxgPs4A2aV5nJQ+32pziXlEECTTOn7MJ+QMCGaDo1PM=; b=HyOHCsf/xjOsKQbBy6E4BTLu8bKoF6CrsIzpHN2NvfC/3EumwF04olcoT6G7FNnl20 hdrLTw8b2/mpNoya0HG8etXy8rAcwls7aekqfVhIidsymOWwkXCVoIbNf2VzPHAJiYIW nwpbGx6R/DrLm/ReYxVUiMYdsMxkatzTsC8ak4L00GN3OVVemTXSJG9CAAOlKGFeDbde S379hxSQmux6wpmRlT57Lfvf0OAOBpDQs74kCjIxoQBL+qqrMfg+8IuH2tVhTdrpJGee aRy6DvAlk4zW3bIj7tN4uMQR2mRDLB79+JCpYTNYL5PAP9wOxAzfSYHgQ6qgPBaRKA4R K7nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773841837; x=1774446637; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yxgPs4A2aV5nJQ+32pziXlEECTTOn7MJ+QMCGaDo1PM=; b=SvYE1B+IWUHeyQCQBdvJH3i05uX5YU1qC/CA9JQ56Ik9EMaeYGKWorY7USYHCzyAK6 w2nE+Ka0A/UOumHoFBZl0D0GD3Pv3bx1atUAyr2ab5yvQxJL6BGFmcCgEtovVH/DuSNl EB75msUY8hbm7SYAyfDh0UzyvRGIgS4u/bGq2ViQkrIAFT3VcHpEDQyMIaptWa6qV5k8 8j6aw1HlasOftmJBFSfXLGlFwMiG5dq/uy/PicL+9fLqpgt5eaQk9KZKtULfIt+tvGFK ixyKidlZsFqHm1FZH0bSaBCEXI8KHlKrPGFgO3V8Ng0poK4Gt2G1zN6+02/WCWaQy8pF ONPA== X-Gm-Message-State: AOJu0YzHTGR8kVI2YIeJAxhSvwzG1o+qGZC28uQ7R4Qtjyp8tDz3Nc3I m1F3Gwfr19WpBbqF9RNO7JBVUyuoJr86N/u4kZh23wUbe60y9Trwu0Jox+8Tc6WED06ugEDU5CA 9HhUI1N5hyq7fIKoG2RJMMOfcK2AOvprKSYFrR/hAwGfOelFLVkBw9z9vd02+aGY472U= X-Gm-Gg: ATEYQzzMN5KhdUJTMpSCHv5bk0uaAUfSfDBZ7C+FI530LkhfpQQE6j5WzFSYUgb7bfx 9zExkglAVlFuWAPPAK28iAF5gJuKioNEQxZ7c2DKdtbwXpmqSFUCfLQtVCtzSZzim1AQfgdAj0N VAhWXYye1PMxiQFuVhczlcHyvZ3iz6oh2Furb2WtJy8FD+bkrqQkbT9cDcy2wYcHP1CzeNg8DUq IAkOj2qEkTegmNhJ6+1b3/FLC8ucEXqkKtmntMJ0Gop8o8uueTInXUs9Hp/qAPRrLZKDhzfxVMV kmWqkRXydTg+5X/xiY136D8t0Jm4WN/VTupzDxJWY/b14Qs0tTFyNpUyx6VDKg8vyk2nqc9boM5 zZ9UdbSpfMYWAHX2ckjFXlknH4S9x7YVcfCEttaOYtoXcGL6nFw6OJR47UDx9BiijsjU/C13g4v 0lRWNAi55X724= X-Received: by 2002:a05:6a21:3483:b0:398:7357:bb92 with SMTP id adf61e73a8af0-39b99ca7b7cmr3605297637.5.1773841837368; Wed, 18 Mar 2026 06:50:37 -0700 (PDT) X-Received: by 2002:a05:6a21:3483:b0:398:7357:bb92 with SMTP id adf61e73a8af0-39b99ca7b7cmr3605260637.5.1773841836849; Wed, 18 Mar 2026 06:50:36 -0700 (PDT) Received: from [10.133.33.163] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c741e577c1esm2929352a12.28.2026.03.18.06.50.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 06:50:36 -0700 (PDT) Message-ID: Date: Wed, 18 Mar 2026 21:50:31 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 7/7] qcom-tgu: Add reset node to initialize To: Songwei Chai , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, konrad.dybcio@oss.qualcomm.com, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org References: <20260317032639.2393221-1-songwei.chai@oss.qualcomm.com> <20260317032639.2393221-8-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260317032639.2393221-8-songwei.chai@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDExOCBTYWx0ZWRfXz+o504ubX7lK pvFlxnAb0kmXY9eq5kxgLlXOu80vh3T82V0F1ur12UvK5duCGEtCZCT40uTx678i569X7aVHOuu hjIIoFaPJPsc/4krC1JK9ltd5F0JKvz1S/kvEBuK/+5LYAw/oaioMW1zzaZJZu9BnCrm7rDWG6a vCNr+JWhaS0Z7n/60U181eHBfVm4pNMO59/e3Fg3Kqdx9gQjEzkJAklbhnIH3KRSu/gFt6QoDAN eju8yyW7lAGRd/cxIdL9lZb320lL7TP/O1TSlu9zzkv2Dv2WpaSq03nXSvJYITAWOQY5XTsJFLS NDi+Z3n+kTqRGXI1SNPQk4bIfcZjaPN6hA0ubwaVtUNoBc3kUB4/0JokCEsjEmZIjBHyM6uxsBc s9TQybsAEIsOuD2UdVMWbRayyIj0NMocI2IDpXxCS0Qz5XYkJTfusTfZ3qI1aKm0RIbTVVB45UW +KZMdsc6vgMZw3udHoQ== X-Proofpoint-ORIG-GUID: 1qwzN_2uPrP6IcMlkDM5ChuYh4ynv9hs X-Proofpoint-GUID: 1qwzN_2uPrP6IcMlkDM5ChuYh4ynv9hs X-Authority-Analysis: v=2.4 cv=dM+rWeZb c=1 sm=1 tr=0 ts=69baadae cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=arahFDS25cvTpKsIBlcA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180118 On 3/17/2026 11:26 AM, Songwei Chai wrote: > Add reset node to initialize the value of > priority/condition_decode/condition_select/timer/counter nodes. > Reviewed-by: Jie Gan > Signed-off-by: Songwei Chai > --- > .../ABI/testing/sysfs-bus-amba-devices-tgu | 7 ++ > drivers/hwtracing/qcom/tgu.c | 77 +++++++++++++++++++ > 2 files changed, 84 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > index 5370882333bc..1dcb8fb71cd9 100644 > --- a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > +++ b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > @@ -42,3 +42,10 @@ KernelVersion 7.1 > Contact: Jinlong Mao , Songwei Chai > Description: > (RW) Set/Get the counter value with specific step for TGU. > + > +What: /sys/bus/amba/devices//reset_tgu > +Date: March 2026 > +KernelVersion 7.1 > +Contact: Jinlong Mao , Songwei Chai > +Description: > + (Write) Write 1 to reset the dataset for TGU. > diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c > index 4539415571f6..e28e6d27cf56 100644 > --- a/drivers/hwtracing/qcom/tgu.c > +++ b/drivers/hwtracing/qcom/tgu.c > @@ -410,8 +410,85 @@ static ssize_t enable_tgu_store(struct device *dev, > } > static DEVICE_ATTR_RW(enable_tgu); > > +/* reset_tgu_store - Reset Trace and Gating Unit (TGU) configuration. */ > +static ssize_t reset_tgu_store(struct device *dev, > + struct device_attribute *attr, const char *buf, > + size_t size) > +{ > + struct tgu_drvdata *drvdata = dev_get_drvdata(dev); > + struct value_table *vt = drvdata->value_table; > + u32 *cond_decode = drvdata->value_table->condition_decode; > + bool need_pm_put = false; > + unsigned long value; > + int i, j, ret; > + > + if (kstrtoul(buf, 0, &value) || value != 1) > + return -EINVAL; > + > + spin_lock(&drvdata->lock); > + if (!drvdata->enabled) { > + spin_unlock(&drvdata->lock); > + ret = pm_runtime_resume_and_get(drvdata->dev); > + if (ret) > + return ret; > + need_pm_put = true; > + spin_lock(&drvdata->lock); > + } > + > + tgu_do_disable(drvdata); > + > + if (vt->priority) { > + size_t size = MAX_PRIORITY * drvdata->num_step * > + drvdata->num_reg * sizeof(unsigned int); > + memset(vt->priority, 0, size); > + } > + > + if (vt->condition_decode) { > + size_t size = drvdata->num_condition_decode * > + drvdata->num_step * sizeof(unsigned int); > + memset(vt->condition_decode, 0, size); > + } > + > + /* Initialize all condition registers to NOT(value=0x1000000) */ > + for (i = 0; i < drvdata->num_step; i++) { > + for (j = 0; j < drvdata->num_condition_decode; j++) { > + cond_decode[calculate_array_location(drvdata, i, > + TGU_CONDITION_DECODE, j)] = 0x1000000; > + } > + } > + > + if (vt->condition_select) { > + size_t size = drvdata->num_condition_select * > + drvdata->num_step * sizeof(unsigned int); > + memset(vt->condition_select, 0, size); > + } > + > + if (vt->timer) { > + size_t size = (drvdata->num_step) * (drvdata->num_timer) * > + sizeof(unsigned int); > + memset(vt->timer, 0, size); > + } > + > + if (vt->counter) { > + size_t size = (drvdata->num_step) * (drvdata->num_counter) * > + sizeof(unsigned int); > + memset(vt->counter, 0, size); > + } > + > + spin_unlock(&drvdata->lock); > + > + dev_dbg(dev, "Qualcomm-TGU reset complete\n"); > + > + if (need_pm_put) > + pm_runtime_put(drvdata->dev); > + > + return size; > +} > +static DEVICE_ATTR_WO(reset_tgu); > + > static struct attribute *tgu_common_attrs[] = { > &dev_attr_enable_tgu.attr, > + &dev_attr_reset_tgu.attr, > NULL, > }; >