From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AA443E4C90 for ; Fri, 8 May 2026 13:53:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778248393; cv=none; b=uD2VByBUbjdVLIyiiVC2k+Xx0dkc09N6zQ60mN1lGLweqDirxg5KTVdrLAbGj9nMz+svi6e2JnG55FO1pa3minZO7KbFctEgtKjb+MZbfUUOqZT/scj/mofyd1yKsRTRdaiehKJT78CaQXbvqpzbg0FQe7yjUXFeq76T5PE3TdY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778248393; c=relaxed/simple; bh=9+3eMhnNWle9yhGvANK/FogGDfCT90zSsXcpVzTMAPo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qavIDhvMZGV/O3vqdT0RLCaM8Vtna5I7a9h6kd+5MI3zN9LqrrR8WqOA+HaXIZzySqiWjcd3h52DBSYZuxtoI+hm3lJ3vRjDw/8vR4uO6I0RwAmKP9tZo3dFl+KFjJCk1+FYnyDm4IEqVP0vJjSROSAKV7X3jzTOx2zlQ784QDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ko2ox87O; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P98Q7Duc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ko2ox87O"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P98Q7Duc" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 648DE6Fj258436 for ; Fri, 8 May 2026 13:53:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uVvAXF9dVNv+RiFGpy3EXZpalacZAoCjGBc2U1lKRE0=; b=Ko2ox87OWAQtDqKK TvNzzeUeQ0qnjvqRDq8mLaIg8aXPnxMr/h2RHofLOYev/sMtfEqPOHcfyyU0cgVl broKzh/8gCNzivwMozQNH1n+CIGwH0d5V7fbxqnZirugLLrwVaEfwWKa/XjTc11A NRkkmRke64wVzfz8D7maWFJ3H0oQw7Gl43Bh9quTD3sX7geOu/cwsSTMhaUuhj6r /wiueP+t7FIc0+IaC8O6nc9GSMiiM90DFckUOkQc/g2QfiWxlVjSu7vuACPfJoE+ IcNE7nsfhHkr3VM10b0k8hc0dw2tXSA1sRj5oWrkJHt1Nyd0y7gkgw0YVN9EMe1X 7L/MJg== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1auehkjw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 08 May 2026 13:53:10 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-837d0d71c61so1247321b3a.1 for ; Fri, 08 May 2026 06:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778248389; x=1778853189; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uVvAXF9dVNv+RiFGpy3EXZpalacZAoCjGBc2U1lKRE0=; b=P98Q7DucCcwMHAofagcMIez/3Mydgv1qVHiGbzJtglitMLekb4TVvqjMGTaTnDbFyu upjotRj8WVhEmKg7GFQa1sdPYQc6CIL1jpU0KAS/NkqShfOIfsXWmxAErd2MNV1PTESv sct0NIgS4/4Kicx2O8DMIQmbJ6O86iq0sh6MboUvBgrXDhNkJHpOCzbUSEIZZ2TEcgL8 NLmcxj8h95KbEnLVDCw1Vrl1HrdoRvBSi2eWITAyPBlkTbam2Wo2FvtkmPyxZe3q0dOc 4V0eX30XtflFnvLpQkmWdIu68SlETR4FOqMrYHE1+Eoa0u35eKXnqXLLcA8IfZEM7L++ a3CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778248389; x=1778853189; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uVvAXF9dVNv+RiFGpy3EXZpalacZAoCjGBc2U1lKRE0=; b=a4vgb14eQ9tPy3zVOas6Ggq13iBowHB7sf/hyB3Sjz6Kgcvy0+Q7cHLQZuGA6al2Ct BuhCUC4km3sBA4EywG5PbHH5E3Svq7XuAnUQ/5lh8Jkl8/DYwA7IXTh0UmVYYujCL8Ti 9VyXljDeexUi9hq8ECyrDffb31izOSLrQUGBR+V4jieaGMtDkZWHl/O5uYC8I1W2gu3u cSXgF2Sw1q4HqZiHnIbCi6IPYujyEEfCGhPTUlczzRL7lkZyFvOkZAsFjkRMrWvww8D9 SeC4c9LQTTfohitJuWTCoie0PC2LR6SdZyAVOgzZ0YOL1yQcBM8E2+pkri8ylUjdLOph SHWw== X-Forwarded-Encrypted: i=1; AFNElJ/gzsT8WfBHEqyA5moEaD7JdC9+PEHIPss2RyBRs479gjHF8524wj/0YOyELaCBV+OimyUNw9xdN1iJ6x4=@vger.kernel.org X-Gm-Message-State: AOJu0Ywe9cASBn7+LHSs8lsoIVpKoqjFrvgpBBafRhYMsLgr+Wvqt6XJ cbihoaHQel494kspxeV48wE4tlp5IA3ZVroipuXRKSyDdjcYPkSOTYMa3546Th1BjhRSr8FzqFH PW1fFtfXwapS1XO/oyC3yMQ8EWvfTOF4hVWucuX2oHqgz2H1QnfqXOMKfEH+BYLj/DRM= X-Gm-Gg: Acq92OGu9dkRKwrOCCwa+Bo6iq44j9WfIWdCsA5Q0VsAmcq59kjJgVIYyMsZFg5gg1o psprR0zhnOhNvbyNPrrtRYW4xaJm6WyBUe255exknCsKH0EZcb0xFaByp6d09X4t1/jzW07Zbiz rYfmJWyQ8kEfk2addvv/GktJjpkZ9jmFoiM8ov/JbR6wZgK3JPLbzLDGdXRuydAKnfg4jNO48IE PJUzYXELZCpb0s51h0gxRaD5CmZqXkV/wv+gRk++rTrAvcdHqmQj0xxRH1IOlVbqeJhp1l+ypAd gBZC1qaJ3e90hWoro0POkJHxVqBngRMyqU6ELaEMF1VMBJ+y8hzv+R9ontEYEkgmvV/cSadMORx gPyhLj9ayuJGFSNm6nhsVNiZSRE8Puj9kMPGJnx0GXuQ6NcHfwc2kAIedx1x3svsRBGYgiS68FS E/5utxtK1jEng= X-Received: by 2002:a05:6a00:4fd1:b0:829:7e6d:cf22 with SMTP id d2e1a72fcca58-83a5e35d551mr12165855b3a.43.1778248388833; Fri, 08 May 2026 06:53:08 -0700 (PDT) X-Received: by 2002:a05:6a00:4fd1:b0:829:7e6d:cf22 with SMTP id d2e1a72fcca58-83a5e35d551mr12165816b3a.43.1778248388287; Fri, 08 May 2026 06:53:08 -0700 (PDT) Received: from [10.133.33.235] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83965b333f2sm15555774b3a.20.2026.05.08.06.53.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 May 2026 06:53:07 -0700 (PDT) Message-ID: Date: Fri, 8 May 2026 21:53:03 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] coresight: fix missing error code when trace ID is invalid To: Leo Yan Cc: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Tingwei Zhang , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260508-fix-trace-id-error-v1-1-5f11a5456fdf@oss.qualcomm.com> <20260508134437.GH3778514@e132581.arm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260508134437.GH3778514@e132581.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDE0MSBTYWx0ZWRfX+Y3Au8u2K3u1 O9B4g/7dzEfwykAei8q9bXvKOZDpgQx6shG2j2K13eZp9WFk1UL3C94hsFhliG4cpTNta3TTOLi Tdeq4FT6/LogjMCD5ET2kIzCGkY1Y+cwifZIH4mEf9unkxpr1cMeLrmQauYRWkHBt01OECTQYZ1 ddCj59CRXzyJfi0fKnIMgTRDZGsODte+UPNMh1s2PKpggg+Hg28qzTp4oGyrJ8ThzXlC1Jqbg8/ F1/jwH29LLBZOxdUDdoAc4YX4AbXpaQNAQnAMWkVbEGcTgZ3EZtPQJdxdoDNffi9/fdCl2t6iwl 48R9fWYrvRV7eANulxu9p4qKyS36T+ydV+zwh5Qyj5QpTN+F3+jMwzIvljl8KZL8NFOWbckpfTe QCI+SH5wJ32se78OLOrSsraxK6LCp8xfkoE+9J/ruXMdTPuNG5J6nW1F/ox3/FJErD8/3knjgxM ZiCnkdifr97ZfR0WF9g== X-Proofpoint-GUID: 7HqI_orQ4BooZQcp0bcsO7MJwAlh71gF X-Proofpoint-ORIG-GUID: 7HqI_orQ4BooZQcp0bcsO7MJwAlh71gF X-Authority-Analysis: v=2.4 cv=fcydDUQF c=1 sm=1 tr=0 ts=69fdeac7 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=7CQSdrXTAAAA:8 a=ztVgkDR5hBTvFSzV1csA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605080141 Hi Leo, On 5/8/2026 9:44 PM, Leo Yan wrote: > On Fri, May 08, 2026 at 01:45:35PM +0800, Jie Gan wrote: > > [...] > >> coresight_path_assign_trace_id(path, CS_MODE_SYSFS); >> - if (!IS_VALID_CS_TRACE_ID(path->trace_id)) >> + if (!IS_VALID_CS_TRACE_ID(path->trace_id)) { >> + ret = -EINVAL; >> goto err_path; >> + } > > On the top of this patch, could we do a further improvement? > > Move IS_VALID_CS_TRACE_ID() into coresight_path_assign_trace_id() and > return 0 for success and < 0 for failures. As result, callers only > need to check the returned value. > That's a good suggestion. I will check these logic once. I will send a new patch to do the refactor if worth. Thanks, Jie > For this patch: > > Reviewed-by: Leo Yan