From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EE77262BD for ; Tue, 14 May 2024 15:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715701147; cv=none; b=creZZ1teyN22blAo46E+lb5XunMT7AbFPzaWRTPIKT+swfAwCU7q3JpLDUUNiPAwIplZs3X9MPnkaLEZoO2+s/mM0DXKIj0lYVZqNJPn/941JprhcMEICThQLcVcEhqHhxw0LtnEnMtSonXqUA2JfsRdTGNz9JUiGiw2vt0JZUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715701147; c=relaxed/simple; bh=iAbHNd7mgRq7oUO67Du6wjpeeQPoT8tIG4U0JNdY+v8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hBBO5diX1jMqyGJmoq1bvwfqRuWJftXd0n9Rvsfp7cLeyyDHqfgc0OV+qxhvoPP2mN8dSLfiZcTNBQK6MZQTcaO43n1VuixShSOQQ7ppy3jeZSHdsaUtMehftc7Axd8GeG7tOSpm99rNMKHWLPBywjRT1qjROn/k6SVFdnIe6e4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HDXcR84n; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HDXcR84n" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715701144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rbW4AqFrMaISOC2LX0H+2PlSbMomBOm3GeVdMfM6+Gc=; b=HDXcR84n96di2IvP6v7EiFNh+3w4wRwtDsF+hye6mCVolJen/G10axtvjMWRm8YwMX1o0j OK+9G+3i6DIm6MkkncXw2wQoJtHwLxiMq5wy0EGrfhlz6M3vdPXODE5eTwd6Vk85qnQz+E /oNmAaCYOYcmL8HtE4LHqlnGqSsztq8= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-1wqNPDgLOj2EtuL7c10lWg-1; Tue, 14 May 2024 11:38:47 -0400 X-MC-Unique: 1wqNPDgLOj2EtuL7c10lWg-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a5a8f3bc8e0so24309566b.1 for ; Tue, 14 May 2024 08:38:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715701126; x=1716305926; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rbW4AqFrMaISOC2LX0H+2PlSbMomBOm3GeVdMfM6+Gc=; b=HNPu3Fr6SjXyaKmqr2CgK1HTqKqDBac+ptlh+Pdr0oZy0+apvspMtznxIs5R92doBj bNwueW8La4gHjycEiOx4+RfGrIbMa/u/6WF8ckRaaM0Cgc3wc5bzqkdPmRxlTZ00oQpS FyUBoiwyzLE7ExV3ez1vlglEsDNV3sUpoYSbxfImElkXIX/2ZF9Bq/C2asQe6ntcU1YQ RQtImEvGlsouPDjGk6/nwudUw8zR16VH7uiyMVvIuRPynTasqRrR53pAxZPr3k+gibh8 HAq63tnkY0H3VKliAK8vDO/QiwW6GeaUPafNIsvmRHysaX4vn+QYs8nOJ0CkaCRSZ5xz yO6Q== X-Forwarded-Encrypted: i=1; AJvYcCVtZmrWVdMkKbnIP3i9rchz2Fys6ONk3VUP/+t2hRx+4rkrS8+AJsAbshrLXPCziOBsVF/kWF+qHx1qqRdUPu1cxulK+lW4dMmHIhkW X-Gm-Message-State: AOJu0Yzf02ADhYP1cg4TycK26fsrvUHjRytjmsJioBFIUz9q7xyesZi7 L3i1iR9AH8mMvqkqlMgMhtbQVC4ULDQclpryFSd3Wu9jo196Dpj2Z1ztH6ZceI9dGV6HH5lDbfo JZYJmBEF+cKPDoF/XjtuyCi7l3AtxqWTMM44HQ0tgvTtO83UBhvpe5UClqwg5Sg== X-Received: by 2002:a17:906:8315:b0:a5a:d6c:a30b with SMTP id a640c23a62f3a-a5a2d65f265mr915834366b.58.1715701126596; Tue, 14 May 2024 08:38:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpzNVie/tGXiTgKB6/FpHbCOQeaspSL5sLUiSvss9/S6ulsnG3niwPgLtjnNrjiabiLgi7TA== X-Received: by 2002:a17:906:8315:b0:a5a:d6c:a30b with SMTP id a640c23a62f3a-a5a2d65f265mr915833766b.58.1715701126281; Tue, 14 May 2024 08:38:46 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a179c80f4sm743539866b.142.2024.05.14.08.38.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 May 2024 08:38:45 -0700 (PDT) Message-ID: Date: Tue, 14 May 2024 17:38:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] media: ipu-bridge: fix error code in ipu_bridge_init() To: Andy Shevchenko , Sakari Ailus Cc: Dan Carpenter , Bingbu Cao , Mauro Carvalho Chehab , Daniel Scally , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: Content-Language: en-US, nl From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 5/14/24 5:21 PM, Andy Shevchenko wrote: > On Tue, May 14, 2024 at 02:33:31PM +0000, Sakari Ailus wrote: >> On Fri, May 10, 2024 at 06:43:31PM +0300, Dan Carpenter wrote: > > ... > >> Neither IPU3-CIO2 or IPU6 ISYS drivers should be of any functional use >> without sensors. But the power states of the devices could be affected by >> this: the drivers should power off these devices but without drivers they >> maybe left powered on. I haven't made any measurements though. > > FWIW, Hans mentioned AtomISPv2 case with somewhat 7W consumption on top of > the idling machine. That's why we have a stub driver in PDx86 exactly for > the purpose of turning it off when not used. I'm not sure if I ever mentioned the 7W, that seems a lot. But in the atomisp case the SoC will never reach S0i3 when the ISP is not properly turned off. And in this case the ISP is special and just letting PCI / ACPI put it in D3 is not enough it needs some special writes on the IO-Sideband-Fabric to be turned off. I don't know if something similar applies to the IPU3 / IPU6, but the bridge code is used by the atomisp code now too. So at a minimum if an error gets returned when there are no sensors then this must be unique enough that the atomisp code can check for it. Maybe -ENODEV ? Regards, Hans