From: <Mario.Limonciello@dell.com>
To: <mathewk@chromium.org>, <linux-kernel@vger.kernel.org>
Cc: <acelan.kao@canonical.com>, <dvhart@infradead.org>,
<andy@infradead.org>, <platform-driver-x86@vger.kernel.org>
Subject: RE: [PATCH] platform/x86: intel-vbtn: Report switch events when event wakes device
Date: Mon, 20 May 2019 15:40:34 +0000 [thread overview]
Message-ID: <d2dac2d720574c58bb0d273809f46cf9@AUSX13MPC105.AMER.DELL.COM> (raw)
In-Reply-To: <20190516215615.261258-1-mathewk@chromium.org>
> -----Original Message-----
> From: platform-driver-x86-owner@vger.kernel.org <platform-driver-x86-
> owner@vger.kernel.org> On Behalf Of Mathew King
> Sent: Thursday, May 16, 2019 4:56 PM
> To: linux-kernel@vger.kernel.org
> Cc: Mathew King; AceLan Kao; Darren Hart; Andy Shevchenko; platform-driver-
> x86@vger.kernel.org
> Subject: [PATCH] platform/x86: intel-vbtn: Report switch events when event wakes
> device
>
>
> [EXTERNAL EMAIL]
>
> When a switch event, such as tablet mode/laptop mode or docked/undocked,
> wakes a device make sure that the value of the swich is reported.
> Without when a device is put in tablet mode from laptop mode when it is
> suspended or vice versa the device will wake up but mode will be
> incorrect.
>
> Tested by suspending a device in laptop mode and putting it in tablet
> mode, the device resumes and is in tablet mode. When suspending the
> device in tablet mode and putting it in laptop mode the device resumes
> and is in laptop mode.
>
> Signed-off-by: Mathew King <mathewk@chromium.org>
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
> ---
> drivers/platform/x86/intel-vbtn.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index 06cd7e818ed5..990cc8c20872 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -76,12 +76,15 @@ static void notify_handler(acpi_handle handle, u32 event,
> void *context)
> struct platform_device *device = context;
> struct intel_vbtn_priv *priv = dev_get_drvdata(&device->dev);
> unsigned int val = !(event & 1); /* Even=press, Odd=release */
> - const struct key_entry *ke_rel;
> + const struct key_entry *ke, *ke_rel;
> bool autorelease;
>
> if (priv->wakeup_mode) {
> - if (sparse_keymap_entry_from_scancode(priv->input_dev, event))
> {
> + ke = sparse_keymap_entry_from_scancode(priv->input_dev,
> event);
> + if (ke) {
> pm_wakeup_hard_event(&device->dev);
> + if (ke->type == KE_SW)
> + sparse_keymap_report_event(priv->input_dev,
> event, val, 0);
> return;
> }
> goto out_unknown;
> --
> 2.21.0.1020.gf2820cf01a-goog
prev parent reply other threads:[~2019-05-20 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 21:56 Mathew King
2019-05-20 15:40 ` Mario.Limonciello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2dac2d720574c58bb0d273809f46cf9@AUSX13MPC105.AMER.DELL.COM \
--to=mario.limonciello@dell.com \
--cc=acelan.kao@canonical.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathewk@chromium.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®