From: Krzysztof Kozlowski <krzk@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
lee@kernel.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com,
beomho.seo@samsung.com, ideal.song@samsung.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/4] mfd: exynos-lpass: Move exynos_lpass_remove()
Date: Sun, 30 Mar 2025 12:02:38 +0200 [thread overview]
Message-ID: <d2dc6a8d-8843-4c25-9e6c-a8a67bd76367@kernel.org> (raw)
In-Reply-To: <1de670e6b9fa33cb81a34e5f882e79b80e479490.1743231856.git.christophe.jaillet@wanadoo.fr>
On 29/03/2025 08:45, Christophe JAILLET wrote:
> In order be able to call exynos_lpass_remove() from the error handling
> path of the probe, it first needs to be moved before the probe.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
This change makes no sense on its own. There is no point in moving the
code just for moving the code. That's not the goal.
Squash it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-30 10:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 7:45 [PATCH 0/4] mfd: exynos-lpass: Fix some error handling paths Christophe JAILLET
2025-03-29 7:45 ` [PATCH 1/4] mfd: exynos-lpass: Fix an error handling path in exynos_lpass_probe() Christophe JAILLET
2025-03-30 10:01 ` Krzysztof Kozlowski
2025-03-29 7:45 ` [PATCH 2/4] mfd: exynos-lpass: Avoid calling exynos_lpass_disable() twice in exynos_lpass_remove() Christophe JAILLET
2025-03-30 10:02 ` Krzysztof Kozlowski
2025-03-29 7:45 ` [PATCH 3/4] mfd: exynos-lpass: Move exynos_lpass_remove() Christophe JAILLET
2025-03-30 10:02 ` Krzysztof Kozlowski [this message]
2025-03-29 7:45 ` [PATCH 4/4] mfd: exynos-lpass: Fix another error handling path in exynos_lpass_probe() Christophe JAILLET
2025-03-30 10:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2dc6a8d-8843-4c25-9e6c-a8a67bd76367@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=ideal.song@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®