From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEC38274B55 for ; Tue, 23 Sep 2025 08:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758614988; cv=none; b=YJ+mr+9huwXbHZNqZR0v4182yqmWoaOOO5ujgDKK0wnOXOttfCpvgwosqKsW+DR2dJ2QyuuBU9JnBbZU560gLvFyhsDe8rGf1zQjASt5ta3RFvHNTZy8BWk5Lzwmps5clrbw7bd98x//5Po2ZUhysRKe3z2baR9KAnbfE4OPJSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758614988; c=relaxed/simple; bh=XbXMr+DHtmjBQ7kx6LVwr8HhiuD8bk+/gVj2rgPADac=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nWL/gJ5FxQnTja19RV+lzZJPOJ+3Z7EBO7IVE7nemt4KhACqpdC6uvMCbWcOFZakpPzToc927NTf5LFuJH9OePVzjOkfc0i2oQ/FV6rPz/Xslqvm0hz/9Q3FqMjJODXHvrWibFQFny5DOU21CYnLoI2Lfa1jBXEo2hfN6zyPvKo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GJ36UmNq; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GJ36UmNq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758614986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sjew5omy6aBEynE/MbLFlpptKr9mVmWrE4MDs78qygI=; b=GJ36UmNqf5w7K2mjBWFP51aeEWqle0Sy7fbnb74qc7UanxFuYyFYORC7+cbArCX8oY8H9x UHVv72YmIoekPcUJF5fCxQLsWHcoeyn3A1RQRTFOUiRYPxcRq41rqawZLK0yALToTIGIqV P8z28Q39bMGr863eCcHCI/aVTZKPFOU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-6i6PZ5d_OEWpORLNbL2wwA-1; Tue, 23 Sep 2025 04:09:44 -0400 X-MC-Unique: 6i6PZ5d_OEWpORLNbL2wwA-1 X-Mimecast-MFC-AGG-ID: 6i6PZ5d_OEWpORLNbL2wwA_1758614983 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-46e19ee1094so15888295e9.0 for ; Tue, 23 Sep 2025 01:09:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758614983; x=1759219783; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sjew5omy6aBEynE/MbLFlpptKr9mVmWrE4MDs78qygI=; b=wbmP9IDlHCJdHPjhiiJWmmrFu2zmSvfbYr2vQe0N1XeXr+rUpwgCBjE5Cg9UQoFxNJ hKQlJzOC5Dn/PBxk70kxBb/m1yBpONbC71RUetZmrLxYATUqCqBvZ12b8UPje6Iy2DQa Y6bHGMQ2YIwqw+GOCEykL2qlU41dIoHhGbM2UqiekOfsIDeG/GCyosKQ65qc9Mu4p+m3 hzuXpyjHgcOtaq3CSIMoky3dyXE53Q8GKtJsutmrsvn8XPJ4uGom5XIxFP4d/OtMrqgv 7YeoFL0ILMKKYQ1Qs+8K+VYkUSapZf5W9/qlg67KipMToqDdo1C1rkO/pxb4XUldKa0C yv4w== X-Forwarded-Encrypted: i=1; AJvYcCVKqflgeiB0aCoAS/lB0s4OvnN6mNS0ZfZlabfiC9g8Y58XZCbgWW+tsYT1gpJv7wXAx1T5OkFArGYicu4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/DHD4tMU6f3yW9+n5YFnL9mhriATYTTqvBpyVmA6BvHt3iuD3 IPRCkuFSPG0Sa2Sfy8SoxuE/c4iZqa1L2z5BpwS6JYw88y3AA/VZLKD+l82VQCsF2hsWGxtrTgr RgE3N7YUG+hBNNJF8Q3mfKSwCkUOBqzTfIjkoiFtZH1/xZ9+kq9JEmrqKS+6CgJrCMw== X-Gm-Gg: ASbGncvQreqgXFNAY7af6Ib1Wib62O9Pis9dC0uCvCOZvXGtaSgENjcpkp3lfPchHQj U85Jr1uouMf613sNBqfCExsKhba3jYjZ3oDwzRguI21HCQK3PVMIY9/5b6T6Fib3Y5MgFFQ8dg+ TWIgOh1NcvPPfUqCLRw8Wheblkwbpm3FzLLod+COdHOuXBTHysSRqPqWxnd2/ixg9ANXMbJ0yC7 vUKsvjQCCsKi8sW1FcMYDxqchmFyshZAzyYUbCWll5lBWI2RfvPs1pZATJnJxunG7Vr7OSNzVGp fcAsVZY6LwYfiSw6ZgK4tHIaMQdcoejCy/r16DGSBY99dFdGS/ydv5TJvMNI4+sMSjgHJSg= X-Received: by 2002:a05:600c:3b93:b0:468:7a5a:725 with SMTP id 5b1f17b1804b1-46e1d975205mr15348265e9.1.1758614983360; Tue, 23 Sep 2025 01:09:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqsDVDKIkEtvPSnkF6zOpO6YZVDfSuoPENxbkDrbFn5kbABwZWCfuv/jwB9uITJNaFWS+ksQ== X-Received: by 2002:a05:600c:3b93:b0:468:7a5a:725 with SMTP id 5b1f17b1804b1-46e1d975205mr15347915e9.1.1758614982971; Tue, 23 Sep 2025 01:09:42 -0700 (PDT) Received: from [192.168.3.141] (p4ff1fd57.dip0.t-ipconnect.de. [79.241.253.87]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3ee1227cc37sm21400826f8f.7.2025.09.23.01.09.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Sep 2025 01:09:42 -0700 (PDT) Message-ID: Date: Tue, 23 Sep 2025 10:09:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 12/16] arm: mm: define clear_user_highpages() To: Ankur Arora , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Cc: akpm@linux-foundation.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, mjguzik@gmail.com, luto@kernel.org, peterz@infradead.org, acme@kernel.org, namhyung@kernel.org, tglx@linutronix.de, willy@infradead.org, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com References: <20250917152418.4077386-1-ankur.a.arora@oracle.com> <20250917152418.4077386-13-ankur.a.arora@oracle.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20250917152418.4077386-13-ankur.a.arora@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17.09.25 17:24, Ankur Arora wrote: > For configurations with CONFIG_MMU we do not define clear_user_page(). > This runs into issues for configurations with !CONFIG_HIGHMEM, because > clear_user_highpages() expects to clear_user_page() (via a default > version of clear_user_pages()). I'm confused. Can you elaborate once more why we cannot take care of that in common code? If it's about clear_user_pages(), then you can just switch from !IS_ENABLED(CONFIG_HIGHMEM) to ifdef in patch #11. -- Cheers David / dhildenb