From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30ADD149E06; Wed, 26 Jun 2024 11:55:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719402949; cv=none; b=jSEM5oUlIQr5uLUmxklG9LcbMUgLST6TU8kLcP9LoJcEePiGn+HsX4k7P72Jo1AmH062RUsteV754Xjnu+8ScBiqEAfCamN/dZ/pFhpkw3RkG3RXBu6oeRWpL//HRlZJleeqZELom71a5J+Vg6SpTEFa/Ahhquj+O8c8F7sxUTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719402949; c=relaxed/simple; bh=LexiWfrYm9DMTWjiLp0N38eu6kBfhX6jtR4dGHx5BGw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rS70o8++YWadrkL59vvgvGY8KB0z4a4qj0IIlj4bh+yhQ/Ejy2RehrlYbpn6p+D+shRZ9+pVmxlD5fcRiF8wNVnb8FcZxU7VxvHAAro+Kf6ueN3j9lzqjCaA9ow1sAZXubGDsb3IqPCpg/7kSM2l/UBTQv8RUvMTNMhvIBCxe5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=JyaYUA9n; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="JyaYUA9n" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1719402937; bh=LexiWfrYm9DMTWjiLp0N38eu6kBfhX6jtR4dGHx5BGw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JyaYUA9nkBmZSDRdAjW37V75tgvL6HDpQUnnlE5tlhaJY8qhmxTR/SmZu+UUfCKSC 8gzuKAs/Jt+5NaAxDi42TNtLN2drIEetNQM2h04lHeUVq52XEFnxCpqQf/kzL0FasW u5ER0d9EzP3YGGdNARwxnz96Rz7e49dK33NWUoZRGvO3uSKEOGkzvCDR40TAyBj83n tE4VnhZwkTDOsM0fFHizpMqcIwl9yU3KAt3DXTSZPsxwhFU2knmvWi4cuk/4mJtKY8 jftckm8tcX0W4+KFTz3fTBfUyQ+7H7GrUD/fFv2i0Y04Y8OaaSTPvzmvQqrbezCgzb WLY1MmjWL/GOg== Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id 9B6AC60078; Wed, 26 Jun 2024 11:55:36 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by x201s (Postfix) with ESMTP id B99592018B3; Wed, 26 Jun 2024 11:55:31 +0000 (UTC) Message-ID: Date: Wed, 26 Jun 2024 11:55:31 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH net-next 2/9] net/sched: cls_flower: prepare fl_{set,dump}_key_flags() for ENC_FLAGS To: Davide Caratti Cc: Ilya Maximets , Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Ahern , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240611235355.177667-1-ast@fiberby.net> <20240611235355.177667-3-ast@fiberby.net> <0fa312be-be5d-44a1-a113-f899844f13be@fiberby.net> Content-Language: en-US From: =?UTF-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Davide, On 6/26/24 10:01 AM, Davide Caratti wrote: > On Wed, Jun 26, 2024 at 11:49 AM Davide Caratti wrote: >> >> So, we must htonl() the policy mask in the second hunk in patch 7,something like: Good catch. > or maybe better (but still untested), use NLA_BE32, like netfilter does in [1] > > [1] https://elixir.bootlin.com/linux/latest/A/ident/NF_NAT_RANGE_MASK Yes, that is better. It should work, as it triggers a htonl() in nla_validate_mask(). -- Best regards Asbjørn Sloth Tønnesen Network Engineer Fiberby - AS42541