From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: "André Draszik" <andre.draszik@linaro.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH 2/3] firmware: exynos-acpm: silence EPROBE_DEFER error on boot
Date: Mon, 17 Mar 2025 10:48:45 +0000 [thread overview]
Message-ID: <d2e162cd-b12b-47e2-9190-2ecce3489b9c@linaro.org> (raw)
In-Reply-To: <638cf070-9fd1-416e-8172-75f189ab0dfe@linaro.org>
On 3/17/25 10:26 AM, Tudor Ambarus wrote:
>
>
> On 3/14/25 4:40 PM, André Draszik wrote:
>> This driver emits error messages when client drivers are trying to get
>> an interface handle to this driver here before this driver has
>> completed _probe().
>>
>> Given this driver returns -EPROBE_DEFER in that case, this is not an
>> error and shouldn't be emitted to the log, so just remove them.
>>
>> Fixes: a88927b534ba ("firmware: add Exynos ACPM protocol driver")
>> Signed-off-by: André Draszik <andre.draszik@linaro.org>
>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
I see you kept the error message though for of_find_device_by_node()
failure. You either get rid of that too, or maybe transform all to dev_dbg?
next prev parent reply other threads:[~2025-03-17 10:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 16:40 [PATCH 0/3] firmware: exynos-acpm: read fix & reduce log verbosity André Draszik
2025-03-14 16:40 ` [PATCH 1/3] firmware: exynos-acpm: fix reading longer results André Draszik
2025-03-17 10:23 ` Tudor Ambarus
2025-03-14 16:40 ` [PATCH 2/3] firmware: exynos-acpm: silence EPROBE_DEFER error on boot André Draszik
2025-03-17 10:26 ` Tudor Ambarus
2025-03-17 10:48 ` Tudor Ambarus [this message]
2025-03-18 20:48 ` André Draszik
2025-03-14 16:40 ` [PATCH 3/3] firmware: exynos-acpm: convert to dev_err_probe() in client API André Draszik
2025-03-17 11:11 ` Tudor Ambarus
2025-03-18 19:23 ` Krzysztof Kozlowski
2025-03-18 20:37 ` André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2e162cd-b12b-47e2-9190-2ecce3489b9c@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=kernel-team@android.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®