From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FB94C433F5 for ; Fri, 24 Sep 2021 09:37:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EB1D61076 for ; Fri, 24 Sep 2021 09:37:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245262AbhIXJjL (ORCPT ); Fri, 24 Sep 2021 05:39:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23223 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245054AbhIXJjK (ORCPT ); Fri, 24 Sep 2021 05:39:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632476257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mVdM8wYZwavHDpZYTAlDU3s7u/oPTSxSJUQT4ioHIjw=; b=VWoBJ7JO8jUrGIj0IhD3rap4OVCM1uZtSLs/KYk9yUG6PiWpdIcEx/qc5D5RDKAUCLmdZR Ula+nPC+4pdP22c2Cn8mhj8UKi35hQgjdmPwR78M4d6n1779Mx7LWRgyrOFqHcpdew8r3q FxJszOjorvo7b8Pz6EIgVwCzSHfSHwE= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-L1zN_1dZN0itJxXLHd5YMA-1; Fri, 24 Sep 2021 05:37:34 -0400 X-MC-Unique: L1zN_1dZN0itJxXLHd5YMA-1 Received: by mail-ed1-f72.google.com with SMTP id n5-20020a05640206c500b003cf53f7cef2so9655278edy.12 for ; Fri, 24 Sep 2021 02:37:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mVdM8wYZwavHDpZYTAlDU3s7u/oPTSxSJUQT4ioHIjw=; b=VTXQczh6599JT0hxlaKn7yg11wjLEs5GZfrdNqtVfJrnl9ji+4TZDkJqtpsSsvR4vE Xr0locf/P8t3N7dX8bvVjYOVh+cqB8p3iveW4XddTw+g980lzZEvb8MtxVCARIrup61B hCEuLZ+4PpHgrcjWrRdAeUwwqPrbDKzVZyOUGtMKnUU4tkA/4eO7TShHZE+3bXkAQT6w Q3ds+xqCpjQ4rWq1ZgwjT0vM3FhX4eEYzL/kVhpHTYcawIaONx68ucY2wz5D4aigeDOq Ajo5wMyRQqD45ft6y0wjU+h6ZX7Om4TvnrCz9WFy/igD05eJsolzI9ZpNRvAUUVjIyFC c2Eg== X-Gm-Message-State: AOAM531sh4gJ+qxYIHpW+XBsX/eN/AvZdN5++NwXWKcn8Ptclh8O5NhO LyZamu+dK53hpUDHK7+qRjkdzSGrCj6HSlkC05O4W6a0gp5kPzmfOUwU1x/DEqmFco60r5goKBi /7N75xTUvObaaSac6z8361ySc X-Received: by 2002:a50:9d0e:: with SMTP id v14mr4043903ede.230.1632476253386; Fri, 24 Sep 2021 02:37:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZkSacCqJL3tWK5hFA76keUa8bWMvZzN8g3OZcTGo6nicS6mBmBx7Xef32GZ++57QFA2Cgvw== X-Received: by 2002:a50:9d0e:: with SMTP id v14mr4043880ede.230.1632476253230; Fri, 24 Sep 2021 02:37:33 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id q6sm4703492eju.45.2021.09.24.02.37.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Sep 2021 02:37:32 -0700 (PDT) Message-ID: Date: Fri, 24 Sep 2021 11:33:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH V3 1/2] KVM: x86/mmu: Verify shadow walk doesn't terminate early in page faults Content-Language: en-US To: Lai Jiangshan , linux-kernel@vger.kernel.org Cc: Sean Christopherson , Lai Jiangshan , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org References: <20210906122547.263316-1-jiangshanlai@gmail.com> From: Paolo Bonzini In-Reply-To: <20210906122547.263316-1-jiangshanlai@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/09/21 14:25, Lai Jiangshan wrote: > Opportunistically use fault->goal-level instead of it.level in > FNAME(fetch) to further clarify that KVM always installs the leaf SPTE at > the target level. This argument will go away when mmu_set_spte starts fishing out the level from the kvm_mmu_page role, but it makes a good point for now. Paolo