From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754780AbeEaLx6 (ORCPT ); Thu, 31 May 2018 07:53:58 -0400 Received: from smtps.newmedia-net.de ([185.84.6.167]:43192 "EHLO webmail.newmedia-net.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754674AbeEaLx4 (ORCPT ); Thu, 31 May 2018 07:53:56 -0400 Subject: Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Timur Tabi , Bjorn Andersson , Linus Walleij , Sasha Levin References: <20180528100240.256525891@linuxfoundation.org> <20180528100302.722883806@linuxfoundation.org> <7c34ccef-2fa8-8b53-2677-29f6fbe71a04@dd-wrt.com> <20180531114553.GB11598@kroah.com> From: Sebastian Gottschall Message-ID: Date: Thu, 31 May 2018 13:53:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180531114553.GB11598@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 31.05.2018 um 13:45 schrieb Greg Kroah-Hartman: > On Thu, May 31, 2018 at 01:21:56PM +0200, Sebastian Gottschall wrote: >> Am 28.05.2018 um 12:05 schrieb Greg Kroah-Hartman: >>> 4.16-stable review patch. If anyone has any objections, please let me know. >>> >>> ------------------ >>> >>> From: Bjorn Andersson >>> >>> [ Upstream commit a7aa75a2a7dba32594291a71c3704000a2fd7089 ] >>> >>> The base of the TLMM gpiochip should not be statically defined as 0, fix >>> this to not artificially restrict the existence of multiple pinctrl-msm >>> devices. >>> >>> Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver") >>> Reported-by: Timur Tabi >>> Signed-off-by: Bjorn Andersson >>> Signed-off-by: Linus Walleij >>> Signed-off-by: Sasha Levin >>> Signed-off-by: Greg Kroah-Hartman >>> --- >>> drivers/pinctrl/qcom/pinctrl-msm.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> --- a/drivers/pinctrl/qcom/pinctrl-msm.c >>> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c >>> @@ -818,7 +818,7 @@ static int msm_gpio_init(struct msm_pinc >>> return -EINVAL; >>> chip = &pctrl->chip; >>> - chip->base = 0; >>> + chip->base = -1; >>> chip->ngpio = ngpio; >>> chip->label = dev_name(pctrl->dev); >>> chip->parent = pctrl->dev; >> this patch creates a regression for me. on ipq8064 the systems gpios now >> start somewhere in the sky >> >> new layout >> >> lrwxrwxrwx    1 root     root             0 Jan  1 00:00 gpiochip373 -> ../../devices/platform/soc/1b700000.pci/pci0001:00/0001:00:00.0/0001:01:00.0/gpio/gpiochip373 >> lrwxrwxrwx    1 root     root             0 Jan  1 00:00 gpiochip408 -> ../../devices/platform/soc/1b500000.pci/pci0000:00/0000:00:00.0/0000:01:00.0/gpio/gpiochip408 >> lrwxrwxrwx    1 root     root             0 Jan  1 00:00 gpiochip443 -> >> ../../devices/platform/soc/800000.pinmux/gpio/gpiochip443 >> >> >> before the patch >> >> lrwxrwxrwx    1 root     root             0 Jan  1  1970 gpiochip0 -> >> ../../devices/platform/soc/800000.pinmux/gpio/gpiochip0 >> lrwxrwxrwx    1 root     root             0 May 31 13:13 gpiochip442 -> ../../devices/platform/soc/1b700000.pci/pci0001:00/0001:00:00.0/0001:01:00.0/gpio/gpiochip442 >> lrwxrwxrwx    1 root     root             0 May 31 13:13 gpiochip477 -> ../../devices/platform/soc/1b500000.pci/pci0000:00/0000:00:00.0/0000:01:00.0/gpio/gpiochip477 >> >> >> this broke my userspace gpio handling. i can override this, but still it >> doesnt look correct since there is a hole at the beginng likelly reserved by >> unused arm gpios > So does this mean that 4.17-rc is also broken for you? If so, this > needs to be reverted there as well. > > Bjorn, any ideas? > > thanks, > > greg k-h i checked initially 4.9 with latest patches and 4.14 and reverted this line to get back to the old behaviour but a which view in the current 4.17 tree shows that the same patch has been included in 4.17. it was introduced in the kernel mainline on 12.feb 2018 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/pinctrl/qcom/pinctrl-msm.c?h=v4.17-rc7&id=a7aa75a2a7dba32594291a71c3704000a2fd7089 >