mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Nam Cao <namcaov@gmail.com>, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
	Larry.Finger@lwfinger.net
Subject: Re: [PATCH 0/7] staging: rtl8723bs: remove dead functions
Date: Fri, 19 Aug 2022 11:06:34 +0200	[thread overview]
Message-ID: <d2f4a83d-6e15-b8ca-0bc6-d3a39915b7ad@redhat.com> (raw)
In-Reply-To: <cover.1660898432.git.namcaov@gmail.com>

Hi,

On 8/19/22 10:52, Nam Cao wrote:
> Remove some functions in this driver because they are not used anywhere.
> 
> Nam Cao (7):
>   staging: rtl8723bs: remove function rtw_odm_dbg_comp_msg
>   staging: rtl8723bs: remove function rtw_get_ch_setting_union
>   staging: rtl8723bs: remove function rtw_odm_ability_set
>   staging: rtl8723bs: remove function GetFractionValueFromString
>   staging: rtl8723bs: remove function IsCommentString
>   staging: rtl8723bs: remove function rtw_odm_adaptivity_parm_msg
>   staging: rtl8723bs: remove function rtw_odm_dbg_comp_set
> 
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 21 -------
>  drivers/staging/rtl8723bs/core/rtw_odm.c      | 44 ---------------
>  drivers/staging/rtl8723bs/hal/hal_com.c       | 55 -------------------
>  drivers/staging/rtl8723bs/include/hal_com.h   |  5 --
>  .../staging/rtl8723bs/include/rtw_mlme_ext.h  |  1 -
>  drivers/staging/rtl8723bs/include/rtw_odm.h   |  4 --
>  6 files changed, 130 deletions(-)

Thanks, the entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans


      parent reply	other threads:[~2022-08-19  9:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19  8:52 Nam Cao
2022-08-19  8:52 ` [PATCH 1/7] staging: rtl8723bs: remove function rtw_odm_dbg_comp_msg Nam Cao
2022-08-19 13:07   ` kernel test robot
2022-08-19 13:49     ` [PATCH v2 0/8] remove some dead code Nam Cao
2022-08-19 13:49       ` [PATCH v2 1/8] staging: rtl8723bs: remove function rtw_odm_dbg_comp_msg Nam Cao
2022-08-22  7:33         ` Dan Carpenter
2022-08-22  7:47           ` Nam Cao
2022-08-19 13:49       ` [PATCH v2 2/8] staging: rtl8723bs: remove function rtw_get_ch_setting_union Nam Cao
2022-08-19 13:49       ` [PATCH v2 3/8] staging: rtl8723bs: remove function rtw_odm_ability_set Nam Cao
2022-08-19 13:49       ` [PATCH v2 4/8] staging: rtl8723bs: remove function GetFractionValueFromString Nam Cao
2022-08-19 13:49       ` [PATCH v2 5/8] staging: rtl8723bs: remove function IsCommentString Nam Cao
2022-08-19 13:49       ` [PATCH v2 6/8] staging: rtl8723bs: remove function rtw_odm_adaptivity_parm_msg Nam Cao
2022-08-19 13:49       ` [PATCH v2 7/8] staging: rtl8723bs: remove function rtw_odm_dbg_comp_set Nam Cao
2022-08-19 13:49       ` [PATCH v2 8/8] staging: rtl8723bs: remove static const variable odm_comp_str Nam Cao
2022-08-19 14:25       ` [PATCH v2 0/8] remove some dead code Hans de Goede
2022-08-19  8:52 ` [PATCH 2/7] staging: rtl8723bs: remove function rtw_get_ch_setting_union Nam Cao
2022-08-19  8:52 ` [PATCH 3/7] staging: rtl8723bs: remove function rtw_odm_ability_set Nam Cao
2022-08-19  8:52 ` [PATCH 4/7] staging: rtl8723bs: remove function GetFractionValueFromString Nam Cao
2022-08-19  8:52 ` [PATCH 5/7] staging: rtl8723bs: remove function IsCommentString Nam Cao
2022-08-19  8:52 ` [PATCH 6/7] staging: rtl8723bs: remove function rtw_odm_adaptivity_parm_msg Nam Cao
2022-08-19  8:52 ` [PATCH 7/7] staging: rtl8723bs: remove function rtw_odm_dbg_comp_set Nam Cao
2022-08-19  9:06 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2f4a83d-6e15-b8ca-0bc6-d3a39915b7ad@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=namcaov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®