From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66FC3C43217 for ; Fri, 18 Nov 2022 16:24:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235312AbiKRQYz (ORCPT ); Fri, 18 Nov 2022 11:24:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231194AbiKRQYw (ORCPT ); Fri, 18 Nov 2022 11:24:52 -0500 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E870764F for ; Fri, 18 Nov 2022 08:24:51 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id u2so7404503ljl.3 for ; Fri, 18 Nov 2022 08:24:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=TyvEqZNJ/MRi1G8+a46Jw9oIBcHIz45goT0ItOFpL6k=; b=AZVccVwGjF3Vxy7sxVUW8prhfRscUTczTjzZe6fpzB+s12ve3OBjdTgsekqRUV3dUY du3wJD+Atk+RcvhaG3hEPj+8BUQlM+jopsSOS2DYixYFbH9ub4f7yKQX8b+2V/moKpg4 Zw+u5UbXccgPVhjzpNoJNUO10H9Th8+JSUmXEsjF9uqeBSdDkKNTaQ9p+yGGwc9Fcu1q jYdNYkwfHy2wg815374Dze6x98QYVcn9z5fRR8h+WkimYLPHnh2je8825+gtKamGn6FK Sss+xcIulhWWFxreh7RKC2LQi2cgf+3tuHUiAZQoiwEG6HPD1pm8p0avBF9aK7ySOgPN Hkzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TyvEqZNJ/MRi1G8+a46Jw9oIBcHIz45goT0ItOFpL6k=; b=ToCw7tvtKykmAbpbL+Q75TuKbt1CGR4ZkWqIkFnIQ0SXBXD4unaxYAYdlWSxATmc2T tFyBCAvmMyUas8KYokro4JdhT0RfG980CbBmfy8WFsantZirpssRoNR2qGAHE6ta4XmO UJD7fbCP4SU5CfCtksydP/hpQ6d6KLHotIUQrBvCTQyjqr6v71067b8/B74m5e7Ni2p6 KgFxzPhXoXGRfoxEwSy4ZfUtsfwBggox4Jr3S+8Kb2TTD7oHoRtm/GYOA8CsvJnvh2qj CbEzuzfSCfB1iQ1m42l6KFp7wkOKloDCpwSI9hTRpGdBa8MVXhbkX96hWtJXU3NnWI5A Kyuw== X-Gm-Message-State: ANoB5ploc6tM/3F0LKOPTtaCR/tdewkW0F20X3mmQHxDAYxFh6wu9Ycy Rxrrz8MLEzQku3gDUm4FqgnPaw== X-Google-Smtp-Source: AA0mqf4rJCEmefb/9vbDfhMOh/I4HZfeXCgo54yyLoE8CtCIOwEz8eHs4DpWhU8WfEwaQUk5zP+9WQ== X-Received: by 2002:a2e:bd0c:0:b0:277:10c2:e7ce with SMTP id n12-20020a2ebd0c000000b0027710c2e7cemr2918150ljq.370.1668788689586; Fri, 18 Nov 2022 08:24:49 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id t7-20020a056512030700b004979ec19380sm714550lfp.285.2022.11.18.08.24.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 08:24:49 -0800 (PST) Message-ID: Date: Fri, 18 Nov 2022 17:24:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/4] dt-bindings: pinctrl: qcom: Add SM8550 pinctrl bindings From: Krzysztof Kozlowski To: Abel Vesa , Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring Cc: Linux Kernel Mailing List , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, "linux-gpio@vger.kernel.org" References: <20221116105724.2600349-1-abel.vesa@linaro.org> <20221116105724.2600349-2-abel.vesa@linaro.org> <368cd281-b461-e668-0b57-cbb83f5b8086@linaro.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/11/2022 17:10, Krzysztof Kozlowski wrote: >>> + >>> + "^.+-hog(-[0-9]+)?$": >>> + type: object >>> + properties: >>> + gpio-hog: true >>> + gpios: true >>> + input: true >>> + output-high: true >>> + output-low: true >>> + line-name: true >> >> Keep properties sorted by name (just like gpio-hog.yaml). >> >> I wonder if we could add this to the common TLMM schema. It will appear >> in multiple places. > > Answering to myself - this would require moving the 'state' > patternProperties part to the common schema, so maybe later... Looks > fine with changes about ordering. If Rob likes my solution here: https://lore.kernel.org/linux-arm-msm/20221118162101.145267-1-krzysztof.kozlowski@linaro.org/T/#u then please go with similar way. It allows to skip listing the properties. Best regards, Krzysztof