mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: blake.alexander@airbus.com
Cc: Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: do not override PHYIDs on external MDIO
Date: Thu, 19 Nov 2026 16:19:04 +0100	[thread overview]
Message-ID: <d2feec60-232b-4aeb-9da2-8912dc9ee6ef@lunn.ch> (raw)
In-Reply-To: <20261119-mv88e6xxx-fix-v1-1-2db604f3516f@airbus.com>

On Thu, Nov 19, 2026 at 11:50:00AM +0100, Blake Alexander via B4 Relay wrote:
> From: Blake Alexander <blake.alexander@airbus.com>
> 
> Some variants of the Marvell 88E6xxx family (such as MV88E6390) support
> an external MDIO bus (in addition to the internal MDIO bus for
> configuring internal PHYs). A typical use-case for the external bus is
> to configure PHYs that are external to the switch. On switches that do
> not assign a PHYID for internal PHYs (i.e. the value is 0), the
> mv88e6xxx_mdio_read() function traps read calls to the PHYID registers
> and sets the PHYID equal to the family ID of the switch.
> 
> The mv88e6xxx_mdio_read() function is reused for both internal and mdio
> bus operations. The PHYID overwrite trap does not check whether the MDIO
> bus is internal or external and wrongly modifies the PHYID of devices on
> the external bus when their PHYID2 register reports a value of 0. When a
> C22 device reports a PHYID of 0, get_phy_device() will reprobe the
> device as C45 and if successful create a C45 device. Overriding the
> PHYID in this case will prevent a C45 device (such as Aquantia AQR115)
> from being reprobed and their driver will fail to bind.

Ah, my bad. I added this code. I did not think an external PHY would
return 0. But at that time, C22 PHYs dominated.

> This was observed on a development board during the bring-up phase. The
> board included an MV88E6393X with external AQR115 PHYs.

We probably have not seen this before because most Marvell switches
are paired with Marvell PHYs.

> Fixes: da9f33018e2c ("net: dsa: mv88e6xxx: Workaround missing PHY ID on mv88e6390")
> Cc: stable@vger.kernel.org
> Signed-off-by: Blake Alexander <blake.alexander@airbus.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

      reply	other threads:[~2026-11-19 15:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 10:50 Blake Alexander via B4 Relay
2026-11-19 15:19 ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2feec60-232b-4aeb-9da2-8912dc9ee6ef@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=blake.alexander@airbus.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®