From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B0FC433F5 for ; Tue, 12 Apr 2022 13:13:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352527AbiDLNP6 (ORCPT ); Tue, 12 Apr 2022 09:15:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355783AbiDLNNW (ORCPT ); Tue, 12 Apr 2022 09:13:22 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F0B46A9 for ; Tue, 12 Apr 2022 05:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649768184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fKGY79qeJkiZPEmiUhd4p41YrGI5Je/IzqvYghVlks4=; b=JgnLxN17bYza845u/zoiL3tMPrxJscVHPtm9xXzK4YNRqZCJbUfBqlKGDGDGmfziEVzr9E uY0jmT0oAi8PDKGRrm95UwtN8FJ4Ec9ypPluRbtw0yKEeoL09GAi5qOQT+IXd1zxl4rOmD 8+0qcHC0q56DefF3uXP7Xj9YOu8Llx0= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-249-5mibjntWPGmzDU3VsBJ5Wg-1; Tue, 12 Apr 2022 08:56:23 -0400 X-MC-Unique: 5mibjntWPGmzDU3VsBJ5Wg-1 Received: by mail-qt1-f198.google.com with SMTP id o17-20020ac872d1000000b002edcca4ce06so4205894qtp.7 for ; Tue, 12 Apr 2022 05:56:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=fKGY79qeJkiZPEmiUhd4p41YrGI5Je/IzqvYghVlks4=; b=v9hQdKaqHNmvC1pdNa5cOVLKIR+xw0Czn13X8Q9j4Ishiawhgoppu9cRakjep/9wmh bBoyw9zx+wt/I1qn68K9ubWD0hyLYhOVTkIl+qCAm/HQUwPW85ts8XGw4GNPX7YJKoEl t2gmapzqiHKfvgb/3S1fKLhHZ5hBYd8wJmlGZ69mugHeytaERRtOVKgQ51pz58abSJAT nqM+vG/g2HUzBvuLKSzaHnxFZeIk+u0wzPUNDFJa+ffTQIgfHAgtpdn4ugm0dPcT/BQX ZCvQzgyMzFWkdBotvbkxGR2i9xrG6urAOKaYVgmFknKKWXJUOjPZeXfvqlez6n6AKYvF RLwQ== X-Gm-Message-State: AOAM531PVdvXCO5kS3v4zBbRHSAOTIX2TzqtOAF1DfuU5dEhbqF5TtAz hnsL+OVenT1ts7Mg1wFAnQd/0kOv7HF2vKUnap/NYkcpUN92yCz9xaPOF7M6vhAHUw00BJG17SY E5x07Ff558ZbQqek7ywNzSyQO X-Received: by 2002:a05:6214:20e6:b0:440:f6d0:fe55 with SMTP id 6-20020a05621420e600b00440f6d0fe55mr31833047qvk.57.1649768183319; Tue, 12 Apr 2022 05:56:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfGzch4mtv0CtgEFK5dNCfGzrVh3HY2NYysAp6bl6G8/cDuBO5Qvh7If1QbYl5wRAYXhjOTw== X-Received: by 2002:a05:6214:20e6:b0:440:f6d0:fe55 with SMTP id 6-20020a05621420e600b00440f6d0fe55mr31832990qvk.57.1649768183030; Tue, 12 Apr 2022 05:56:23 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-96-237.dyn.eolo.it. [146.241.96.237]) by smtp.gmail.com with ESMTPSA id j19-20020a05622a039300b002ecc2ebfd87sm10430205qtx.32.2022.04.12.05.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 05:56:22 -0700 (PDT) Message-ID: Subject: Re: [PATCH net-next v2 05/18] net: dsa: mv88e6xxx: remove redundant check in mv88e6xxx_port_vlan() From: Paolo Abeni To: Jakob Koschel , "Russell King (Oracle)" Cc: "David S. Miller" , Jakub Kicinski , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Ariel Elior , Manish Chopra , Edward Cree , Martin Habets , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Jiri Pirko , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Casper Andersson , Colin Ian King , Arnd Bergmann , Michael Walle , Christophe JAILLET , Eric Dumazet , Xu Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, bpf@vger.kernel.org, Mike Rapoport , Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." , Vladimir Oltean Date: Tue, 12 Apr 2022 14:56:15 +0200 In-Reply-To: <8BAFAAD1-D9AB-4339-BE81-18BE564F78F6@gmail.com> References: <20220412105830.3495846-1-jakobkoschel@gmail.com> <20220412105830.3495846-6-jakobkoschel@gmail.com> <8BAFAAD1-D9AB-4339-BE81-18BE564F78F6@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-04-12 at 13:37 +0200, Jakob Koschel wrote: > > > On 12. Apr 2022, at 13:27, Russell King (Oracle) wrote: > > > > On Tue, Apr 12, 2022 at 12:58:17PM +0200, Jakob Koschel wrote: > > > We know that "dev > dst->last_switch" in the "else" block. > > > In other words, that "dev - dst->last_switch" is > 0. > > > > > > dsa_port_bridge_num_get(dp) can be 0, but the check > > > "if (bridge_num + dst->last_switch != dev) continue", rewritten as > > > "if (bridge_num != dev - dst->last_switch) continue", aka > > > "if (bridge_num != something which cannot be 0) continue", > > > makes it redundant to have the extra "if (!bridge_num) continue" logic, > > > since a bridge_num of zero would have been skipped anyway. > > > > > > Signed-off-by: Jakob Koschel > > > Signed-off-by: Vladimir Oltean > > > > Isn't this Vladimir's patch? > > > > If so, it should be commited as Vladimir as the author, and Vladimir's > > sign-off should appear before yours. When sending out such patches, > > there should be a From: line for Vladimir as the first line in the body > > of the patch email. > > yes, you are right. I wasn't sure on how to send those commits, but > I guess if I just set the commit author correctly it should be fine. > > regarding the order: I thought I did it correctly doing bottom up but > I confused the order, wasn't on purpose. Sorry about that. > > I'll resend after verifying all the authors and sign-offs are correct. whoops, too late... Please, do wait at least 24h before reposting, as pointed out in the documentation: https://elixir.bootlin.com/linux/v5.18-rc2/source/Documentation/process/maintainer-netdev.rst#L148 Thanks, Paolo