From: Maulik Shah <maulik.shah@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Ulf Hansson <ulfh@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: power: domain-idle-state: Add system-state
Date: Tue, 17 Nov 2026 10:34:52 +0530 [thread overview]
Message-ID: <d3060950-04ea-4f9b-b160-0e068946e623@oss.qualcomm.com> (raw)
In-Reply-To: <20261116-icy-free-lionfish-c3eed8@quoll>
On 16-11-2026 17:28, Krzysztof Kozlowski wrote:
> On Fri, Nov 13, 2026 at 10:25:25AM +0530, Maulik Shah wrote:
>> Some domain idle states require system-wide coordination and are not
>> applicable while the platform is up and running.
> You repeated the property description. Say something more. Why they are
> not applicable when platform is running? So if not running, when are
> they applicable? Why?
On certain platforms CPU subsystem deepest idle state requires co-ordination with SAIL subsystem
such that both must be powered down in coordinated sequence. During wakeup SAIL subsystem must
be powered up before CPU can resume. The wakeup can take a second or more.
Selecting this state during opportunistic CPU idle can therefore cause substantial wakeup delays and
repeatedly interrupt SAIL operation whenever the CPUs become idle.
Add system-state property to describe the state is reserved for system wide suspend.
I will update same in v3.
>
>> Add a boolean system-state property to describe these states.
>>
>> Acked-by: Kevin Hilman <khilman@baylibre.com>
>> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
>> ---
>> .../devicetree/bindings/power/domain-idle-state.yaml | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/power/domain-idle-state.yaml b/Documentation/devicetree/bindings/power/domain-idle-state.yaml
>> index 4dd4f59bbbec..b19952f6225d 100644
>> --- a/Documentation/devicetree/bindings/power/domain-idle-state.yaml
>> +++ b/Documentation/devicetree/bindings/power/domain-idle-state.yaml
>> @@ -45,6 +45,12 @@ patternProperties:
>> state will yield power benefits, after overcoming the overhead while
>> entering the idle state.
>>
>> + system-state:
>> + description:
>> + When present, this state requires system-wide coordination and is
>> + not applicable while the platform is up and running.
> So when is it applicable if not when up and running?
I will update in v3.
Thanks,
Maulik
next prev parent reply other threads:[~2026-11-17 5:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 4:55 [PATCH v2 0/3] pmdomain: Support system-suspend-only domain idle states Maulik Shah
2026-11-13 4:55 ` [PATCH v2 1/3] dt-bindings: power: domain-idle-state: Add system-state Maulik Shah
2026-11-16 11:58 ` Krzysztof Kozlowski
2026-11-17 5:04 ` Maulik Shah [this message]
2026-11-13 4:55 ` [PATCH v2 2/3] pmdomain: Add support for system-suspend-only states Maulik Shah
2026-11-13 4:55 ` [PATCH v2 3/3] arm64: dts: qcom: monaco-evk: Add suspend-only power collapse state Maulik Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3060950-04ea-4f9b-b160-0e068946e623@oss.qualcomm.com \
--to=maulik.shah@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@oss.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®