From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BE6BC83F1A for ; Tue, 29 Aug 2023 16:56:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237565AbjH2Qz3 (ORCPT ); Tue, 29 Aug 2023 12:55:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237628AbjH2QzY (ORCPT ); Tue, 29 Aug 2023 12:55:24 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9968C1B9 for ; Tue, 29 Aug 2023 09:55:20 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-52a40cf952dso6148179a12.2 for ; Tue, 29 Aug 2023 09:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693328119; x=1693932919; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3BpJgivS3dlGuz7t1+9iCEke02uZzCJ683AvwGIuOoo=; b=tmGtO8ZTCn9K5zClsMbwhH/hKL3nvRuCXYjKmcjwde5Wwp78tv7UrrrXnc81b4MW21 pURng7CBFFmptMmXxVGEalJfHtBIzDcPgRXVL+e/Myfsu095i34PWzY+BhIKQDDz7aax lTCspFt/UKeML95+kyrbtwqlGOFsEc6z2WlbMNlreIy4nNJCqxzC6bnkr1IXaVqtMc5e tawyC/68XUzeyaYUbRtp2oT7uq8z31mfckmw39E4NV5mnfwbLlBUP18DlzKS5gcKs+G+ ApGPLCnqGczjxCqDmL+wGJEmPxL6kzAbPCJ1zxvgZRXMTdOdz5p5peSp9A2WkA4ciCQu ShFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693328119; x=1693932919; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3BpJgivS3dlGuz7t1+9iCEke02uZzCJ683AvwGIuOoo=; b=K0kccvK5HhkkjseilGAcXizvfPddcRFOYjrjusYBZP3iqf4N8y75HLlhBsKNSCrCLl Emg5Up13JMrH5BQhEK8Rx7SArysBW6dWiuxH3Cjb27tV2c18XHZT+M53kp0wjK68o8jH WqlxY0zCdvPKp6WMbUXS2FavRUELv+FOz/2uz/XldbFoIPav1YJC8ltzohzcfGHUCr+i sxCDib4w7c9E2pgeXY/EsSxUW9Zt3gwqfq/Nf+w4mnQB2Qsk9fl9RV6+swSRwYGxfxJt qutIXgq6bBZ3LBYxM1tdPvarkJaCmOI8XKVGkUk9kxwVceBhjuH4Oumo/LKBAWuM9sEW 8HsA== X-Gm-Message-State: AOJu0YyikYI7cebvkDhTzBdpKVZOZ/1dVKl4tS+kE/g2bs63Y4wW6WF+ B8yRJ2ATfu/lER5xO4Ry3XzFbw== X-Google-Smtp-Source: AGHT+IF0hK7L2NbSch0GNoms7PJA7260zSeTpFfKq5naoZ4uA3lJ3h0h8FizIDcR0esq873qWjKw+g== X-Received: by 2002:a50:ef0d:0:b0:52a:250e:a04a with SMTP id m13-20020a50ef0d000000b0052a250ea04amr15569445eds.7.1693328118928; Tue, 29 Aug 2023 09:55:18 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.196]) by smtp.gmail.com with ESMTPSA id r9-20020aa7da09000000b005236b47116asm5860050eds.70.2023.08.29.09.55.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Aug 2023 09:55:18 -0700 (PDT) Message-ID: Date: Tue, 29 Aug 2023 18:55:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/9] phy: qcom: uniphy: Rename ipq4019 USB phy driver to UNIPHY driver Content-Language: en-US To: Praveenkumar I , robert.marko@sartura.hr, luka.perkov@sartura.hr, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, arnd@arndb.de, geert+renesas@glider.be, nfraprado@collabora.com, rafal@milecki.pl, peng.fan@nxp.com, quic_wcheng@quicinc.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: quic_varada@quicinc.com References: <20230829135818.2219438-1-quic_ipkumar@quicinc.com> <20230829135818.2219438-3-quic_ipkumar@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230829135818.2219438-3-quic_ipkumar@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/08/2023 15:58, Praveenkumar I wrote: > UNIPHY / Combo PHY used on various qualcomm SoC's are very similar to > ipq4019 PHY. Hence renaming this driver to uniphy driver and can be > used for other SoC's which are having the similar UNIPHY. > > Signed-off-by: Praveenkumar I > --- > MAINTAINERS | 7 ++++--- > drivers/phy/qualcomm/Kconfig | 7 ++++--- > drivers/phy/qualcomm/Makefile | 2 +- > .../qualcomm/{phy-qcom-ipq4019-usb.c => phy-qcom-uniphy.c} | 0 > 4 files changed, 9 insertions(+), 7 deletions(-) > rename drivers/phy/qualcomm/{phy-qcom-ipq4019-usb.c => phy-qcom-uniphy.c} (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ff1f273b4f36..7f4553c1a69a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -17774,13 +17774,14 @@ F: Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml > F: drivers/mailbox/qcom-ipcc.c > F: include/dt-bindings/mailbox/qcom-ipcc.h > > -QUALCOMM IPQ4019 USB PHY DRIVER > +QUALCOMM UNIPHY DRIVER > M: Robert Marko > M: Luka Perkov > +M: Praveenkumar I > L: linux-arm-msm@vger.kernel.org > S: Maintained > -F: Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml > -F: drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c > +F: Documentation/devicetree/bindings/phy/qcom,uniphy.yaml You broke the path in your previous commit, but anyway this will go away. > +F: drivers/phy/qualcomm/phy-qcom-uniphy.c > > QUALCOMM IPQ4019 VQMMC REGULATOR DRIVER > M: Robert Marko > diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig > index d891058b7c39..e6981bc212b3 100644 > --- a/drivers/phy/qualcomm/Kconfig > +++ b/drivers/phy/qualcomm/Kconfig > @@ -28,12 +28,13 @@ config PHY_QCOM_EDP > Enable this driver to support the Qualcomm eDP PHY found in various > Qualcomm chipsets. > > -config PHY_QCOM_IPQ4019_USB > - tristate "Qualcomm IPQ4019 USB PHY driver" > +config PHY_QCOM_UNIPHY > + tristate "Qualcomm UNIPHY driver" > depends on OF && (ARCH_QCOM || COMPILE_TEST) > select GENERIC_PHY > help > - Support for the USB PHY-s on Qualcomm IPQ40xx SoC-s. > + Enable this driver to support the Qualcomm UNIPHY found in various > + Qualcomm chipsets. I don't quite get why this is renamed, either. Just because you re-use it? Re-usage is not affected with old name... Best regards, Krzysztof