From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010000.outbound.protection.outlook.com [52.101.201.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2196E39F19E for ; Tue, 19 May 2026 20:00:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.0 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779220840; cv=fail; b=j13WxBXP5+/9nZb8Qm3b5kmzGDtAxX7c+hCqG3wIQfUW9Cf1wvJHwqFLhv6bCT4b8DI//7ggNINOoHiH6X0wOGMMR8jSxb6rItvMkxh4/O+zhxX2fC0E/TrnCp9LNuoqRSUdfhWnGmLYID+Lg/U9DwlJ974M+vO8nzL1lGNDmms= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779220840; c=relaxed/simple; bh=d2k7BRH1eCwz2nxoN5Qa9rtats/l9qfM0Raw6BLy7zY=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=rAKfWJq/THTQW8FNN5QU3BFcthEiGsYiZh2Y9NY2GcysVL7Yp756Uilm4QTV4oeWH0lSCWmjE0obKuJh9Pe7I++4V8WH8wkc06k1kujUHgtL7aro3tIM5N23BP6Qe6PHy9LsuVev8yI0YNQXZ9TMrUGEhemHDy0bm3C3mn4OB3Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=pioQ2Gca; arc=fail smtp.client-ip=52.101.201.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="pioQ2Gca" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oMAHrl9f9ZJDsVKVaHdU2YECBIvHbSZ2nq2WMBrH9gyonkJHSlx7SRkshr4u0a3CYzerjQxxvT++vZib0HmhYBpmfP8nN15CKtqyImZdW7wATLGAdr/75icU0scxE5lHFXupuAlOimioEZocwPZWi0VKLBNxAnwANBtt/fqTfpuzTFd7wHUGKDFfBF/Yfx46V7ShCpb1k3Oxi8cR6AftSIVu6RfMY/QT8mv2AZUIxqcG9S6ARbm2pb90IOM+N23z35rz5bBkDjHsNDYQJgu7tyObn4O7bL2TsbtRMHyOnvO2j3Ls3sfDpzxQH8ZsNb6OsMhF7lWvQvOzO3lhk21UxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z8GYuu1x4SNxNx8CDP0ahmlc52Zb8rQnlGxKjb12/3M=; b=GOJBOuMxQ/Wdzp1p9l++N1QctUpFj2IDp+xb0U1IAT/1OFR78M559VCKvWcsQwzDc4LpC2/fLz0m04WpkGlOsqc7s0mYkubFEsgV20CUtnFqjq5pL4io3gjAbN5saNk8xBYD7T0ldcHfjuQFzmPBW1CK/B+ytrk26exuuAuWHMFOqQYedKz2axQLoqjEWpotyINERpRDt7JeKisPPwT2bgyG9UhToIqV95YE+FQKsoxq9RYodCQEkQHJu0M9GPwXGgxMrSEq7Di2tqUsfCjy1rDBmPD6nmdV1kknpg4qPMX8VwuQmCKQ37GPvOeWgMMxADIKDwnCBKXE7PDrcW1lQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z8GYuu1x4SNxNx8CDP0ahmlc52Zb8rQnlGxKjb12/3M=; b=pioQ2GcaPrvrihD5EFfZ1gMYgIk08Q+QzQMB9sAEOS0QO4G4GB9CxFaGWLQDkLsXNvJav6/jbiXoWwSI/RPB9TgbO/sZYmyUouYQRxdPNzldhihhXfRojdtVhE4r2JNQxEVoT1CmS0M785HYjABTPX3nKAXU0w3+li24GAX3vBE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5070.namprd12.prod.outlook.com (2603:10b6:5:389::22) by PH7PR12MB8426.namprd12.prod.outlook.com (2603:10b6:510:241::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.14; Tue, 19 May 2026 20:00:35 +0000 Received: from DM4PR12MB5070.namprd12.prod.outlook.com ([fe80::f3f2:852c:78d5:9353]) by DM4PR12MB5070.namprd12.prod.outlook.com ([fe80::f3f2:852c:78d5:9353%4]) with mapi id 15.20.9870.023; Tue, 19 May 2026 20:00:34 +0000 Message-ID: Date: Tue, 19 May 2026 15:00:32 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/sev: Remove redundant ghcbs_initialized checks around __sev_{get,put}_ghcb() To: Nikunj A Dadhania , linux-kernel@vger.kernel.org, bp@alien8.de Cc: dave.hansen@linux.intel.com, tglx@kernel.org, mingo@redhat.com, hpa@zytor.com, x86@kernel.org References: <20260518102230.3394603-1-nikunj@amd.com> Content-Language: en-US From: Tom Lendacky Autocrypt: addr=thomas.lendacky@amd.com; keydata= xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAmkbaKgFCRZQah8ACgkQ 3v+a5E8wTVPFyg//UYANiuHfxxJET8D6p/vIV0xYcf1SXCG78M+5amqcE/4cCIJWyAT3A1nP zwyQIaIjUlGsXQtNgC1uVteCnMNJCjVQm0nLlJ9IVtXxzRg0QKjuSdZxuL5jrIon4xW9hTJR 94i2v3Fx5UWyP2TB6qZOcB0jgh0l01GHF9/DVJbmQlpvQB4Z1uNv09Q7En6EXi28TSv0Ffd1 p8vKqxwz7CMeAeZpn5i7s1QE/mQtdkyAmhuGD12tNbWzFamrDD1Kq3Em4TIFko0+k5+oQAAf JFaZc1c0D4GtXwvv4y+ssI0eZuOBXapUHeNNVf3JGuF6ZPLNPAe5gMQrmsJinEArVYRQCuDA BZakbKw9YJpGhnSVeCl2zSHcVgXuDs4J2ONxdsGynYv5cjPb4XTYPaE1CZH7Vy1tqma8eErG rcCyP1seloaC1UQcp8UDAyEaBjh3EqvTvgl+SppHz3im0gPJgR9km95BA8iGx9zqDuceATBc +A007+XxdFIsifMGlus0DKPmNAJaLkEEUMedBBxH3bwQ+z8tmWHisCZQJpUeGkwttD1LK/xn KRnu8AQpSJBB2oKAX1VtLRn8zLQdGmshxvsLUkKdrNE6NddhhfULqufNBqul0rrHGDdKdTLr cK5o2dsf9WlC4dHU2PiXP7RCjs1E5Ke0ycShDbDY5Zeep/yhNWLOwU0EVo1liQEQAL7ybY01 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+ LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe /5rkTzBNUwUCaRto5wUJFlBqXgAKCRDe/5rkTzBNUw4/EAClG106SeHXiJ+ka6aeHysDNVgZ 8pUbB2f8dWI7kzD5AZ5kLENnsi1MzJRYBwtg/vVVorZh6tavUwcIvsao+TnV57gXAWr6sKIc xyipxRVEXmHts22I6vL1DirLAoOLAwWilkM+JzbVE3MMvC+cCVnMzzchrMYDTqn1mjCCwiIe u5oop+K/RgeHYPsraumyA9/kj8iazrLM+lORukCNM7+wlRClcY8TGX+VllANym9B6FMxsJ5z Q7JeeXIgyGlcBRME+m3g40HfIl+zM674gjv2Lk+KjS759KlX27mQfgnAPX4tnjLcmpSQJ77I Qg+Azi/Qloiw7L/WsmxEO5ureFgGIYDQQUeM1Qnk76K5Z3Nm8MLHtjw3Q7kXHrbYn7tfWh4B 7w5Lwh6NoF88AGpUrosARVvIAd93oo0B9p40Or4c5Jao1qqsmmCCD0dl7WTJCboYTa2OWd99 oxS7ujw2t1WMPD0cmriyeaFZnT5cjGbhkA+uQGuT0dMQJdLqW3HRwWxyiGU/jZUFjHGFmUrj qFAgP+x+ODm6/SYn0LE0VLbYuEGfyx5XcdNnSvww1NLUxSvuShcJMII0bSgP3+KJtFqrUx9z l+/NCGvn/wMy6NpYUpRSOmsqVv0N71LbtXnHRrJ42LzWiRW2I5IWsb1TfdMAyVToHPNaEb0i WiyqywZI5g== In-Reply-To: <20260518102230.3394603-1-nikunj@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR08CA0008.namprd08.prod.outlook.com (2603:10b6:610:5a::18) To DM4PR12MB5070.namprd12.prod.outlook.com (2603:10b6:5:389::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5070:EE_|PH7PR12MB8426:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ef61d4a-2eee-43f0-b8b5-08deb5e149b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|3023799007|11063799006|56012099003|22082099003|18002099003|5023799004; X-Microsoft-Antispam-Message-Info: 33Xje95fwmakjJ3L5+RJGYpou5nCYXVcQSncT4FeTXd5cqQ7h9+Cun+j91hfVKnr8hpJIevF9qW6MQQw0OQ2CUFuxEJTrqdkUrtS6Le50A2IGJF2BkbPQO/evb19c4HFc9E8gYP6gultfIdqMH4/L6xeMXadpVaL9590Qetq/NEvTMF9IPBSjlix0gOhJ3uiELDg5EKVNBaemt25kuGpfitLz2zMo9ueRTVPFY8sUptzbQjHJusfhWbZUoagcborMBCmvpBtm9nIkoHgUw/qe4RGxcMe4Y5nldoHsv15TkOhZqLmOOl7UHWyC4qGt1eodaLfkZ1rabwu1aiYrwgNgAooKYm3SPBhhXYyUNwGw7HAjAIo3wxBPaplvnG20B8NpBoBibyIbtv4yKBvwOWMIVQ1vTCpLq/Yyp2Z0VYZWTMahKpz7dTr5SPtOHaCYY6ZXHd/WH7beJVvzjcMqK2kD+Fs9WFte3ZXAMJVndCKg+17FNOEKdL2F0cMoOFh80jE24EReH6h68uKIcTJa9VpgOun4nh22dEpsyRXdYKSNO5UJ++7CPjMQbFbbHMsBqF/jt4f/4ycx+y5+SeOu0NMt18iBJia7IM7NNUcjoyH0wluGdrPLbrJ2Qr6eRZdQiOch+1//KG3PF81mn1FL5VecwUlHRorzKZAnJofX/xPACcB4hlk1WJEspVM/VNSuWml X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5070.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(3023799007)(11063799006)(56012099003)(22082099003)(18002099003)(5023799004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0FYK0tXdTJWN3pPazNyTWx6VExTdDZmVDNkUVkwL2NVV2UwTzZ1UFgrdUht?= =?utf-8?B?ZWpYcVJlVmsveEVZb2w5OGNPOHVBc2ZVWjA4cExYaHlJNmtUaWlJUFlkRnYz?= =?utf-8?B?RUViU1E1RXlnb0Q2NTBHYnJmUldiTS9kUnpzbFA5RUZNZjVEWXBIWUw5TmNv?= =?utf-8?B?a3draWNJUlVrR205M25kVFhpSUdGNmFHbXJSN1JPT0hTSlFUSWIxVHAxY3hD?= =?utf-8?B?ODFLSFdIWjI4RzMxaUZJV2JsS3hzVEwyaUE1cW5STWg3VlpJc1VvM21BWFpS?= =?utf-8?B?MEZPRnBkbFg3WTZ1QWl2U2puU09haGUwcFNBUCt4TW1uT1JGcEZ3TlNUUzJR?= =?utf-8?B?bktjYXFRWjMrSE9hU3VSM1dnSERmSEQzeDlPcUtSdkhZWXI4YWlHSjFGdElz?= =?utf-8?B?b2JXVFZ2ZzhveWF1S3Z1N0RuZ1ZaZ21aMkV0Y2pOM2xjMk1VV0RHYmlmRmdC?= =?utf-8?B?ZHgyaHpYNHZmbkl5bms0dytMNzNyVXB5U3RCUnZ2N3gxd1BUeU83anczcWIv?= =?utf-8?B?N1RDVldYM3JKTTNZblFUb2kwckJ4eEF5YVQxeFc3V1VqYmhWM2FqaGJqTjU1?= =?utf-8?B?dnRuNm8zV0ZGRXUwdjVJK0tobTNqZWljYllseHdpK1BvNFEyU0poSld1R0or?= =?utf-8?B?VG1pQW9ZcisvS0ppajV6NFg1Z3Y1a2JPVmtTQUhaUWJzT250RHZFTjloSlV1?= =?utf-8?B?Q1BZeTduNlZYOWJJT1J1SFNXVSt2ZEo0R2t4UkZLUlh2UGNKQWZNeEp6R1pB?= =?utf-8?B?bVdtc1IvNnhmVVlGaW1tZ0w2TTNBU0tjSUVITEU5YkUrckZveVlHY1JoMFFs?= =?utf-8?B?R2E3VmxjTnVTMkk4ZDg1S2pMNGZrUjBTZVBaWFJLcnJZUlhqZTlkbGZ1N2tv?= =?utf-8?B?T1cwZjY0UjV2K043bkxFQ0xvTmxBb1lUVDBGQ25pclBaaE4wZ2JDSm5nWjkx?= =?utf-8?B?eWZNRGpIOTl2Tkw4TWxLSVZSd3RLMEZpVkJ0MDJ3dG1zeURoL2dTZjZpSHFO?= =?utf-8?B?Q2NndmRIc2RxWW0xSVd5djc5ZmJ5QmV5MTBORDNlbnFxelFhS3VLOVlNME5q?= =?utf-8?B?c1VRS1VnNWhPUlprVWdHM0ZkWkxGSXQyYVZsd0xtSmZRSDRxMVpUT2E0dGV6?= =?utf-8?B?NGh3ZWZMWXVNVnpCQytKV0JDSGNwM1FVTEtTS0t1ZzErZ2pyd2IyNDZVd0R1?= =?utf-8?B?bTFNMUhSRWRPeXRFQklDQnVsdFQxT0lmaThralFVQ0ZmY1pXSFhJaC8yM0do?= =?utf-8?B?cW1mTGUvN0VUeGcveTZpZlc4U0lzRmUzSlFab1lRVDMxa0dSQ1NicjlVa0E2?= =?utf-8?B?WG9LaVdLVTl3UWp6N2NIV3dHbk5SMFhIMmlxaW54V3VuUktMZUFRWWl1OFRN?= =?utf-8?B?TklHeWx2NGxUN1ZsMkdFcEt1RzBYc0dnRzExUm1OemZQQ2pYZGpiN0owZmdR?= =?utf-8?B?QVkwTlpXVW10VGF1T2pCYnBXQnk4M3UzSjdDWXVpWmNSRXhwZW9meGZWUHpy?= =?utf-8?B?b2dmTVVwZC9xMXltZUNRbWZwbU8yZTBYM2dPc0s1MnBVcVBUK3pzQ2U1Z2Jt?= =?utf-8?B?RWo5UHJ1eTZIbVNVUkwzNHdvVTY1c2h5ZlBLb0tWRFBCZzljUThyRzhQd1ZN?= =?utf-8?B?a0tISEJnT1I0ZTBRcWtsejI2SjZYa3UvRkd3S1llVG5lblluQ2VLcXJsY2Zv?= =?utf-8?B?Z3NDaG4xV0pBRWUyZzliWVdQZ0pVaG8wVnlOVEg5djdIRkV0Vm1jUW5mL1Uv?= =?utf-8?B?TmdUMC9OUDhEWFA5SDcxZ2hzcnhYZnNScnJSaFJJa2wwL0lCeGZLVkhsWWly?= =?utf-8?B?ckgyWHYxODhlTWtTTWFRaTFXbkttNnhqb2R4bFJDNE9QZ2U1RlF1WE16cjNR?= =?utf-8?B?VkpnaS8wSWZvTUxXUVlTZGw0ZG9TbGNaR0JxNkhERVVaMmp0MGFMMTAyekxK?= =?utf-8?B?Ylpsa0VFM3BjOCtFZk5IbkcvT2oyOWtVVUxZQTBjV0l0NG9OL21kTUl4Tndv?= =?utf-8?B?czFLTkcwelJIMmIrZ0RkbXVwNXlpSGZqWkgyb3l6b29BWVJRTWRwbHdpd3B3?= =?utf-8?B?eG8wODExd0tkMWZEWGFUNE9IZUhHdDY0U3YyN2sydzdxRFVDckxkTnN2K25W?= =?utf-8?B?aEV1SHFtTDJxcXRpQkdXTHNXTXEyVERWaXBydTF3dm9DbVVLTlFwTjljaEVE?= =?utf-8?B?eDhST2pWZGNGSGFOa05LeEN2M3dMcHpqV0kvYXY1YTVFYThSWWU4MkZRTkdT?= =?utf-8?B?SnUzbm9hTkhJVWFxM2NVd25GWWlLcUYyRlhQWkhlaTVVdDh1QVU4SUlOQjhi?= =?utf-8?Q?xvtB/HLarHMKgyMHwI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ef61d4a-2eee-43f0-b8b5-08deb5e149b8 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5070.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2026 20:00:34.4579 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sbKpeNYxmqwwH2h0mJxG+HZ0ljnarXRfutsyD/Nso1OYKilbULsHJgwIADue0PygiapI6on2VCZNAklpbAyp1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8426 On 5/18/26 05:22, Nikunj A Dadhania wrote: > After commit 3645eb7e3915 ("x86/fred: Fix early boot failures on > SEV-ES/SNP guests"), __sev_{get,put}_ghcb() handle the early-boot GHCB > fallback internally, making the ghcbs_initialized guards in > __set_pages_state() and svsm_perform_call_protocol() redundant. > > Remove these redundant conditionals and call __sev_{get,put}_ghcb() > unconditionally. > > Also initialize state->ghcb to NULL in the early-boot path of > __sev_get_ghcb() so that the ghcb_state is well-defined for all callers, > even though __sev_put_ghcb() currently returns early before reading it. > > No functional change intended. > > Suggested-by: Tom Lendacky > Signed-off-by: Nikunj A Dadhania Reviewed-by: Tom Lendacky > --- > arch/x86/coco/sev/core.c | 8 ++------ > arch/x86/coco/sev/noinstr.c | 4 +++- > arch/x86/coco/sev/svsm.c | 10 ++-------- > 3 files changed, 7 insertions(+), 15 deletions(-) > > diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c > index 7ed3da998489d..ecd77d3217f3c 100644 > --- a/arch/x86/coco/sev/core.c > +++ b/arch/x86/coco/sev/core.c > @@ -367,17 +367,13 @@ static unsigned long __set_pages_state(struct snp_psc_desc *data, unsigned long > > local_irq_save(flags); > > - if (sev_cfg.ghcbs_initialized) > - ghcb = __sev_get_ghcb(&state); > - else > - ghcb = boot_ghcb; > + ghcb = __sev_get_ghcb(&state); > > /* Invoke the hypervisor to perform the page state changes */ > if (!ghcb || vmgexit_psc(ghcb, data)) > sev_es_terminate(SEV_TERM_SET_LINUX, GHCB_TERM_PSC); > > - if (sev_cfg.ghcbs_initialized) > - __sev_put_ghcb(&state); > + __sev_put_ghcb(&state); > > local_irq_restore(flags); > > diff --git a/arch/x86/coco/sev/noinstr.c b/arch/x86/coco/sev/noinstr.c > index 5afd663a1c217..e1e03f12fc7bb 100644 > --- a/arch/x86/coco/sev/noinstr.c > +++ b/arch/x86/coco/sev/noinstr.c > @@ -121,8 +121,10 @@ noinstr struct ghcb *__sev_get_ghcb(struct ghcb_state *state) > > WARN_ON(!irqs_disabled()); > > - if (!sev_cfg.ghcbs_initialized) > + if (!sev_cfg.ghcbs_initialized) { > + state->ghcb = NULL; > return boot_ghcb; > + } > > data = this_cpu_read(runtime_data); > ghcb = &data->ghcb_page; > diff --git a/arch/x86/coco/sev/svsm.c b/arch/x86/coco/sev/svsm.c > index 2acf4a76afe7a..916d62cd17dc7 100644 > --- a/arch/x86/coco/sev/svsm.c > +++ b/arch/x86/coco/sev/svsm.c > @@ -74,20 +74,14 @@ int svsm_perform_call_protocol(struct svsm_call *call) > > flags = native_local_irq_save(); > > - if (sev_cfg.ghcbs_initialized) > - ghcb = __sev_get_ghcb(&state); > - else if (boot_ghcb) > - ghcb = boot_ghcb; > - else > - ghcb = NULL; > + ghcb = __sev_get_ghcb(&state); > > do { > ret = ghcb ? svsm_perform_ghcb_protocol(ghcb, call) > : __pi_svsm_perform_msr_protocol(call); > } while (ret == -EAGAIN); > > - if (sev_cfg.ghcbs_initialized) > - __sev_put_ghcb(&state); > + __sev_put_ghcb(&state); > > native_local_irq_restore(flags); >