From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=DATE_IN_PAST_12_24, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BB83C433F4 for ; Thu, 20 Sep 2018 14:07:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CD6221526 for ; Thu, 20 Sep 2018 14:07:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CD6221526 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732863AbeITTuj (ORCPT ); Thu, 20 Sep 2018 15:50:39 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:31660 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731463AbeITTuj (ORCPT ); Thu, 20 Sep 2018 15:50:39 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 42GJSg68nqz9ttRj; Thu, 20 Sep 2018 16:06:59 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id i9POh7THBRyS; Thu, 20 Sep 2018 16:06:59 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 42GJSg5Xrtz9ttRd; Thu, 20 Sep 2018 16:06:59 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 215A58B86A; Thu, 20 Sep 2018 16:07:00 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id RNcyVHW_9iUG; Thu, 20 Sep 2018 16:07:00 +0200 (CEST) Received: from pc16082vm.idsi0.si.c-s.fr (unknown [192.168.232.3]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 845468B77F; Thu, 20 Sep 2018 16:06:59 +0200 (CEST) Subject: Re: Checkpatch bad Warning (Re: [PATCH] powerpc/kgdb: add kgdb_arch_set/remove_breakpoint()) From: Christophe Leroy To: Michael Ellerman , Joe Perches , Andy Whitcroft , paul.burton@mips.com, ralf@linux-mips.org, jhogan@kernel.org Cc: Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org References: <872199441fd43b05fc1c7d049098ef7c0e83f4c5.1537262646.git.christophe.leroy@c-s.fr> <2f5f572a-a28c-9d17-844b-9e1961febf64@c-s.fr> <595c96f5adcccd7eab9dc95eb48618981af66d3c.camel@perches.com> <87worgia60.fsf@concordia.ellerman.id.au> Message-ID: Date: Thu, 20 Sep 2018 01:23:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding MIPS arch in the loop On 09/20/2018 01:19 PM, Christophe LEROY wrote: > > > Le 20/09/2018 à 15:13, Michael Ellerman a écrit : >> Joe Perches writes: >> >>> On Tue, 2018-09-18 at 09:33 +0000, Christophe Leroy wrote: >>>> On the below patch, checkpatch reports >>>> >>>> WARNING: struct kgdb_arch should normally be const >>>> #127: FILE: arch/powerpc/kernel/kgdb.c:480: >>>> +struct kgdb_arch arch_kgdb_ops; >>>> >>>> But when I add 'const', I get compilation failure >>> >>> So don't add const. >>> >>> checkpatch is stupid.  You are not. >>> >>> _Always_ take checkpatch bleats with very >>> large grains of salt. >>> >>> Perhaps send a patch to remove kgbd_arch >>> from scripts/const_structs.checkpatch as >>> it seems not ever to be const. >> >> I think it could/should be const though, it just requires updating all >> arches. >> > > Yes I was thinking about doing it, but first thing is to change the way > MIPS initialises it: > > > struct kgdb_arch arch_kgdb_ops; > > int kgdb_arch_init(void) > { >     union mips_instruction insn = { >         .r_format = { >             .opcode = spec_op, >             .func    = break_op, >         } >     }; >     memcpy(arch_kgdb_ops.gdb_bpt_instr, insn.byte, BREAK_INSTR_SIZE); > > > Can this be done staticaly ? > > Christophe