From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755546AbdESNbu (ORCPT ); Fri, 19 May 2017 09:31:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50842 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755380AbdESNbp (ORCPT ); Fri, 19 May 2017 09:31:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1D6D93B70C Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=david@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1D6D93B70C Subject: Re: [PATCH 3/4] KVM: x86/vPMU: fix undefined shift in intel_pmu_refresh() To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Paolo Bonzini , Dan Carpenter References: <20170518173732.12185-1-rkrcmar@redhat.com> <20170518173732.12185-4-rkrcmar@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Fri, 19 May 2017 15:31:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170518173732.12185-4-rkrcmar@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 19 May 2017 13:31:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.05.2017 19:37, Radim Krčmář wrote: > Static analysis noticed that pmu->nr_arch_gp_counters can be 32 > (INTEL_PMC_MAX_GENERIC) and therefore cannot be used to shift 'int'. > > I didn't add BUILD_BUG_ON for it as we have a better checker. > > Reported-by: Dan Carpenter > Fixes: 25462f7f5295 ("KVM: x86/vPMU: Define kvm_pmu_ops to support vPMU function dispatch") > Signed-off-by: Radim Krčmář > --- > arch/x86/kvm/pmu_intel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/pmu_intel.c b/arch/x86/kvm/pmu_intel.c > index 9d4a8504a95a..5ab4a364348e 100644 > --- a/arch/x86/kvm/pmu_intel.c > +++ b/arch/x86/kvm/pmu_intel.c > @@ -294,7 +294,7 @@ static void intel_pmu_refresh(struct kvm_vcpu *vcpu) > ((u64)1 << edx.split.bit_width_fixed) - 1; > } > > - pmu->global_ctrl = ((1 << pmu->nr_arch_gp_counters) - 1) | > + pmu->global_ctrl = ((1ull << pmu->nr_arch_gp_counters) - 1) | > (((1ull << pmu->nr_arch_fixed_counters) - 1) << INTEL_PMC_IDX_FIXED); > pmu->global_ctrl_mask = ~pmu->global_ctrl; > > Reviewed-by: David Hildenbrand -- Thanks, David