mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Guillaume Tucker <guillaume.tucker@collabora.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Shuah Khan <shuah@kernel.org>, Kees Cook <keescook@chromium.org>
Cc: Anders Roxell <anders.roxell@linaro.org>,
	Tim.Bird@sony.com, kernel@collabora.com,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 0/4] Fix kselftest build with sub-directory
Date: Tue, 12 Jul 2022 20:27:44 -0600	[thread overview]
Message-ID: <d32187ae-8e8a-72ad-d422-3d3b47101160@linuxfoundation.org> (raw)
In-Reply-To: <cover.1657614127.git.guillaume.tucker@collabora.com>

On 7/12/22 2:29 AM, Guillaume Tucker wrote:
> Earlier attempts to get "make O=build kselftest-all" to work were
> not successful as they made undesirable changes to some functions
> in the top-level Makefile.  This series takes a different
> approach by removing the root cause of the problem within
> kselftest, which is when the sub-Makefile tries to install kernel
> headers "backwards" by calling make with the top-level Makefile.
> The actual issue comes from the fact that $(srctree) is ".." when
> building in a sub-directory with "O=build" which then obviously
> makes "-C $(top_srcdir)" point outside of the real source tree.
> 
> With this series, the generic kselftest targets work as expected
> from the top level with or without a build directory e.g.:
> 
>    $ make kselftest-all
> 
>    $ make O=build kselftest-all
> 
> Then in order to build using the sub-Makefile explicitly, the
> headers have to be installed first.  This is arguably a valid
> requirement to have when building a tool from a sub-Makefile.
> For example, "make -C tools/testing/nvdimm/" fails in a similar
> way until <asm/rwonce.h> has been generated by a kernel build.
> 
> v2: replace headers_install with headers
> 

I already applied the series. Please send me patches I can apply
on top of the ones in linux-kselftest next branch.

thanks,
-- Shuah

      parent reply	other threads:[~2022-07-13  2:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12  8:29 Guillaume Tucker
2022-07-12  8:29 ` [PATCH v2 1/4] selftests: drop khdr make target Guillaume Tucker
2022-07-12  8:29 ` [PATCH v2 2/4] selftests: stop using KSFT_KHDR_INSTALL Guillaume Tucker
2022-07-12  8:29 ` [PATCH v2 3/4] selftests: drop KSFT_KHDR_INSTALL make target Guillaume Tucker
2022-07-12  9:59   ` Anders Roxell
2022-07-12 14:57     ` Guillaume Tucker
2022-07-12  8:29 ` [PATCH v2 4/4] Makefile: add headers to kselftest targets Guillaume Tucker
2022-07-13  9:09   ` Nicolas Schier
2022-07-13 13:04     ` Guillaume Tucker
2022-07-13  2:27 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d32187ae-8e8a-72ad-d422-3d3b47101160@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=Tim.Bird@sony.com \
    --cc=anders.roxell@linaro.org \
    --cc=guillaume.tucker@collabora.com \
    --cc=keescook@chromium.org \
    --cc=kernel@collabora.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=ndesaulniers@google.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®