mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Ian Rogers <irogers@google.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Zhengjun Xing <zhengjun.xing@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Andi Kleen <ak@linux.intel.com>,
	James Clark <james.clark@arm.com>, <linux-kernel@vger.kernel.org>,
	<linux-perf-users@vger.kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 1/8] perf vendor events: Update events for CascadelakeX
Date: Fri, 18 Mar 2022 09:14:40 +0000	[thread overview]
Message-ID: <d32376b5-5538-ff00-6620-e74ad4b4abf2@huawei.com> (raw)
In-Reply-To: <20220317182858.484474-1-irogers@google.com>

On 17/03/2022 18:28, Ian Rogers wrote:
> The change:
> https://github.com/intel/event-converter-for-linux-perf/commit/fc680410402e394eed6a1ebd909c9f649d3ed3ef
> moved certain "other" type of events in to the cache topic. Update the
> perf json files for this change.
> 
> Tested:
> ```
> ...
>    6: Parse event definition strings                                  : Ok
>    7: Simple expression parser                                        : Ok
>    8: PERF_RECORD_* events & perf_sample fields                       : Ok
>    9: Parse perf pmu format                                           : Ok
>   10: PMU events                                                      :
>   10.1: PMU event table sanity                                        : Ok
>   10.2: PMU event map aliases                                         : Ok
>   10.3: Parsing of PMU event table metrics                            : Ok
>   10.4: Parsing of PMU event table metrics with fake PMUs             : Ok
> ...
>   68: Parse and process metrics                                       : Ok
> ...
>   89: perf all metricgroups test                                      : Ok
>   90: perf all metrics test                                           : FAILED!
>   91: perf all PMU test                                               : Ok
> ...
> ```
> 
> Test 90 failed due to MEM_PMM_Read_Latency as the test machine
> lacks optane memory, and the divide by 0 causes the metric not to
> print - which is intended behavior.

Hi Ian,

Failing is not ideal as an intended/expected behaviour. Could we make 
the test skip somehow for the case you describe?

Thanks,
John

      parent reply	other threads:[~2022-03-18  9:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17 18:28 Ian Rogers
2022-03-17 18:28 ` [PATCH 2/8] perf vendor events: Update events for Elkhartlake Ian Rogers
2022-03-18  9:12   ` Xing Zhengjun
2022-03-17 18:28 ` [PATCH 3/8] perf vendor events: Update events for Icelake Ian Rogers
2022-03-18  9:15   ` Xing Zhengjun
2022-03-17 18:28 ` [PATCH 4/8] perf vendor events: Update events for IcelakeX Ian Rogers
2022-03-18  9:19   ` Xing Zhengjun
2022-03-17 18:28 ` [PATCH 5/8] perf vendor events: Update events for Skylake Ian Rogers
2022-03-18  9:19   ` Xing Zhengjun
2022-03-17 18:28 ` [PATCH 6/8] perf vendor events: Update events for SkylakeX Ian Rogers
2022-03-18  9:21   ` Xing Zhengjun
2022-03-17 18:28 ` [PATCH 7/8] perf vendor events: Update events for Tigerlake Ian Rogers
2022-03-18  9:22   ` Xing Zhengjun
2022-03-17 18:28 ` [PATCH 8/8] perf vendor events: Update events for TremontX Ian Rogers
2022-03-18  9:26   ` Xing Zhengjun
2022-03-18  9:09 ` [PATCH 1/8] perf vendor events: Update events for CascadelakeX Xing Zhengjun
2022-03-18 14:44   ` Arnaldo Carvalho de Melo
2022-03-18  9:14 ` John Garry [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d32376b5-5538-ff00-6620-e74ad4b4abf2@huawei.com \
    --to=john.garry@huawei.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=eranian@google.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=zhengjun.xing@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®