From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 065EB47604C for ; Tue, 4 Aug 2026 16:27:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785860879; cv=none; b=VTdACDmImZULuX35MG5zOODq2SSubR51mikx0Wc7YF71TOPehtFv7ACJYg4yAaLwR/lzS8VDb2oedwuXS1G64evOG0YY9S/Nf4pRON50r5VYlEsQpalwPk/cnKOKjv3eNmgEq3FbtUNsziBPaSIvhVhD4gYfOBuy9ZCPUbkufHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785860879; c=relaxed/simple; bh=ru4zq74HTo4cd7cPddY/S4zAPUVpXVVN7sk+kWI3yRQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ttELyYSBsvVM+I8UtjH8JtGNEmT5y189Qdl3XjhZQ36HlyibVkfF1qhyMYIOH1dJRfLj5Eisj5UG99JFQfQCCWdhnxivbXWNDs/ki0O5rdVhNxpY1V+1KeQpy7CAmokbJqL/zL9zicognLELcA3TcVrU2mHRN1K3oe9qlMxn2jE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dCJrnxHx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PIyddq7r; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dCJrnxHx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PIyddq7r" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 674Ffe34071196 for ; Tue, 4 Aug 2026 16:27:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rT+BsLlkR/V58zorm9wrpxTZPVaRDittlmHkMjcYSLM=; b=dCJrnxHxJYm92/tz 70aOahKT8FaXTtQNf9jIEKsvVuHrEwBxNrz7S+rJEoGUFJEUh7oGjNwn9SWYfk3j 7KMq7FkgsgWbblADVzXhrfdG8e2FNJRHj/Qm74uWj6bg/peV4ocE3b+A/dxL3BpU RUMdZ7D3HT5nrbb4z+lNIagfmIznKU2nL0ZxvnkR6FsvGc4ibwvIVEgHKojLJbwV 00Dmm9PcucUs0ET3JRHdl4BxQcRhEVrMQLNADktrWMFnSmakoL2UBo5YRvELsAY2 3NYBjQSiyLUwhwfR2w4xS1eY/mr6s96In6cUlVhXmL5E/LNy1JUcCNbOe9JgpDdl GiVmcQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fujwsg7uu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 16:27:52 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38e7ff7b375so10922a91.1 for ; Tue, 04 Aug 2026 09:27:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785860872; x=1786465672; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=rT+BsLlkR/V58zorm9wrpxTZPVaRDittlmHkMjcYSLM=; b=PIyddq7r5DmvsseDGEu6udPLFgQfVb3yrFC+HpZsSSg7kwRB85jwywuzsIVPtwyKJl xAB9bwnHZ1bNU5IB3RLf7bYkmLC4+rNVEHGDV/nbEnSyehX/Vgef1J7XaLmXW+xyqW6U m/WcJEGjhHC81e8XiaAF6qu0DM2PZeMW3VWKXulzZIZoxWVF6uNPwkQPXboGeAulagIr hTvaNN0L5c3a3bv1uZZnLoPV1ohE8qa4KtR82cFcQq9QzCSLRDkzdwL6LLruufR6xuM7 srXyFjoQGvxo1+ryEdNqM8DIsAN3UXJc1YJLbVVTpN+76k/0zcont7E+gmf+y8kGaWjZ ckCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785860872; x=1786465672; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rT+BsLlkR/V58zorm9wrpxTZPVaRDittlmHkMjcYSLM=; b=ESnO+juEtikqYS228bxRZacmB14qVAvscjnwrzB1lczGTz3WlFZIREg/YDWiX5CnXI FCyWvUPjGkXNS8fnQwdRBGnw1bObTto63aezsm0F2/2cQ9LtO2as2SJlPPRS7er355Ly ual67J0cc4y/mQEaC8++x9jn7D8KhfZKhNvN6w+/n2TXOFGceZEQVerftkggqo5Cactx wVf/WQj/VmNk5FFvSnDUi+mRkvnZ7ZT8nf52K4YJ1OkQe4RwNZkMMr+/VAtE+uF5wJSc Jnk+mxkR3DkGi0EEvwv1bzRxdMKxGOY7NzMax5vCZ0ZLKqw3Cyg36lkjwzwdf0Tq1n1w kv+g== X-Forwarded-Encrypted: i=1; AHgh+RrsI2B3ZrJbO86DRPOXiuT2cu7FMPPgVjLGRa3B2CyGnDSEWjMC9jNESls2hrZr6Ec3ODnKn4kZc6lQrdc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz441LTaUfObL4XVWEnbjwINIpFrow6PXeTWLQJCjlPE6mRs4+9 6V7bNsE6tpaVCnJrZczZRdjJmO2TOmR++0+zfK+5oflqBK3msgpYAbb55gU9lfGwPJvSAtvscE3 R4mATwfszEW6lDPeQdrflrv1+l1GYapIHElfFEvFrv9BE3THFJOMG3nbPhLZKZjKu9kU= X-Gm-Gg: AR+sD11NjQ2+SHSInuhUJ+eBEE9cH84Jgs18+Gvp0CA3/xPo6HEf4AM+XOe3o4YxejC fiFiYr7cDMrPPZBrPb2fV390oXhItQXPlGEOifwfeDrLfpbCZKujQS5SRwA5DU6O2wcoYXJmkV1 T+HIlv22bNexeLRaszzYPnea0Or/zbyhRLybvf7jm31yYvBvc8dR3igErxEoU9I178/jPasyjL4 eyB2AmTyesZPYQgYAY5m9BGBgIkNYUpsaqUrClNhicq21qzwtYDjcJ9CXdt+hfET1yI9X7BotqV EPEbETzZOgMUQls7pbpQUuLkj8pesR1CJYmhqf9ZuoTi0/SE8hom/lMpI4+Zd8nY/9o4HwZkuwf YsxfLr8J67MYKo/wPFCuFuqpv1GpFDzIMhZWxKJ4= X-Received: by 2002:a17:90b:1b42:b0:38d:ddc2:7ccb with SMTP id 98e67ed59e1d1-3903c5433e5mr263023a91.1.1785860871716; Tue, 04 Aug 2026 09:27:51 -0700 (PDT) X-Received: by 2002:a17:90b:1b42:b0:38d:ddc2:7ccb with SMTP id 98e67ed59e1d1-3903c5433e5mr262987a91.1.1785860871212; Tue, 04 Aug 2026 09:27:51 -0700 (PDT) Received: from [192.168.1.5] ([116.74.42.160]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315867a68fdsm10301595eec.25.2026.08.04.09.27.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 09:27:50 -0700 (PDT) Message-ID: Date: Tue, 4 Aug 2026 21:57:43 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ath11k: modify null check logic in ath11k_ce_rx_post_pipe() To: Mikhail Lobanov , Kalle Valo Cc: Jeff Johnson , Govindaraj Saminathan , Miles Hu , Sven Eckelmann , Rajkumar Manoharan , John Crispin , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org References: <20240909150824.28195-1-m.lobanov@rosalinux.ru> From: Rameshkumar Sundaram Content-Language: en-US In-Reply-To: <20240909150824.28195-1-m.lobanov@rosalinux.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: ueeiFTVx5NU2JozzghErNPePRaS8bRm8 X-Proofpoint-ORIG-GUID: ueeiFTVx5NU2JozzghErNPePRaS8bRm8 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDEzMiBTYWx0ZWRfX6w5sp+FfgWwQ TLeYC4liys42Xx1ZX0IDWIgcnNBNG2S6Y8/kQmWh7HU43bHAdUi/p+ib3f7jFFkjP8qyEanQzzf gbAmuacFGh6gpw4CPWv4OUi53SHl+bw= X-Authority-Analysis: v=2.4 cv=Lu6iDHdc c=1 sm=1 tr=0 ts=6a721308 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=1uVfqaZqOROvog6V8p7mZg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=HH5vDtPzAAAA:8 a=he8YDqbjAAAA:8 a=EUspDBNiAAAA:8 a=eE1TrZLfpK1Q4X-vsd8A:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=QM_-zKB-Ew0MsOlNKMB5:22 a=lRF3faHqDRKgy28aj_NN:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDEzMiBTYWx0ZWRfXzXyz0VZUtszP VFY1hwZSTYqm6nSfgZ6oFYhqOHabAi0rysuRoordXglmlpfn/sBr6Tk61QqgiqFL1BkFCUtoUBe 4jJnMzfaBLrABNf6AjDlRQhzSEchHcz4wVchOCpZ1k3An/lxIT3qq8jsy/Cumz8iPSTKzZ3yUmu DgcBLPDb//wOrKP+pzCrg/3A3B+baoC6q7oNicxJni23O3QYSSoj3mkiAtpMuNuxXYlh2IEWKKU HHi+OnaqEPzvPbsoleb6AagoonswdI9IBXwsmKpCFwkmH5EUfTu4+ZBqIYgn77+P5Acq/XG53lP f+yOsjvZQh9/7mUO38Z85IGdDEzc9X4r5Q+GBt3hlZumIOc1uD/WjUqso0TC29pq8n8FRqUUEeN /+usp+BKWLkcRpYptMEm+rVCTJ5UedT51JhXtxbO21tNKHVilnStwbd414/XvM/S40VR4HJZlJ/ CUd8tukDyuvCMlny7cA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-04_03,2026-08-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040132 On 9/9/2024 8:38 PM, Mikhail Lobanov wrote: > The previous logic in ath11k_ce_rx_post_pipe() incorrectly required both > dest_ring and status_ring to be NULL in order to exit the function. > This caused the function to continue even if only one of the pointers > was NULL, potentially leading to null pointer dereferences in > ath11k_ce_rx_buf_enqueue_pipe(). > > Fix the condition by modifying the logic so that the function returns > early if either dest_ring or status_ring is NULL. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Signed-off-by: Mikhail Lobanov Reviewed-by: Rameshkumar Sundaram