From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68742C433EF for ; Wed, 9 Feb 2022 16:07:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236546AbiBIQHI (ORCPT ); Wed, 9 Feb 2022 11:07:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236535AbiBIQHF (ORCPT ); Wed, 9 Feb 2022 11:07:05 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5D908C05CB86 for ; Wed, 9 Feb 2022 08:07:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644422827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9GmtaJHp/xTHNMpzFHAgFBMiYKYYWVV2IEV+4sk5uqg=; b=BaLjw1ZAJBsdZh+i7zjT4nOcKDwY6/ucTiVQbhKI9X1YNKubOYmc13EWduLcNLy3ppZifm QdiYCvSqewJFT7F+LsvMtXCc7tCtSeXWC5iJnpiyu7YC5mr9yJjJCfnxh+N3p2JLqfykCB L1EJVvwLBqeffO/YHLqQ0SnLPPPogLw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-177-DHD782eFP2CcpyFflwyVgQ-1; Wed, 09 Feb 2022 11:07:06 -0500 X-MC-Unique: DHD782eFP2CcpyFflwyVgQ-1 Received: by mail-wm1-f69.google.com with SMTP id v190-20020a1cacc7000000b0034657bb6a66so254131wme.6 for ; Wed, 09 Feb 2022 08:07:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9GmtaJHp/xTHNMpzFHAgFBMiYKYYWVV2IEV+4sk5uqg=; b=0QoGTWxcJ5tS+XhEXgaiPpt6NCrFQi3hHRWrPYNlbcOSxwxyohh2utSh3/7lUnGBy5 ntyxgkSc0lWN5XtSvts7fTb6Xgt4vV2ZZoGoHLeIysOmuUCKTpaXMEHyMs+TgwvKVPVS 621QIqYkLlmQStvOuLzOtojr+VKMBarH6kA9vACN8jZDVo1/rHWUXz4qUbUniXR4nx+K m4ltqflHSDgZCakADEUHXLF4oty/evYGHWZcRFau7xCFlQntwDVCwPM0SZWbhekNuFQJ 61RY8f9mzwOG21OAPV9ZkhMnR1w82db/XW/xcc5ncwIw6vIQicJF7dLUoKlClwEzmTW4 KWhQ== X-Gm-Message-State: AOAM531DkuAZPlOJfV202xtI4pDJJxK/dITnf5mW0SCYHuP0ZEaEgFRR 0AFvDzSAoWsmU73EPLPTSrZ4xN21iadfBke1ibne2WI1EUYnU3EslhnEstLTauWtCWQ+kApoRZA 1Cg5V743qHaUVGaUc2eHxcaKI X-Received: by 2002:a5d:6c67:: with SMTP id r7mr2694170wrz.518.1644422825078; Wed, 09 Feb 2022 08:07:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJzSOdYMsb8yEAJ80HG2zpe/vuSpys4t0RlhZKdpTZvQG5sQ5JJ8V2gZ2pWwI7Y/pRJze0jM/A== X-Received: by 2002:a5d:6c67:: with SMTP id r7mr2694154wrz.518.1644422824917; Wed, 09 Feb 2022 08:07:04 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id f20sm7148775wmg.2.2022.02.09.08.07.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Feb 2022 08:07:04 -0800 (PST) Message-ID: Date: Wed, 9 Feb 2022 17:07:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 5/7] (WIP) drm/solomon: Add SSD130X OLED displays SPI support Content-Language: en-US To: Andy Shevchenko , Geert Uytterhoeven Cc: Linux Kernel Mailing List , Daniel Vetter , Maxime Ripard , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , DRI Development , Linux Fbdev development list References: <20220209090314.2511959-1-javierm@redhat.com> <20220209091204.2513437-1-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/9/22 16:17, Andy Shevchenko wrote: > On Wed, Feb 09, 2022 at 01:25:46PM +0100, Geert Uytterhoeven wrote: >> On Wed, Feb 9, 2022 at 10:12 AM Javier Martinez Canillas >> wrote: > > ... > >>> + .compatible = "solomon,ssd1305fb-spi", >> >> This needs an update to the DT bindings. >> Hence this may be a good time to deprecate the existing >> "solomon,ssd130*fb-i2c" compatible values, and switch to >> "solomon,ssd130*fb" instead, for both I2C and SPI. > > Agree! > Did you see my comment about automatic module loading ? I think that would be an issue if we use the same compatible for both I2C and SPI drivers. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat