From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D89C433EF for ; Thu, 14 Apr 2022 15:47:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346056AbiDNPtw (ORCPT ); Thu, 14 Apr 2022 11:49:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348831AbiDNPkK (ORCPT ); Thu, 14 Apr 2022 11:40:10 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 34E9EC31F6 for ; Thu, 14 Apr 2022 08:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649949525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WebPVtGMXwiaKLP3FU98CAuUa7w60cn7WdQ5x8iGnDU=; b=hop638oHshtLcMgRiSEvvYQgftNraKx5+o8vlYnqxD5I17FiEqiw/BqD/aQAXAelwzqyp8 +IzzdR7x6AEezRq4Cv7R6dn0nFakzBYgzpoUFXZYc/jIjLMJLCEzVuS4dUN+9RTSSxW0Wr ktXt5xVU0kbSfTCVRVOCIrmt4h6KHkM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-18-sEc2PB6GOKC5B2KpO2xgtg-1; Thu, 14 Apr 2022 11:18:41 -0400 X-MC-Unique: sEc2PB6GOKC5B2KpO2xgtg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 589AC811E81; Thu, 14 Apr 2022 15:18:40 +0000 (UTC) Received: from [10.22.19.30] (unknown [10.22.19.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE8292166BA3; Thu, 14 Apr 2022 15:18:23 +0000 (UTC) Message-ID: Date: Thu, 14 Apr 2022 11:18:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5] locking/rwsem: Make handoff bit handling more consistent Content-Language: en-US To: Greg KH Cc: john.p.donnelly@oracle.com, chenguanyou , dave@stgolabs.net, hdanton@sina.com, linux-kernel@vger.kernel.org, mazhenhua@xiaomi.com, mingo@redhat.com, peterz@infradead.org, quic_aiquny@quicinc.com, will@kernel.org, sashal@kernel.org, stable@vger.kernel.org References: <20211116012912.723980-1-longman@redhat.com> <20220214154741.12399-1-chenguanyou@xiaomi.com> <3f02975c-1a9d-be20-32cf-f1d8e3dfafcc@oracle.com> <31178c33-e25c-c3e8-35e2-776b5211200c@oracle.com> <161c2e25-3d26-4dd7-d378-d1741f7bcca8@redhat.com> <2b6ed542-b3e0-1a87-33ac-d52fc0e0339c@oracle.com> From: Waiman Long In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/14/22 06:48, Greg KH wrote: > On Tue, Apr 12, 2022 at 01:04:05PM -0400, Waiman Long wrote: >> The patch has already been in the tip tree. It may not be easy to add a >> Fixes tag to it. Anyway, I will encourage stable tree maintainer to take it >> as it does fix a problem as shown in your test. > I have no idea what you want me to do here. Please be explicit... > I would like the stable trees to include commit 1ee326196c66 ("locking/rwsem: Always try to wake waiters in out_nolock path") after it is merged into the mainline in the v5.19 merge window. It should be applied to the stable trees that have incorporated the backport of commit d257cc8cb8d5 ("locking/rwsem: Make handoff bit handling more consistent") since this commit seems to make the missed wakeup problem easier to show up. Cheers, Longman