From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4ED9C11F65 for ; Wed, 30 Jun 2021 18:00:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BBA061469 for ; Wed, 30 Jun 2021 18:00:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232842AbhF3SCr (ORCPT ); Wed, 30 Jun 2021 14:02:47 -0400 Received: from smtprelay0036.hostedemail.com ([216.40.44.36]:57326 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229573AbhF3SCq (ORCPT ); Wed, 30 Jun 2021 14:02:46 -0400 Received: from omf11.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 996BA182BF4F3; Wed, 30 Jun 2021 18:00:14 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA id 9D93620A29C; Wed, 30 Jun 2021 18:00:13 +0000 (UTC) Message-ID: Subject: Re: [PATCH] powercap: Replace symbolic permissions with octal permissions From: Joe Perches To: "Rafael J. Wysocki" , Jinchao Wang Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Linux PM Date: Wed, 30 Jun 2021 11:00:12 -0700 In-Reply-To: References: <20210624084403.1163-1-wjc@cdjrlc.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9D93620A29C X-Stat-Signature: r3aumi41y1cmpu7by8xrwmz566mj1rzi X-Rspamd-Server: rspamout03 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19q3KI551Z+RXekoPIyewutzcuwojVEW2A= X-HE-Tag: 1625076013-190973 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2021-06-30 at 19:41 +0200, Rafael J. Wysocki wrote: > On Thu, Jun 24, 2021 at 10:44 AM Jinchao Wang wrote: > > > > Resolve following checkpatch issue, > > Replace symbolic permissions with octal permissions > > I don't see much value in this replacement and checkpatch complaining > about the existing code base is not something to worry about in > general. https://lore.kernel.org/lkml/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com/ I do agree that in general checkpatch should not really be used as the sole argument in favor of changing existing code. So removing the "resolve following checkpatch issue" from the commit message and replacing it with something like "to improve readability" would be better.