From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751015AbdAWKYh (ORCPT ); Mon, 23 Jan 2017 05:24:37 -0500 Received: from mail-he1eur01on0117.outbound.protection.outlook.com ([104.47.0.117]:60558 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750737AbdAWKYc (ORCPT ); Mon, 23 Jan 2017 05:24:32 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Subject: Re: [PATCH v8 12/12] mux: support simplified bindings for single-user gpio mux To: Jonathan Cameron , linux-kernel@vger.kernel.org References: <1484755035-25927-1-git-send-email-peda@axentia.se> <1484755035-25927-13-git-send-email-peda@axentia.se> <33b29f7e-3e48-b85d-ccf9-93b1d67ac634@kernel.org> Cc: Wolfram Sang , Rob Herring , Mark Rutland , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Corbet , Andrew Morton , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-doc@vger.kernel.org From: Peter Rosin Organization: Axentia Technologies AB Message-ID: Date: Mon, 23 Jan 2017 11:24:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <33b29f7e-3e48-b85d-ccf9-93b1d67ac634@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [217.210.101.82] X-ClientProxiedBy: AM5PR0601CA0040.eurprd06.prod.outlook.com (10.173.86.154) To VI1PR0202MB2559.eurprd02.prod.outlook.com (10.173.79.138) X-MS-Office365-Filtering-Correlation-Id: 43b0ff8b-3f94-4d90-fc3a-08d44379ffab X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:VI1PR0202MB2559; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;3:vTwUNYbLgqhvG9HpIJ9AvrunDe9zxm8zdtgwCZgQqGnHK2kgd/v1a8sOm0A+9uJmab8rhmGYN0FIm7Xr1tWYNhVla8YKgXSavQym1TFfi7vQoE408POfUFpGwQsofvfVuv7uYji+d3Bl9g3/aq/6WFpMhGMgOb+pguyRZ2ypxHqBIih0GQOw8admIricpgUuUoaezyen+89DpwaBz7rO0xjmuPiVigGaoG2Q3pJca+4ePl+qOYVF1qE96wEvGJvjSljwzSygZHdX1Kt/L68NTQ== X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;25:TgjBJNBtUtvwmHjjM+Ojh9CoMJelTtVu3S6oGMOg3nQQUCXM2qWXFm/8gnAB7KEos7sMQmBgWImL8tEPhGSfnS12s32q0Q/6T3CHESuS3LeLzTr4gYl1hdApx9u9RVV29genzA0Fzo1dDgLZcfhAi3CAsxxnD4T4OI9VJ/8+lYC1vKtQsQA2b+l9jNV4mC+FL42PzYedtoZoBgUXdVFcby2AgNICzdUZ+7d7UjQWSQHbjMdcCWdW7P5VqK/O8m+06JWwB8QTYdOUIJv3w+2MwoKWr0iL/Qz2ZEqlYV3xG3CNfufkqpmTcQ4DDnv1oou+hVf2J5L/a38KIiUCos4x4NWjyXd1XY6veCUumo6sZ5qWCR8ZL4ZRv/okL8lHlxC/KkTmlMxByRXMGP80ZtQH1b3lPV8OSmWIN5RWctQ4Kz1Z8rr4YLjSBnDxOD1FHKWZKaYui1WO/dxV/K2iiedD3ixz+9xFmA+lCV/6sGWx+Ubr0K9Ol70GX+vb8UKu4MpPZ26mccHmnrUt/VE/8Q5rGyYjBX2HcC9nGvvpM4ljU8+yNXt71I6RkC7ZaO1QCCxwoYFVeu7K0Op5RuuLw2Zv9cWzgYId+U0Z+oMWMo1Ro5C5YSmbXLbqqReJHof+Hfg5w7eaepxz8dZFhxXwkisOn0UEQkvaYhXnJrWCY1VUQPHjzi9C6U20h7teuXC6FMPWXYXvAjlqdbBTUKKiBXw9xr1cw7aqfjnF3FXzU32Y2vj5szAZlkRybpL/28cxCxoq X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;31:LSNbI3bfv2RqdTYLP2HFUY4BMxZkwEBPJwUxqt4Q5FFfRTW+q0e9ErV2vOM+OXOYfgFCR3Dz4oWQ6tfE6Lzxl4062frBaod2eY1SyF94u6NF4t8WkY7DLDAd3BAjD7Z4/BHuD0SF6K2o901WV5Y1YlMORLOmOLedRnvGLr+4G27udjL+YgoYu+G+EMFtfEoMco+Oeez1tW7QbzgPe/aeGXOo4IoWGGXWz1qRzisyKtvUgPpg1MbYhElJzLZSitDyEeTN4RchGNaftBLHgxX8wA==;4:g+40qJdY+sKThFGFk+8POTIO6aLGktfkqv78c3rIOsE6Oybjq3QTT1f8a0IUhLyO4qsxliL2POHLLWlOM8iSAP61wKFVZDUXOABJMBs27FLgogsY5ZHeIJ4gbCUgxxB+HSUtfftXxX/qk7RRfB2bXSSI4AicW7iYx8xwhuGom8+hKmMmYf3eHq7i9ccxCV1xn5Btp5H5wtMx03yVC1GbEsIh4r/0y2JO/LFlf9N7DuIvGswfbEC6t0+J5+Q5uViCR7vNEXcdkIjqcsL92bSMMUaber34qSnYUV6v5axsJ46iUjfXedAil5+RDtKa5rzmGJgNPVboTVfygKgQu/G8Nua5sBYU8etMn4vXc4mRO7QUYIHZnKrwLRJZMuYPaIff24CuNyTWSUqo4TQT6xZXhW4cqVNOX1EfE0MwPaHKC6WVsGCVhbbECIUk5KojL1o4BlMUct8AblmD1BHVBXTzJmZ4mdIoMM/d/sMD4jLksUAzAlNu5V0IBa1zZtlDEmvCteJKkUWlS8SjTyGokD1HQOM3mLFRLVql22SPErnCBz01noClN0dN/ntIgjxKswy9AWpPTWYUDqxqaWVUKRtfvkh96L8qGs1h0Q3+EyYVw44o1Uh6abhYZwu/v//bZMHT X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(2016111802025)(6072148)(6043046);SRVR:VI1PR0202MB2559;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0202MB2559; X-Forefront-PRVS: 0196A226D1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(39830400002)(39450400003)(39410400002)(377424004)(24454002)(199003)(189002)(8676002)(76176999)(54356999)(25786008)(3846002)(5660300001)(6116002)(23746002)(64126003)(7416002)(230700001)(81156014)(68736007)(33646002)(83506001)(50986999)(65826007)(81166006)(189998001)(117156001)(53936002)(305945005)(101416001)(4326007)(106356001)(77096006)(2950100002)(8666007)(74482002)(50466002)(2906002)(54906002)(86362001)(4001350100001)(31686004)(65956001)(229853002)(31696002)(92566002)(6666003)(97736004)(47776003)(90366009)(36756003)(6486002)(38730400001)(110136003)(66066001)(65806001)(7736002)(42186005)(105586002)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0202MB2559;H:[192.168.0.125];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR0202MB2559;23:VJFbJDpw7qfoe98VrwA50noTQcpQi6frs6J?= =?Windows-1252?Q?BAw8NKwKtDJuXTzx1T8u9uWI0hzOUJQVDIeYbUMIq/oNh39xbtg84Lwx?= =?Windows-1252?Q?DOxVyYBznSroJs6fCjl5R6poqai5UwpzxeETNfJZgv1kyIOPnUwgJwdU?= =?Windows-1252?Q?mdDnLt7Psu7dPM2t2n0x4bgKKnHbU6N5tFR9WcaL4umIlQJzbw4AWfCi?= =?Windows-1252?Q?4n0xWKwoC4WsEVMr6XhmbDBLeX1TZnVG01jtSIKBonu1YFN6xhHKwelt?= =?Windows-1252?Q?5JbxvXrAAWOLOOLOMN23J6Re2x6Pn65RP7GrDXKWKkOvxmJPVK35B5wX?= =?Windows-1252?Q?9t1fvUZAtyxDPzuoF9NSmfgSSTAzr7WFlUXwL2tUDDLFahdyaihp+4gu?= =?Windows-1252?Q?QQ+JuJGccaCmyFX+1NKqN3ZZ3k6cZdetp7vmo+hChPKM9HuHlIO2Pjmz?= =?Windows-1252?Q?rm8pS8MHT5g7uR8ABJRWJHu5OA4UX9DJZ6mzJoNOp3aNx0Qymz2q1o8n?= =?Windows-1252?Q?QhmX/iwOUkq+4swM32bEaaRjDUdy5Hq58bMfeM8MO8S7dJahhcAs4z0A?= =?Windows-1252?Q?L6EsQqjlsf4QgefchzmDzwpH4tYN3wLA6g0zutzOHLHuei6ZKQJ4oc5s?= =?Windows-1252?Q?p6jLGZ2AsoKDZd2Q24WWxQZiGQL4Pwg7FKPNApilRGERteChqQsEMh8l?= =?Windows-1252?Q?qfvPSJVom1xZk+gJXrbv3FCEaGaQZq8apvdgY6m3jOstPi/znmCYbzVx?= =?Windows-1252?Q?uMylEIpGVYJz9VhiXRehyEC1lSUgQIoXk14kD4HTMuPy2u0zXAFCqxm/?= =?Windows-1252?Q?ivu1WuWNR+idm8f47WHj0XrweBGQg5kzyc38OisRCjP3R75l+Uwqo/7/?= =?Windows-1252?Q?7xmyGheL7GosnVLznXqmZEE1boQ8xXSZQ5nWE0Zlo8BeffG2E53mNMyz?= =?Windows-1252?Q?24qw0+32vRrK/Rno9gVMhT0va6uu51ipHrw5nYOisVEiiTYinmtUR/ov?= =?Windows-1252?Q?qJcN6pQLRf0mcQfwPWJi2ZzisPjoDzdzGbS6iC85iICdskLRtZ9FbGsg?= =?Windows-1252?Q?ASYvZ6qyt0TEOjlC5M7Oqnhx98nCyqMWGdi7SqEs43KCwvvHhJdIA9YN?= =?Windows-1252?Q?TQfpcR0+QdkgZABWomPO4eVXBOsy6OIE+f1z3wCK+h0KslDuFHRNHuto?= =?Windows-1252?Q?ZiU96R5IpzWjK0FT0aL8nVroprlDe2I3yPLTUtz+4te3KqDNjOieWrZT?= =?Windows-1252?Q?+OFHCIHeqU0PXLC/vpDX1Pkm55CmhXy9DWT2ddDuuoCmLMkmIbObb5vO?= =?Windows-1252?Q?jWBJDlS7fdm+lcwmmjY6z8clRUNOMRVbBFDnHdmjH9hWayJVm7pbWAFF?= =?Windows-1252?Q?TFhfcRJ2k2Pql+wY/VJgYOa/HdXUz4RdJUR2TLB894M1NZUoI9Ci6gH0?= =?Windows-1252?Q?ORCq7ZRjE+RhKyQKPDQSWs0nGB+oJ+/RVdSVQTiToQt52h9B+NH09SPL?= =?Windows-1252?Q?25hxfoVx3UnufM+lgK6xKHJYYf+AMzVBtaMMX9dIBOsg1e2YHwCicYEU?= =?Windows-1252?Q?Y4lObdXJwkgYh0Cc3O4H+aOVd5W9FcDcjD6NTgMjAWGnEOTVNfzw3knd?= =?Windows-1252?Q?tf0Cz8FY87l376eP0XCoLF+U+jCzBgp1ouqLMMr3qJa6o?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;6:IkOAmzHOVJRH5vUAtiFgzLeNPPZ5K8/ED3H0enovDnK3rF4IAikK1uiOEqm2mDbZzCe4itLs3NQmMUk5hmXQ8p9KTJlWFux4fqDvGvOWroVdJc0Y5Co3L5/RHOfro6U45gIYrmgln+6tfQAAQ6K3u/N70JDBa/I28ru6l/SlLCOp6Hn7p6SwFGiLeDct3OiqmwteGB9zU4pdzSw5vAzvlrAXjhGPvbEulmbDQg3vlMnXfaKlge0FqCFR6OZKr1213GKY9q9VWUGyr1QFuB76bbNNJqhjX9s33BU+n9FcFmiQ5glSbNzUWyYVd2262DMPjy/2GTIXS4eHqYqW4eLnXeQQGXURnHdFaiTORGjdpkXoDqhHpZ2lyHgjgbN7A1YM4ls/PuiSZ8GbexmnSkAfDMq8nOR02b3L9EFzZOiD09Nv9+n3dYgH6d77Db5QiqWj;5:cz+4p0dCTeRXLXu2UpRFjrbiW7SrYuVLTrfe2YVTiVnSbx1cgbtR4vsHsCm1Hz3TnCPV/+7EUZYWqNMi/l6JvhawKplr9UN5ofxA/cyCmo8GVCWb4asfgcPahJ0mtJ5rF5hyLD83diKWadvzarQ/NKHWXXEHTz4FAYlbXAZd/m0=;24:1Dm+ciWOwK9MdE7QeEPnEK3n64KhRWmmEOvgXNnaL3aAnx/ufLAKdRyMugVN8E9x70Cli9VXruFB2/ZGniKYnDnhW9Wqkh9aIqlUEy4jdwM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;7:RqOkZqC+H+fVoyYuL/RHJk5SUIgYfKJYTvROD79z7M4M0ldZxPy6HeGpWE3l16Irz6x4y8GacrI7n2EFH6MkMffDFONAkalfPHVpyqHTiDgIcJ6ZZQflvFk/1KH0Xd8DySh1RXFKJVmrtA+xEb2vudrQpRNiGXc47c+E3ci4Dz2cRDzbZ6NDdMbUPcaNT3heR0ozRZB4UKGpuK+5Px+OZlqMTq/Fqbr5ZxLLNpMsQSQCSY3tF7mHetW/9AahHo6i4GC2a8Xt0NTganlzg8BBd+M9UsBI8XgBPgqPbeU7rVdEKwMWEedUO+F3ch2YSCVrCwoxV8pbgObnZ9opV0LdrPHjTWZqKpMdy7743ATCatshQIbRkLPg76i3txjCIbeeQ0fsbStqliu1/cWDEvBbDunD6mJk7s47bi0HRBc26M8H4Iy5d+s7RcTBarw7p7CpXoMxNMRICOq734HtIYPxJA== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2017 10:24:21.1595 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2559 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-01-22 14:30, Jonathan Cameron wrote: > On 18/01/17 15:57, Peter Rosin wrote: >> Allow bindings for a GPIO controlled mux to be specified in the >> mux consumer node. >> >> Signed-off-by: Peter Rosin > Code is good as far as I am concerned. Only question is whether this Hmmm, now that I think some more about it, the code supporting the simplified binding (patch 12/12) is a bit fishy in one respect. A driver that calls mux_control_get and gets a mux_control that happens to be backed by an implicit mux chip (i.e. using the simplified binding) will not be able to reverse the resource allocation with less than a complete destruction of itself. Now, this is likely not a problem in most cases, but I bet it will creep up at the most inopportune time. And your remark that I'm the one that has to maintain this makes me dislike this concept... I.e. mux_control_put *should* reverse mux_control_get, but this simply does not happen for the implicit mux chips, as implicit mux chips are not put away until the owning device is put away. Every time I have tried to come up with a way to implement the simplified bindings I seem to hit one of these subtleties. > is worth the hassle given the normal bindings don't give that high > a burden in complexity! I am missing an ack from Rob though. > I don't really care either way:) But Rob seems to care, this series just has to find a way to get out of his too-much-churn-will-look-at-it-later list. I sadly don't know how to pull that trick... Cheers, peda