From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61418C83000 for ; Tue, 28 Apr 2020 15:03:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A239205C9 for ; Tue, 28 Apr 2020 15:03:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ihv6F7Yb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727969AbgD1PD5 (ORCPT ); Tue, 28 Apr 2020 11:03:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727108AbgD1PD5 (ORCPT ); Tue, 28 Apr 2020 11:03:57 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01410C03C1AB for ; Tue, 28 Apr 2020 08:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-ID:Subject:From:Cc:To:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=j/OUD8l5Bcp+4HzVJDaOvU2cajwJy5v7q/4fx1IJCgo=; b=Ihv6F7Ybxvt/NmC0k9fSlET4N+ I6V5X2QmH2XP1YZs1E/C7/3AV4h9jxnQa88HSRS51aSF6ENaqsxl3NmlpoY0q05MDm8sPqpov0ijN F65JHTHr2wVymo4kwZK8nFsyXFAkt8YJFOUpfOAxMGoRq32iJldRo+X+F9bTPXJFrH5vy087cPQ4m k4cpix2AFUan4JYMV8Q2nYeQIww3pUfcdNkCb0GQ32lpRNIQswxAmXOqQv/XNBHnNm1j9YbmvUt+h Nij8W/TBeVoXMm/F+bCe4/5FEXaUi/T+QfUpf9Xb4C5Deoans9iGzHC+2wvmoKJ3caPuR01W7RK7i Zu34VsHQ==; Received: from [2601:1c0:6280:3f0::19c2] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTRm6-0005pn-5b; Tue, 28 Apr 2020 15:03:54 +0000 To: LKML , dm-devel@redhat.com Cc: Heinz Mauelshagen , Alasdair Kergon , Mike Snitzer From: Randy Dunlap Subject: [PATCH -next] md: dm-ebs-target: fix build errors & Kconfig entry Message-ID: Date: Tue, 28 Apr 2020 08:03:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap Fix build errors by selecting DM_BUFIO. Fix Kconfig entry formatting by using tabs instead of spaces, using "help" instead of "---help---", and indenting help text with one additional space. Fixes these build errors: ld: drivers/md/dm-ebs-target.o: in function `__ebs_forget_bio': dm-ebs-target.c:(.text+0x1bc): undefined reference to `dm_bufio_forget' ld: drivers/md/dm-ebs-target.o: in function `ebs_dtr': dm-ebs-target.c:(.text+0x2fe): undefined reference to `dm_bufio_client_destroy' ld: drivers/md/dm-ebs-target.o: in function `__ebs_rw_bio': dm-ebs-target.c:(.text+0x4c4): undefined reference to `dm_bufio_get_block_size' ld: dm-ebs-target.c:(.text+0x4f1): undefined reference to `dm_bufio_read' ld: dm-ebs-target.c:(.text+0x504): undefined reference to `dm_bufio_get_block_size' ld: dm-ebs-target.c:(.text+0x519): undefined reference to `dm_bufio_new' ld: dm-ebs-target.c:(.text+0x567): undefined reference to `dm_bufio_mark_partial_buffer_dirty' ld: dm-ebs-target.c:(.text+0x56f): undefined reference to `dm_bufio_release' ld: drivers/md/dm-ebs-target.o: in function `__ebs_process_bios': dm-ebs-target.c:(.text+0x6bf): undefined reference to `dm_bufio_prefetch' ld: dm-ebs-target.c:(.text+0x72d): undefined reference to `dm_bufio_prefetch' ld: dm-ebs-target.c:(.text+0x783): undefined reference to `dm_bufio_prefetch' ld: dm-ebs-target.c:(.text+0x7fe): undefined reference to `dm_bufio_write_dirty_buffers' ld: drivers/md/dm-ebs-target.o: in function `ebs_ctr': dm-ebs-target.c:(.text+0xa82): undefined reference to `dm_bufio_client_create' Signed-off-by: Randy Dunlap Cc: Heinz Mauelshagen Cc: Alasdair Kergon Cc: Mike Snitzer Cc: dm-devel@redhat.com --- drivers/md/Kconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- linux-next-20200428.orig/drivers/md/Kconfig +++ linux-next-20200428/drivers/md/Kconfig @@ -338,12 +338,12 @@ config DM_WRITECACHE to be cached in standard RAM. config DM_EBS - tristate "Emulated block size target (EXPERIMENTAL)" - depends on BLK_DEV_DM - default n - ---help--- - dm-ebs emulates smaller logical block size on backing devices - with larger ones (e.g. 512 byte sectors on 4K native disks). + tristate "Emulated block size target (EXPERIMENTAL)" + depends on BLK_DEV_DM + select DM_BUFIO + help + dm-ebs emulates smaller logical block size on backing devices + with larger ones (e.g. 512 byte sectors on 4K native disks). config DM_ERA tristate "Era target (EXPERIMENTAL)"