From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E381322157F; Mon, 18 Aug 2025 15:12:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755529965; cv=none; b=Be1SVs8+QyTVH8pE53O7mZlKWd2QGCEEN5VC3HwUqVfPrsZFy5iMJZnB2j13fnLREEZgI960sS+MkAg54BPTEVl7m7bVqSi8NxImz/MfNF2LNEEpXD0JEhy1seTkvsC3ybz3+b6YqOMMIiIvrN2uOMQVBwSsN7wez7NvrFAzosE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755529965; c=relaxed/simple; bh=dpppRVYb3p9b0pa9UF1vIrJFRi1LBx8rza/g/u2xqgI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jx2+Oah09KnKIO0qQtW/VEh3BeBs5xeQcGNaa/pMsUMizQC18eNhGNaZGBLE8UIUiBn4hhGJgGZhWNratW4qLyu+5OYwc5xz8KOgI/gTTKg1BF47Wx9qjcNgzu8+e+8/EbDOh3/zyx50Rpd5vnTjZX9KuvpRUTvF7/hghvZsCZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=hSw5q22E; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="hSw5q22E" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=A2uZ6sBwJJhD1qJtIOcJXKXzkTecfvVPk6dVElPUWcM=; b=hSw5q22EVmQNR2VNuyWMV2DitK HBd/Ejicstz6N12ahNgvzZPIhz7UFE4C1HFOhrjwy4hqT4EPXcgglQEiHC+t7KxqCnPn2vgFWx1Ea xdmTOX9ZsAlcBGGs8YZhnxdp4l5t6WvpdhFX5dVB2asjDZtfX5NJPUyQJfPGVOrnrT88=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1uo1X1-0054bw-3r; Mon, 18 Aug 2025 17:12:19 +0200 Date: Mon, 18 Aug 2025 17:12:19 +0200 From: Andrew Lunn To: Prabhakar Cc: =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Florian Fainelli , Geert Uytterhoeven , linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Fabrizio Castro , Prabhakar , stable@kernel.org Subject: Re: [PATCH] net: pcs-rzn1-miic: Correct MODCTRL register offset Message-ID: References: <20250818150757.3977908-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250818150757.3977908-1-prabhakar.mahadev-lad.rj@bp.renesas.com> On Mon, Aug 18, 2025 at 04:07:57PM +0100, Prabhakar wrote: > From: Lad Prabhakar https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html Please set the Subject: correctly. > Correct the Mode Control Register (MODCTRL) offset for RZ/N MIIC. > According to the R-IN Engine and Ethernet Peripherals Manual (Rev.1.30) > [0], Table 10.1 "Ethernet Accessory Register List", MODCTRL is at offset > 0x8, not 0x20 as previously defined. What effect does this have? How would i notice it is broken? Andrew --- pw-bot: cr