From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751355AbeC0I07 (ORCPT ); Tue, 27 Mar 2018 04:26:59 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:50638 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbeC0I05 (ORCPT ); Tue, 27 Mar 2018 04:26:57 -0400 MIME-Version: 1.0 Message-ID: Date: Tue, 27 Mar 2018 01:26:51 -0700 (PDT) From: Liran Alon To: Cc: , , , , Subject: Re: [PATCH 2/2] KVM: VMX: Add Force Emulation Prefix for "emulate the next instruction" X-Mailer: Zimbra on Oracle Beehive Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8844 signatures=668695 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803270083 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w2R8R4us023746 ----- pbonzini@redhat.com wrote: > On 27/03/2018 09:52, Liran Alon wrote: > > In addition, I think this module parameter should be in kvm module > > (not kvm_intel) and you should add similar logic to kvm_amd module > (SVM) > > If you can move handle_ud to x86.c, then it makes sense to have the > module parameter in the kvm module. I haven't checked. I don't see a reason why you couldn't do that. > > Otherwise you would have to EXPORT_SYMBOL_GPL the variable; in the This is what I did for enable_vmware_backdoor module parameter. I think this is what should be done in this case as-well. > end > it's just a debugging tool, so it'd be simpler to just add it > separately > to kvm_intel and kvm_amd. I agree it's just a debugging tool. But no reason for it to be used differently when running tests on Intel CPU vs. AMD CPU. I think the effort to fix this is low. > > Paolo