From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753962AbdCTLbW (ORCPT ); Mon, 20 Mar 2017 07:31:22 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:31567 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753680AbdCTLab (ORCPT ); Mon, 20 Mar 2017 07:30:31 -0400 Subject: Re: [PATCHv2 00/10] Nokia N950 basic display support To: Sebastian Reichel , Tony Lindgren , Aaro Koskinen , Laurent Pinchart References: <20170304235021.27055-1-sre@kernel.org> CC: David Airlie , , , From: Tomi Valkeinen Message-ID: Date: Mon, 20 Mar 2017 13:29:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170304235021.27055-1-sre@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2Kg7LOib4e4U9mpItmG5GWOripGj7gBAR" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2Kg7LOib4e4U9mpItmG5GWOripGj7gBAR Content-Type: multipart/mixed; boundary="IGaF6ArE7kxPGPDIxl3R9IRm8HP48ID2F"; protected-headers="v1" From: Tomi Valkeinen To: Sebastian Reichel , Tony Lindgren , Aaro Koskinen , Laurent Pinchart Cc: David Airlie , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCHv2 00/10] Nokia N950 basic display support References: <20170304235021.27055-1-sre@kernel.org> In-Reply-To: <20170304235021.27055-1-sre@kernel.org> --IGaF6ArE7kxPGPDIxl3R9IRm8HP48ID2F Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, On 05/03/17 01:50, Sebastian Reichel wrote: > Hi, >=20 > Some of you may remember, that I sent a series for the N950 display > some time ago. N950 has command mode DSI panel, so the main part of > the patchset takes care of adding manual display update support in > omapdrm. >=20 > The N950 also requires display rotation (the panel is mounted verticall= y > and bottom-up) and offset. The required bits will be sent separately. >=20 > The patchset is based on 2d62e0768d3c, which is the current commit > torvald's master branch points to. I tested the patches on N950 > with kernel console (fbcon), Tomi's kmstest and Xorg from Debian sid. >=20 > Rough changelog, most of that work was done by Tony (thanks!) >=20 > * lots of patches dropped for now > * rebased to current omapdrm interface > * added OMAP4 support > * misc. cleanup I haven't been able to go through this series with time, but looking at the patches, there were multiple places where I felt quite uneasy with the changes. It didn't help that many of the patches did not have descriptions. So as an RFC series, it's quite nice and shows that the manual update can be gotten to work. But I'm not ready to apply this until the patches touching the omapdrm enable, disable and commit sequences are split up into smaller patches with proper descriptions. Also, a minor note that rotating the display on N950 will cause tearing. Probably not a huge issue, though. Tomi --IGaF6ArE7kxPGPDIxl3R9IRm8HP48ID2F-- --2Kg7LOib4e4U9mpItmG5GWOripGj7gBAR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYz70fAAoJEPo9qoy8lh719osP/jNAkbHVqvp0k+WpvYpai20R 2z6o8Oq+zWS2S5IrlDLLE6YyNxFgC8Ka9pydDjE4Z8Knr+Xld2TJCJwJQnGEsOu7 lHaL/4l7TyZrPMInoMLJvg8SmbLpbsIDZ5kFlv2OJwXTKLFVEAVr3J1WAb6PYPPq Vkdsuxz1GtHFSp+bJm0yKrocchhZfLvnVjk1VcyJBkdq6JXbxEMXBV/uVPQmQMB7 dVAY07xz1fJNTEdlLL5UoywuqkZ5zTq3Xo6bmoTQtg8mnlGZUJCLYZIM444pKXDl h5XXsZDI0GPXkZtfad+FQCOiiu2CrzlAPJZ/24fYldjBrScpFoeEEGmAkdwTKeKK uVOS1+Ea23cX64e0Dy+dyalOPhzzzo9eLJHLrEOP4ewPaPYuOBke0/gpAdSiNPyy AkJRET4Fu16hBWryC9S8FOYvo6bYeGBnykUmPni0rM/7yWSfve3Sk6bjkVoMaT7/ rtl5vH7SzKT53gXwhXJmOPeGVDGvKSaPTq+OsiogJCgz2t1spjyjfPFNDLIhxnwR Jk95zh/HM19Qu16UhPcTtKNCqNzqh/bY5D1FF1/Woq5j2+xJKBBOSGDxT752w5eC a2bL3d/ftgdS7hxnYRdhFjvzXEheRsIhlWURP7oxjxUBoAn9vCd0E6v3xwbjyuh0 vWpC+uGvr6i6xNxiW9kK =u9Tj -----END PGP SIGNATURE----- --2Kg7LOib4e4U9mpItmG5GWOripGj7gBAR--