From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56A4514AD02 for ; Sat, 4 Jan 2025 09:35:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735983306; cv=none; b=FJCGyyEAHEIoUhgmwb34QpDGwdADDNRahBTY6+FljcayyAXPA891BFyLiQhCSdl8ISttWa4ckRvTjv2GHGTJLUNjVgGMFkJ7kq/Z6kaARkMXx8dHLCH3LmDK3wrFLdrKXPnp25/lNCHIoqBysjmVqyl7We2epflp/qSz00e5ngA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735983306; c=relaxed/simple; bh=9DwfVlPZKedN44pI/T1zeAy34WnuQkbQQOxuWVdvv6Y=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=X6yo0ssCQo1JD1MkSdizwKNhhLmxq1ss42rtL6tmInwpSiVudD0qlYYz3wXUdpDlrIxphUXWDJnyhRzfZGV0gyxwUQ84veo+WdxIGsxd6OmpgayFVjhhJrqbRz0cZqllGh+/20UQ53n5EPybp/gQh/eHwdW7aZSHtxQKlF55LQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KcgXkfqt; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KcgXkfqt" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4361aa6e517so20167225e9.2 for ; Sat, 04 Jan 2025 01:35:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735983302; x=1736588102; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=tfwQCCBu63aZTVhOZ4c/EiZehZjukgRMOTrP7C2cC/8=; b=KcgXkfqtFlWEMPOmx3XxrpTS4chEjRubyosorVXlcY6cJ7ChzvQVkjMFlqrC/68z5+ yvjl1OzSmAYin5QZusFAQHA+pRiV65eajxYqW3n0QWRiEDESvqZCE9M2MdDHwyguph7Y VdtFts7euxW4CRUqgA0ym4Qz7JFYaKaLLu9R7Ljvj4HJXO29vpPN9F/jkhgSaFWg4z24 BBWc73WHihu5JpKTvi8dxyNCzw+MOEVGh97ZXBJCCMoMMePSUBhOSb9P62uO+3wk5TWh 8wMNcSC6Dw2PtO3X4akn/vJ7nss/a5RohpHVmi6COu9BnysjmQ572/u7NQc78EBwPQC8 im+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735983302; x=1736588102; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tfwQCCBu63aZTVhOZ4c/EiZehZjukgRMOTrP7C2cC/8=; b=cMkHUaTssWy7tthaNR8PGMmz89GzIFbBWuWkUbxo7AHX418ik+4ZVPJXHHheYo1fy8 OTnlhII8LX87Vj5+DmwkzUOX+c9tr7iXH7dnCKhMlkqz4C1MBkE34Hk/mFiSYT/BA4yD Pl4jkQSFq5FRz92i97mxbHs1j2gkb2OsGGvPKZMKX9tORuV6n8R99HjxAKIaTP+gDYu+ E+vgLlWR8gJiUPQ5gJfnm+ui735aO0+SzLuI77UKlVq8nibJ9OzJDzz2iO5Atn9t9hFA 3IvzP7M9trO1Wo6YD+nY0YB9/ArZmGcixbsGzWLE7pThwmon23G2j7Mle0OTq8Hk3usc NdZQ== X-Forwarded-Encrypted: i=1; AJvYcCVVlfOpgP24biAzniI2yjtf40v0+NE47ABbgWQXYlDVc9+DgY0uerzp0h9Z2WQZFIoaas8aKYrNXyEmfQc=@vger.kernel.org X-Gm-Message-State: AOJu0YwoP3s45CYqiHek9PdVlmpeopl6yMCU0cI7Es3nl8XjYRJGHihn X3uMpjsAgPC/9t9Wa0ihznSYRdtx1v2y0DIxmpryOUS0zBemHF0CGMyAoCXUXgg= X-Gm-Gg: ASbGncvg2Z9sAfrmAFh9v4IHfdTsIaQaMS6HDfz5Uhw/eI0XKoHT8EFh1Of/T75uHjZ wfIqcXicHmlQvItWF3CbNxLU2H8gHu8Htx0Y0kDmYW+IfmGbTOsc70c7gNCfGUczLaUanDItaZH Uv+oEuRrAcYHFO6Myf1apeNM/vd0xWhzZbRRGCb2ykgiuQt93vfIeRu4lVFuIp9LEiZkkxtDTeT Of7TplAD4ikOkU5vKmJjH+gCtmvghh1AH1PQPZLG6IsGJgO7TUv5ixG0erPrkxK4XY5SqoDaHAO X-Google-Smtp-Source: AGHT+IG3FGlzh0yaJot++IsAzOuMcup0/rVdO0ni0icMoCmRYddvSjFlUUcahxyyoJSviClT6wmdLA== X-Received: by 2002:a05:600c:3ba8:b0:430:52ec:1e2a with SMTP id 5b1f17b1804b1-43668b8fd2amr168430765e9.7.1735983301759; Sat, 04 Jan 2025 01:35:01 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436612899f0sm508109245e9.38.2025.01.04.01.35.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Jan 2025 01:35:01 -0800 (PST) Message-ID: Date: Sat, 4 Jan 2025 10:34:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dt-bindings: vendor-prefixes: Add NetCube Systems Austria name From: Krzysztof Kozlowski To: Lukas Schmid Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Linus Walleij , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20250103204523.3779-1-lukas.schmid@netcube.li> <20250103204523.3779-2-lukas.schmid@netcube.li> Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/01/2025 10:30, Krzysztof Kozlowski wrote: > On Fri, Jan 03, 2025 at 08:45:17PM +0000, Lukas Schmid wrote: >> Signed-off-by: Lukas Schmid >> >> Acked-by: Krzysztof Kozlowski >> Signed-off-by: Lukas Schmid > > > Repeating again one of my comments: > > Please run scripts/checkpatch.pl and fix reported warnings. After that, > run also 'scripts/checkpatch.pl --strict' and (probably) fix more > warnings. Some warnings can be ignored, especially from --strict run, > but the code here looks like it needs a fix. Feel free to get in touch > if the warning is not clear. > > Please implement all comments. My bad, I did not write that hint earlier. Anyway, your patchset - all four patches - has multiple issues so you need to fix all of them before posting next version. Best regards, Krzysztof