From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 009A13D8122 for ; Fri, 24 Jul 2026 10:03:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784887430; cv=none; b=FhpSvj8RcFqjk2Xhm24KKL6e5tkK2h3T0wpTZp/dcjbHpctnipfknHfCxWJAY126gY2BekVbMxYuS96J2/Q9wUVQNll3JXL7yrOTyLKgT+LzlmlmGa6jfBYcQjrRj/W6RWTaOTNKfjk7jJRUS4OezYYY5KsJ5PATkRJTpQIrnEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784887430; c=relaxed/simple; bh=rvno8wd7jIFL+izZKRCFp1lPzwOg8SuwP7osdX6UAjk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PeMEGeMUjQeUJU+XthdnIq9vGRHFQ6oK+lnoqLq1oxbruNKDfU7/YnLcwmCW1xnVV9ZCP8DtNt5Rar1XTjgpavtfKIa1YsWDBvBfrs00Lfg5kkpPxR5uR0RHk+LTkzWRfAyCiLDJr/+KvWXWAoUM/Zjy62d+IPz3rsFlqdFcV4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nMM+x7Pe; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R212f0Z+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nMM+x7Pe"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R212f0Z+" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66OA3OB72696754 for ; Fri, 24 Jul 2026 10:03:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= u/I25kvrhW/lOQjcfnoyjW5dmk57g1obJPOlNaDgkuI=; b=nMM+x7Pe9xUneoxq 2osQ8FiWSOvihYZMin4BjJ3ydjqHeePs7JmERcqsKtsC1xV3U7JIVnZAK9aqpWFj 7MiVDlXpRjYELBf8L6nUZibfYDrZo2LsKjNaMw+hYG4xWUDJ+wekjcCJeDz6Jw2T zPeJCyTtjvocaxIDp1fSaBN5gyiW5M8eyirKEB03HFb/NPXeuD+vfyZ1Snc9eT+t WcuAXutTbFSbs6KSRPqVUgR927d4XXSr81bWbRyjZzbJ6Hs0R/jt+OzdxW1VqNvj ma6741iP5RA+W4PddjQeUvbkUrdbHvTkA9uUZr968/JxorxYmDwP5IK6ZBK8pOXH H4lXKg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fm5yag01x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 10:03:46 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-848474825ffso389881b3a.0 for ; Fri, 24 Jul 2026 03:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784887425; x=1785492225; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=u/I25kvrhW/lOQjcfnoyjW5dmk57g1obJPOlNaDgkuI=; b=R212f0Z+rPZnOJuXTTAnX6z1FgdKdXTCrH2/yac++gac/NtD8F2txd4yCbtmgNk1QG lusRLU7nBxAsvbwPml0yVEhm7e3C+ooSAzSJ8GEt03Z8ZsaViRrck10HL/XrnsZm6qoY 7z9/V4+j02i5Qb+sDijmCUxtlB2to52qVQN8TqRvWY9z3S0K92XWBv7ELomRNxaKfUJU RDbLB/57kCbcTaZfR5otRCkxOtObsdXWr/ONgj+8dJgk5qMEofnhPPwmMmX0ESii8Z+T 4YGYsQBKkLeiK0Mwb8s8pAE8kgwjkDZtb8OmtpmKIIuf53WVv/3TLNxFetMOahQfVbfQ iXYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784887425; x=1785492225; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=u/I25kvrhW/lOQjcfnoyjW5dmk57g1obJPOlNaDgkuI=; b=o2/yUGDwMdMW+QybOJ4dJpYMtUn3WqhCEWI5J7eSlm28u0ASe+HsdhAx7uQGuFvY7S 0IN3KEPKmrv4CSIHg8PbtzmwVaLsU16UJ3COqmxKvm+FZv9Uibyo0O0ay65m9BEsn7mI MxyXYME66LwrSAP7IMlVv4i1k1RpzHoLruU3D4/aUpBG3TT9bU/8zADC/j8emP/VhvU1 TZEFRvfdCVgqBOWyZ1VCGqikZxML91hkuAyGRN+GTdzWWtwB2PLIRMDKBaSBR6jWX6mq GAuYwM8cW7YdUKA20IVcR2DVAnt2BV8nMcFplg3ZzxBrA00jYJVS2qdWA0RKAD1gsaeS g/SQ== X-Forwarded-Encrypted: i=1; AHgh+Rp3jqVYL32DGnuR3/RQPi/un1nu0H5X5V+XkKsWE3aiYkpVu9xqNI39O/e6YN8EvaU4wS7Ja/OY/2Q8az8=@vger.kernel.org X-Gm-Message-State: AOJu0YyNWsUPFY+/rObnCO9CYuqSs1D39pFt/6d+wElVUyOBlZQjQVom e0NJGEd8kdaE410ghrMzaVAwKccvb2W5RNGDhAlvb+b05iOyrhaHQOEcb/TIiySjfjEy3isZ0YS 6P+d3cA/nDQXBHAQrM0zvVwEKihyZQaEPp5ljUKAD2s29dapUbmgi2tMfsuBuu5BX8Ks= X-Gm-Gg: AR+sD13fPHzRhVaT1eHsO8/z83S0Wybq6B5YKgg3IMLxU1FQkLrG5SbZZSxL4GPd+Pd vQiGtGgvsEIn7oCj88rPSFw35aUE2SrNg9wfZ/WNXP7DlA0bv0xsUv987YkRDhHgtLVfDePQYIZ QRxR72QHr9mJVbA2ExYhH3annBZZLRP59yNypYALTlhgIVInA0nEtmRr0H1UWnSRiLJOkU+6Rvs 7GpUR2N/5uV1uZ8LcRvCqT0q0USxWOTc56qA37YEOmvvd6yWu9Xybpp6wf0u0pnCdH1ZY8uP4q2 hQkB2Acdh/24RTzj7us/oh23bk+H/j1sNJSOUSwxV1pnHu2gt66rz9G1LdQgJ17PZMC8c6OLAaw PRW7y3iUlarCaYt1++u84tltjL6jY X-Received: by 2002:a05:6a00:4f8e:b0:848:536f:4236 with SMTP id d2e1a72fcca58-84e2e87750amr6754038b3a.22.1784887425568; Fri, 24 Jul 2026 03:03:45 -0700 (PDT) X-Received: by 2002:a05:6a00:4f8e:b0:848:536f:4236 with SMTP id d2e1a72fcca58-84e2e87750amr6754011b3a.22.1784887425152; Fri, 24 Jul 2026 03:03:45 -0700 (PDT) Received: from [10.217.217.237] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e17237704sm4435633b3a.2.2026.07.24.03.03.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 03:03:44 -0700 (PDT) Message-ID: Date: Fri, 24 Jul 2026 15:33:38 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] clk: qcom: gcc-hawi: Add support for global clock controller on Maili To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vivek Aknurwar Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260713-maili_initial_clock-v2-0-79548f0bb58f@oss.qualcomm.com> <20260713-maili_initial_clock-v2-4-79548f0bb58f@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDA5MSBTYWx0ZWRfXxWB/UZptO2jG TbswJ59UarauxdFthfe8ewiFkIFkZpJ2DqIfjdkMQUJLVO5RtQ9b5zysfrz8/NCNORYUVekESlH BhZKPpUhEYEaygEVbzwN4i2gsCzMWOY= X-Authority-Analysis: v=2.4 cv=Rtz16imK c=1 sm=1 tr=0 ts=6a633882 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=ieeZjMSIhZrtWKQ3Hg8A:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: dExTA_eF_datJ4PvJQNBoAx__052EBGA X-Proofpoint-ORIG-GUID: dExTA_eF_datJ4PvJQNBoAx__052EBGA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDA5MSBTYWx0ZWRfX86+/R0BZXgmF UQ2GrPRLgA5jaG3agF2uivB813TAZAHn5EAayv3dF+G+AT4o8mNuSZyqkpv9VNJ99yMz2Onv5KO Qcc0tRxW4XtadnFD7mCS4WjyHsCCu+d8oiXVgI+IqhkF1orZu5dpMmaObLsQMw8bVXhzasyUBdH k61rWzODMNnKmg8kL1wpJQXDqYorb4fxlDse+LXLqmJkZV/YmHtIVtHUIDzQb2X7/07+H4K/uKf rvO8y2g7rlRDF/rauoSvJ26/+vwWGiW1j99C8zcx7rHHWlAtKeNxJPoolJkkKf9IYA8xoZNMjr7 hSzpfVtPZKVzmprnm2Kw+MHZD3TWf/LHQ5dINvpDKy+W1SkxfA9Zs0io+zB0sc98pSb4inyh7lb xCMAldOcgbwu+FLXuZEM5BqtU/XSzQGMqUab//2zyD7K6YaCbakMlR97oYW44Rqq8tQEOnZ6IRZ be4UwykSmfeLbUvD8Fw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_01,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240091 On 7/17/2026 3:41 PM, Konrad Dybcio wrote: > This is unnecessary/wrong, as desc->num_clks validates the index in > qcom_cc_clk_hw_get(). > > Without this, we'd get an -EINVAL, with this we get a silent nullptr Konrad, I'll update the comment to clarify the rationale behind this requirement. /* Maili has more clocks than Hawi. Ensure the array is appropriately sized and assign the additional clocks in .probe() */ -- Thanks, Taniya Das