From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbcF0K5c (ORCPT ); Mon, 27 Jun 2016 06:57:32 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:33788 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751764AbcF0K5a (ORCPT ); Mon, 27 Jun 2016 06:57:30 -0400 Subject: Re: [PATCH net-next 6/6] r8152: add byte_enable for ocp_read_word function To: Hayes Wang , netdev@vger.kernel.org References: <1394712342-15778-184-Taiwan-albertk@realtek.com> <1394712342-15778-190-Taiwan-albertk@realtek.com> Cc: nic_swsd@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org From: Sergei Shtylyov Message-ID: Date: Mon, 27 Jun 2016 13:57:22 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1394712342-15778-190-Taiwan-albertk@realtek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 6/27/2016 8:07 AM, Hayes Wang wrote: > Add byte_enable for ocp_read_word() to replace reading 4 bytes data > with reading the desired 2 bytes data. > > This is used to avoid the issue which is described in commit:b4d99def. scripts/checkpatch.pl now enforces certain commit citing style, yours doesn't match. > The origin method always reads 4 bytes data, and it may have problem > when reading the PHY regiters. Registers. > The new method is supported since RTL8152B, but it doesn't influence > the previous chips. The bits of the byte_enable for the previous chips > are the reserved bits, and the hw would ignore them. > > Signed-off-by: Hayes Wang [...] MBR, Sergei